lints and more action issues

Author: wizzomafizzo

.golangci.yml

@@ -151,7 +151,6 @@ linters:
       min-complexity: 15
     cyclop:
       max-complexity: 15
-      skip-tests: true
     nestif:
       min-complexity: 4
     varnamelen:

cmd/nfctest/discovery.go

@@ -64,7 +64,7 @@ func (d *Discovery) DiscoverReaders(ctx context.Context) ([]detection.DeviceInfo
 }
 
 // CreateTransport creates the appropriate transport for a device
-func (d *Discovery) CreateTransport(reader detection.DeviceInfo) (pn532.Transport, error) {
+func (*Discovery) CreateTransport(reader detection.DeviceInfo) (pn532.Transport, error) {
 	switch reader.Transport {
 	case TransportUART:
 		transport, err := uart.New(reader.Path)
@@ -90,7 +90,7 @@ func (d *Discovery) CreateTransport(reader detection.DeviceInfo) (pn532.Transpor
 }
 
 // FindNewReaders finds readers that are new compared to the last scan
-func (d *Discovery) FindNewReaders(lastReaders, currentReaders []detection.DeviceInfo) []detection.DeviceInfo {
+func (*Discovery) FindNewReaders(lastReaders, currentReaders []detection.DeviceInfo) []detection.DeviceInfo {
 	var newReaders []detection.DeviceInfo
 
 	for _, current := range currentReaders {
@@ -110,7 +110,7 @@ func (d *Discovery) FindNewReaders(lastReaders, currentReaders []detection.Devic
 }
 
 // FindDisconnectedReaders finds readers that were present but are now gone
-func (d *Discovery) FindDisconnectedReaders(lastReaders, currentReaders []detection.DeviceInfo) []detection.DeviceInfo {
+func (*Discovery) FindDisconnectedReaders(lastReaders, currentReaders []detection.DeviceInfo) []detection.DeviceInfo {
 	var disconnected []detection.DeviceInfo
 
 	for _, last := range lastReaders {

cmd/nfctest/monitoring.go

@@ -50,7 +50,7 @@ func NewMonitoring(config *Config, output *Output, discovery *Discovery, testing
 
 // MonitorCards continuously monitors for cards using proper InAutoPoll continuous polling
 func (m *Monitoring) MonitorCards(ctx context.Context, readers []detection.DeviceInfo, isQuick bool) error {
-	fmt.Println("\nMonitoring for cards... (Ctrl+C to quit)")
+	_, _ = fmt.Println("\nMonitoring for cards... (Ctrl+C to quit)")
 
 	setup, err := m.initializeDevices(readers)
 	if err != nil {
@@ -148,7 +148,9 @@ func (m *Monitoring) startMonitoringLoop(ctx context.Context, setup *MonitoringS
 }
 
 // continuousPolling runs continuous InAutoPoll monitoring for a single reader
-func (m *Monitoring) continuousPolling(ctx context.Context, device *pn532.Device, readerPath string, state *CardState, isQuick bool) error {
+func (m *Monitoring) continuousPolling(
+	ctx context.Context, device *pn532.Device, readerPath string, state *CardState, isQuick bool,
+) error {
 	for {
 		select {
 		case <-ctx.Done():
@@ -173,7 +175,7 @@ func (m *Monitoring) continuousPolling(ctx context.Context, device *pn532.Device
 }
 
 // performSinglePoll performs a single tag detection cycle using the sophisticated strategy system
-func (m *Monitoring) performSinglePoll(ctx context.Context, device *pn532.Device) (*pn532.DetectedTag, error) {
+func (*Monitoring) performSinglePoll(ctx context.Context, device *pn532.Device) (*pn532.DetectedTag, error) {
 	// Use short timeout for responsive card removal detection
 	pollCtx, cancel := context.WithTimeout(ctx, 50*time.Millisecond)
 	defer cancel()
@@ -212,15 +214,17 @@ func (m *Monitoring) handleCardRemoval(state *CardState, readerPath string) {
 }
 
 // resetCardState resets the card state to empty
-func (m *Monitoring) resetCardState(state *CardState) {
+func (*Monitoring) resetCardState(state *CardState) {
 	state.Present = false
 	state.LastUID = ""
 	state.LastType = ""
 	state.TestedUID = ""
 }
 
 // processPollingResults processes the detected tag
-func (m *Monitoring) processPollingResults(device *pn532.Device, detectedTag *pn532.DetectedTag, state *CardState, readerPath string, isQuick bool) {
+func (m *Monitoring) processPollingResults(
+	device *pn532.Device, detectedTag *pn532.DetectedTag, state *CardState, readerPath string, isQuick bool,
+) {
 	if detectedTag == nil {
 		m.handleCardRemoval(state, readerPath)
 		return
@@ -259,12 +263,14 @@ func (m *Monitoring) updateCardState(state *CardState, detectedTag *pn532.Detect
 }
 
 // shouldTestCard determines if we should test the card
-func (m *Monitoring) shouldTestCard(state *CardState, currentUID string) bool {
+func (*Monitoring) shouldTestCard(state *CardState, currentUID string) bool {
 	return state.TestedUID != currentUID
 }
 
 // testAndRecordCard tests the card and records the result
-func (m *Monitoring) testAndRecordCard(device *pn532.Device, detectedTag *pn532.DetectedTag, state *CardState, isQuick bool) {
+func (m *Monitoring) testAndRecordCard(
+	device *pn532.Device, detectedTag *pn532.DetectedTag, state *CardState, isQuick bool,
+) {
 	if err := m.testing.TestCard(device, detectedTag, TestMode{Quick: isQuick}); err != nil {
 		m.output.Error("Card test failed: %v", err)
 	} else {
@@ -296,7 +302,7 @@ func (m *Monitoring) CheckCardsQuick(readers []detection.DeviceInfo) {
 
 		tags, err := device.DetectTags(1, 0x00)
 		if err == nil && len(tags) > 0 {
-			fmt.Printf("CARD: Card on %s: %s (UID: %s)\n",
+			_, _ = fmt.Printf("CARD: Card on %s: %s (UID: %s)\n",
 				reader.Path, tags[0].Type, tags[0].UID)
 		}
 

detection/uart/ports_windows.go

@@ -59,7 +59,6 @@ func enrichWithUSBInfo(ports []serialPort) ([]serialPort, error) {
 	setupDiGetClassDevs := setupapi.NewProc("SetupDiGetClassDevsW")
 	setupDiEnumDeviceInfo := setupapi.NewProc("SetupDiEnumDeviceInfo")
 	setupDiGetDeviceRegistryProperty := setupapi.NewProc("SetupDiGetDeviceRegistryPropertyW")
-	setupDiGetDeviceInstanceId := setupapi.NewProc("SetupDiGetDeviceInstanceIdW")
 	setupDiDestroyDeviceInfoList := setupapi.NewProc("SetupDiDestroyDeviceInfoList")
 
 	// GUID for Ports class
@@ -124,7 +123,7 @@ func enrichWithUSBInfo(ports []serialPort) ([]serialPort, error) {
 			SPDRP_FRIENDLYNAME,
 			uintptr(unsafe.Pointer(&propertyType)),
 			uintptr(unsafe.Pointer(&friendlyName[0])),
-			uint32(len(friendlyName)*2),
+			uintptr(uint32(len(friendlyName)*2)),
 			uintptr(unsafe.Pointer(&size)),
 		)
 
@@ -162,7 +161,7 @@ func enrichWithUSBInfo(ports []serialPort) ([]serialPort, error) {
 			SPDRP_HARDWAREID,
 			uintptr(unsafe.Pointer(&propertyType)),
 			uintptr(unsafe.Pointer(&hardwareID[0])),
-			uint32(len(hardwareID)*2),
+			uintptr(uint32(len(hardwareID)*2)),
 			uintptr(unsafe.Pointer(&size)),
 		)
 
@@ -184,7 +183,7 @@ func enrichWithUSBInfo(ports []serialPort) ([]serialPort, error) {
 			SPDRP_MFG,
 			uintptr(unsafe.Pointer(&propertyType)),
 			uintptr(unsafe.Pointer(&mfg[0])),
-			uint32(len(mfg)*2),
+			uintptr(uint32(len(mfg)*2)),
 			uintptr(unsafe.Pointer(&size)),
 		)
 

ntag.go

@@ -368,7 +368,8 @@ func (t *NTAGTag) readNDEFBlockByBlock() (*NDEFMessage, error) {
 		if i > 255 {
 			break // Prevent overflow
 		}
-		blockData, err := t.readBlockWithRetry(uint8(i))
+		// Safe conversion: i is checked to be <= 255
+		blockData, err := t.readBlockWithRetry(uint8(i)) // #nosec G115
 		if err != nil {
 			break
 		}