PES-2788: uninstall may not delete tables

Author: J7F

packetery/libs/ApiCarrier/ApiCarrierRepository.php

@@ -152,7 +152,7 @@ public function save(array $carriers, Packetery $module)
 
     public function getCreateTableSql()
     {
-        return 'CREATE TABLE `' . $this->getPrefixedTableName() . '` (
+        return 'CREATE TABLE IF NOT EXISTS `' . $this->getPrefixedTableName() . '` (
             `id` varchar(255) NOT NULL,
             `name` varchar(255) NOT NULL,
             `is_pickup_points` boolean NOT NULL,

packetery/libs/Log/LogRepository.php

@@ -120,7 +120,7 @@ public function getDropTableSql()
      */
     public function getCreateTableSql()
     {
-        return 'CREATE TABLE ' . $this->getPrefixedTableName() . ' (
+        return 'CREATE TABLE IF NOT EXISTS ' . $this->getPrefixedTableName() . ' (
             `id` int(11) NOT NULL AUTO_INCREMENT,
             `order_id` int(10) NULL,
             `params` text NOT NULL,

packetery/libs/Module/Installer.php

@@ -140,9 +140,13 @@ private function createMultiLangField($translationKey)
     private function installDatabase()
     {
         $sql = [];
+        // DB migrations do not work with PACKETERY_REMOVE_ALL_DATA set to false
+        $dropTables = !defined('PACKETERY_REMOVE_ALL_DATA') || PACKETERY_REMOVE_ALL_DATA;
 
-        $sql[] = 'DROP TABLE IF EXISTS `' . _DB_PREFIX_ . 'packetery_order`';
-        $sql[] = 'CREATE TABLE `' . _DB_PREFIX_ . 'packetery_order` (
+        if ($dropTables) {
+            $sql[] = 'DROP TABLE IF EXISTS `' . _DB_PREFIX_ . 'packetery_order`';
+        }
+        $sql[] = 'CREATE TABLE IF NOT EXISTS `' . _DB_PREFIX_ . 'packetery_order` (
             `id_order` int,
             `id_cart` int,
             `id_branch` int NULL,
@@ -173,14 +177,18 @@ private function installDatabase()
             UNIQUE(`id_cart`)
         ) ENGINE=InnoDB DEFAULT CHARSET=utf8;';
 
-        $sql[] = 'DROP TABLE IF EXISTS `' . _DB_PREFIX_ . 'packetery_payment`';
-        $sql[] = 'CREATE TABLE `' . _DB_PREFIX_ . 'packetery_payment` (
+        if ($dropTables) {
+            $sql[] = 'DROP TABLE IF EXISTS `' . _DB_PREFIX_ . 'packetery_payment`';
+        }
+        $sql[] = 'CREATE TABLE IF NOT EXISTS `' . _DB_PREFIX_ . 'packetery_payment` (
             `module_name` varchar(255) NOT NULL PRIMARY KEY,
             `is_cod` tinyint(1) NOT NULL DEFAULT 0
         ) ENGINE=InnoDB DEFAULT charset=utf8;';
 
-        $sql[] = 'DROP TABLE IF EXISTS `' . _DB_PREFIX_ . 'packetery_address_delivery`';
-        $sql[] = 'CREATE TABLE `' . _DB_PREFIX_ . 'packetery_address_delivery` (
+        if ($dropTables) {
+            $sql[] = 'DROP TABLE IF EXISTS `' . _DB_PREFIX_ . 'packetery_address_delivery`';
+        }
+        $sql[] = 'CREATE TABLE IF NOT EXISTS `' . _DB_PREFIX_ . 'packetery_address_delivery` (
             `id_carrier` int NOT NULL PRIMARY KEY,
             `id_branch` varchar(255) NOT NULL,
             `name_branch` varchar(255) NULL,
@@ -192,19 +200,27 @@ private function installDatabase()
         ) ENGINE=InnoDB DEFAULT CHARSET=utf8;';
 
         $productAttributeRepository = $this->module->diContainer->get(ProductAttributeRepository::class);
-        $sql[] = $productAttributeRepository->getDropTableSql();
+        if ($dropTables) {
+            $sql[] = $productAttributeRepository->getDropTableSql();
+        }
         $sql[] = $productAttributeRepository->getCreateTableSql();
 
         $apiCarrierRepository = $this->module->diContainer->get(ApiCarrierRepository::class);
-        $sql[] = $apiCarrierRepository->getDropTableSql();
+        if ($dropTables) {
+            $sql[] = $apiCarrierRepository->getDropTableSql();
+        }
         $sql[] = $apiCarrierRepository->getCreateTableSql();
 
         $logRepository = $this->module->diContainer->get(LogRepository::class);
-        $sql[] = $logRepository->getDropTableSql();
+        if ($dropTables) {
+            $sql[] = $logRepository->getDropTableSql();
+        }
         $sql[] = $logRepository->getCreateTableSql();
 
         $packetTrackingRepository = $this->module->diContainer->get(PacketTrackingRepository::class);
-        $sql[] = $packetTrackingRepository->getDropTableSql();
+        if ($dropTables) {
+            $sql[] = $packetTrackingRepository->getDropTableSql();
+        }
         $sql[] = $packetTrackingRepository->getCreateTableSql();
 
         if (!$this->dbTools->executeQueries($sql, $this->getExceptionRaisedText(), true)) {

packetery/libs/Module/Uninstaller.php

@@ -87,7 +87,7 @@ public function deleteTab($className)
      */
     private function uninstallDatabase()
     {
-        if (defined('PACKETERY_KEEP_DB_TABLES') && PACKETERY_KEEP_DB_TABLES) {
+        if (defined('PACKETERY_REMOVE_ALL_DATA') && !PACKETERY_REMOVE_ALL_DATA) {
             return true;
         }
 
@@ -144,7 +144,7 @@ private function unregisterHooks()
      */
     private function deleteConfiguration()
     {
-        if (defined('PACKETERY_KEEP_DB_TABLES') && PACKETERY_KEEP_DB_TABLES) {
+        if (defined('PACKETERY_REMOVE_ALL_DATA') && !PACKETERY_REMOVE_ALL_DATA) {
             return true;
         }
 

packetery/libs/PacketTracking/PacketTrackingRepository.php

@@ -84,7 +84,7 @@ public function getDropTableSql()
      */
     public function getCreateTableSql()
     {
-        return 'CREATE TABLE `' . $this->getPrefixedTableName() . '` (
+        return 'CREATE TABLE IF NOT EXISTS `' . $this->getPrefixedTableName() . '` (
           `id` int unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY,
           `id_order` int unsigned NOT NULL,
           `packet_id` varchar(15) NOT NULL,

packetery/libs/Product/ProductAttributeRepository.php

@@ -118,7 +118,7 @@ public function getDropTableSql()
      */
     public function getCreateTableSql()
     {
-        return 'CREATE TABLE `' . $this->getPrefixedTableName() . '` (
+        return 'CREATE TABLE IF NOT EXISTS `' . $this->getPrefixedTableName() . '` (
             `id_product` int(11) NOT NULL PRIMARY KEY,
             `is_adult` tinyint(1) NOT NULL DEFAULT 0
         ) ENGINE=InnoDB DEFAULT CHARSET=utf8;';