fix: Avoid registering the view-cube twice to address error messges generated by HMR.

phtaylor · phtaylor · commit 9be147ac022e · 2025-01-14T08:51:33.000-05:00
diff --git a/src/ui/view-cube.ts b/src/ui/view-cube.ts
@@ -15,7 +15,6 @@ class ZeaViewCube extends HTMLElement {
   faceHighlightColor = new Color(1, 0.9, 0.5)
   constructor() {
     super()
-
     this.attachShadow({ mode: 'open' })
   }
 
@@ -224,4 +223,6 @@ class ZeaViewCube extends HTMLElement {
   }
 }
 
-customElements.define('zea-view-cube', ZeaViewCube)
+if (!customElements.get('zea-view-cube')) {
+  customElements.define('zea-view-cube', ZeaViewCube)
+}

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ class ZeaViewCube extends HTMLElement {`
`15`	`15`	`faceHighlightColor = new Color(1, 0.9, 0.5)`
`16`	`16`	`constructor() {`
`17`	`17`	`super()`
`18`		`-`
`19`	`18`	`this.attachShadow({ mode: 'open' })`
`20`	`19`	`}`
`21`	`20`
`@@ -224,4 +223,6 @@ class ZeaViewCube extends HTMLElement {`
`224`	`223`	`}`
`225`	`224`	`}`
`226`	`225`
`227`		`-customElements.define('zea-view-cube', ZeaViewCube)`
	`226`	`+if (!customElements.get('zea-view-cube')) {`
	`227`	`+ customElements.define('zea-view-cube', ZeaViewCube)`
	`228`	`+}`