Skip to content

Commit 189e09b

Browse files
author
[zebinyang]
committed
fix a bug in decision_rule; update version 0.1.3
1 parent 767fab9 commit 189e09b

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

simtree/mobtree.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -449,16 +449,17 @@ def decision_rule(self, node_id):
449449
else:
450450
rule_dict.update({key:{"right": parent_node["threshold"]}})
451451
else:
452-
if "left" not in rule_dict[key].keys():
453-
rule_dict[key].update({"left": parent_node["threshold"]})
454-
else:
455-
rule_dict[key].update({"left": min(parent_node["threshold"], rule_dict[key]["left"])})
456-
if "right" not in rule_dict[key].keys():
457-
rule_dict[key].update({"right": parent_node["threshold"]})
452+
if current_node["is_left"]:
453+
if "left" not in rule_dict[key].keys():
454+
rule_dict[key].update({"left": parent_node["threshold"]})
455+
else:
456+
rule_dict[key].update({"left": min(parent_node["threshold"], rule_dict[key]["left"])})
458457
else:
459-
rule_dict[key].update({"right": max(parent_node["threshold"], rule_dict[key]["right"])})
458+
if "right" not in rule_dict[key].keys():
459+
rule_dict[key].update({"right": parent_node["threshold"]})
460+
else:
461+
rule_dict[key].update({"right": max(parent_node["threshold"], rule_dict[key]["right"])})
460462
current_node = parent_node
461-
print(rule_dict)
462463

463464
rule_list = []
464465
for key, item in rule_dict.items():

0 commit comments

Comments
 (0)