Errors running clang-tidy itself still gives a green tick in actions

[vadi2]

I've had a couple of errors running clang-tidy itself, from outdated syntax to missing dependencies - but the action still gave a green tick, and due to the split workflow, even claims I don't have issues in code.

I wanted to kindly suggest that these issues be looked into as it may cause confusion for users like myself who rely on the tool. As it stands, it is not entirely reliable and may lead to false positives if left unattended for a significant period.

[ZedThree]

I think other people had requested that it doesn't fail on errors, so maybe that should be a user option

[vadi2]

That sounds like a good approach.

[vadi2]

FTR it doesn't seem to be consistent - when the action itself has a problem, it gives an X.

[ZedThree]

Maybe the best thing to do is to catch exceptions at the highest level and then make an annotation with the error, and set the status to neutral or something. That way it will give an indication that the action hasn't worked without failing the checks