Skip to content

Update Modal to version 0.73.107 and adapt code to latest API changes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codegen-sh wants to merge 2 commits into from
Closed

Update Modal to version 0.73.107 and adapt code to latest API changes #11

codegen-sh wants to merge 2 commits into from

Conversation

@codegen-sh
Copy link

@codegen-sh codegen-sh bot commented Apr 30, 2025 •
edited by sourcery-ai bot
Loading

This PR updates the Modal library in the codegen-on-oss directory to version 0.73.107 and adapts the code to use the latest API changes.

Changes:

  1. Updated Modal version in pyproject.toml from 0.73.51 to 0.73.107
  2. Added include_source=True to all App declarations to ensure proper source code inclusion
  3. Renamed concurrency_limit to max_containers in function definitions as per Modal's API changes
  4. Added proper handling for modal.current_function_call_id() which can return None in some cases
  5. Updated README.md with information about the Modal version changes and new API usage

These changes ensure compatibility with the latest Modal API and follow the recommended practices for Modal 1.0 migration.

Testing:

The code has been updated according to Modal's latest documentation and changelog. The changes should maintain the same functionality while adapting to the new API requirements.

References:

💻 View my work • About Codegen

Summary by Sourcery

Update Modal library to version 0.73.107 and adapt code to its latest API changes

New Features:

  • Added include_source=True to Modal App declarations

Bug Fixes:

  • Renamed concurrency_limit to max_containers in function definitions to match new Modal API

Enhancements:

  • Improved handling of modal.current_function_call_id() to handle potential None return

Chores:

  • Updated Modal library dependency from 0.73.51 to 0.73.107
  • Updated Python version from 3.12 to 3.13 in README

@korbit-ai
Copy link

korbit-ai bot commented Apr 30, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 30, 2025 •
edited
Loading

Reviewer's Guide

This pull request updates the Modal library dependency to version 0.73.107 in pyproject.toml and refactors the code to align with the latest Modal API changes. Specifically, it adds include_source=True to modal.App initializations, renames the concurrency_limit parameter to max_containers in function definitions, and implements handling for potentially None values returned by modal.current_function_call_id(). Additionally, the README is updated to reflect these changes.

File-Level Changes

Change Details Files
Updated Modal library version.
  • Bumped modal dependency from 0.73.51 to 0.73.107.
 codegen-on-oss/pyproject.toml
Adapted code to Modal API changes for source inclusion and function configuration.
  • Added include_source=True parameter to modal.App declarations.
  • Renamed concurrency_limit parameter to max_containers in the @app.function decorator.
 codegen-on-oss/codegen_modal_deploy.py
codegen-on-oss/codegen_modal_run.py
codegen-on-oss/modal_run.py
Handled potentially None return value from modal.current_function_call_id().
  • Added a check for None when calling modal.current_function_call_id().
  • Assigned a default string value ('unknown') if None is returned.
 codegen-on-oss/codegen_modal_deploy.py
Updated documentation.
  • Updated Modal version reference.
  • Added details about the API changes (include_source, max_containers, current_function_call_id handling).
 codegen-on-oss/README.md
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link

coderabbitai bot commented Apr 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codegen-sh
Copy link
Author

codegen-sh bot commented Apr 30, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@codegen-sh
Copy link
Author

codegen-sh bot commented Apr 30, 2025

I'm looking into the failing check on PR #11. I can see that it's related to a permission issue with the GitHub Actions workflow. I'll fix this and push an update to the PR branch shortly.

💻 View my work

@codegen-sh
Copy link
Author

codegen-sh bot commented Apr 30, 2025

I'm working on fixing the failing check for PR #11. The issue is with the GitHub Actions workflow that's checking user permissions. I'll update the PR with a fix shortly.

💻 View my work

@Zeeeepa Zeeeepa force-pushed the develop branch 11 times, most recently from 27f0eca to f4656a2 Compare May 8, 2025 04:25
@codegen-sh codegen-sh bot closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant