ref(browser-utils): Revert getBodyString tests to original case

Signed-off-by: Kaung Zin Hein <[email protected]>

Author: Zen-cronic

packages/browser-utils/src/networkUtils.ts

@@ -45,6 +45,7 @@ export function getBodyString(body: unknown, _logger: Logger = logger): [string
 
 /**
  * Parses the fetch arguments to extract the request payload.
+ *
  * We only support getting the body from the fetch options.
  */
 export function getFetchRequestArgBody(fetchArgs: unknown[] = []): RequestInit['body'] | undefined {

packages/browser-utils/test/networkUtils.test.ts

@@ -6,34 +6,34 @@ import { describe, expect, it } from 'vitest';
 import { getBodyString, getFetchRequestArgBody, serializeFormData } from '../src/networkUtils';
 
 describe('getBodyString', () => {
-  it('should work with a string', () => {
+  it('works with a string', () => {
     const actual = getBodyString('abc');
     expect(actual).toEqual(['abc']);
   });
 
-  it('should work with URLSearchParams', () => {
+  it('works with URLSearchParams', () => {
     const body = new URLSearchParams();
     body.append('name', 'Anne');
     body.append('age', '32');
     const actual = getBodyString(body);
     expect(actual).toEqual(['name=Anne&age=32']);
   });
 
-  it('should work with FormData', () => {
+  it('works with FormData', () => {
     const body = new FormData();
-    body.append('name', 'Bob');
+    body.append('name', 'Anne');
     body.append('age', '32');
     const actual = getBodyString(body);
-    expect(actual).toEqual(['name=Bob&age=32']);
+    expect(actual).toEqual(['name=Anne&age=32']);
   });
 
-  it('should work with empty data', () => {
+  it('works with empty  data', () => {
     const body = undefined;
     const actual = getBodyString(body);
     expect(actual).toEqual([undefined]);
   });
 
-  it('should return unparsable with other types of data', () => {
+  it('works with other type of data', () => {
     const body = {};
     const actual = getBodyString(body);
     expect(actual).toEqual([undefined, 'UNPARSEABLE_BODY_TYPE']);
@@ -42,15 +42,15 @@ describe('getBodyString', () => {
 
 describe('getFetchRequestArgBody', () => {
   describe('valid types of body', () => {
-    it('should work with json string', () => {
+    it('works with json string', () => {
       const body = { data: [1, 2, 3] };
       const jsonBody = JSON.stringify(body);
 
       const actual = getFetchRequestArgBody(['http://example.com', { method: 'POST', body: jsonBody }]);
       expect(actual).toEqual(jsonBody);
     });
 
-    it('should work with URLSearchParams', () => {
+    it('works with URLSearchParams', () => {
       const body = new URLSearchParams();
       body.append('name', 'Anne');
       body.append('age', '32');
@@ -59,7 +59,7 @@ describe('getFetchRequestArgBody', () => {
       expect(actual).toEqual(body);
     });
 
-    it('should work with FormData', () => {
+    it('works with FormData', () => {
       const body = new FormData();
       body.append('name', 'Bob');
       body.append('age', '32');
@@ -68,13 +68,13 @@ describe('getFetchRequestArgBody', () => {
       expect(actual).toEqual(body);
     });
 
-    it('should work with Blob', () => {
+    it('works with Blob', () => {
       const body = new Blob(['example'], { type: 'text/plain' });
       const actual = getFetchRequestArgBody(['http://example.com', { method: 'POST', body }]);
       expect(actual).toEqual(body);
     });
 
-    it('should work with BufferSource (ArrayBufferView | ArrayBuffer)', () => {
+    it('works with BufferSource (ArrayBufferView | ArrayBuffer)', () => {
       const body = new Uint8Array([1, 2, 3]);
       const actual = getFetchRequestArgBody(['http://example.com', { method: 'POST', body }]);
       expect(actual).toEqual(body);

packages/browser/src/integrations/graphqlClient.ts

@@ -15,7 +15,7 @@ interface GraphQLClientOptions {
   endpoints: Array<string | RegExp>;
 }
 
-// Standard graphql request shape: https://graphql.org/learn/serving-over-http/#post-request-and-body
+/** Standard graphql request shape: https://graphql.org/learn/serving-over-http/#post-request-and-body */
 interface GraphQLRequestPayload {
   query: string;
   operationName?: string;
@@ -118,7 +118,8 @@ function _getGraphQLOperation(requestBody: GraphQLRequestPayload): string {
 }
 
 /**
- * Get the request body/payload based on the shape of the hint
+ * Get the request body/payload based on the shape of the hint.
+ * 
  * Exported for tests only.
  */
 export function getRequestPayloadXhrOrFetch(hint: XhrHint | FetchHint): string | undefined {
@@ -139,8 +140,8 @@ export function getRequestPayloadXhrOrFetch(hint: XhrHint | FetchHint): string |
 
 /**
  * Extract the name and type of the operation from the GraphQL query.
+ * 
  * Exported for tests only.
- * @param query
  */
 export function parseGraphQLQuery(query: string): GraphQLOperation {
   const queryRe = /^(?:\s*)(query|mutation|subscription)(?:\s*)(\w+)(?:\s*)[{(]/;