Skip to content

Commit 8ecc569

Browse files
committed
Fix variant and option access being incorrect
1 parent 18f066b commit 8ecc569

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

JavaBytecodeCompiler/src/main/java/org/openzen/zenscript/javabytecode/compiler/definitions/JavaDefinitionVisitor.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public byte[] visitVariant(VariantDefinition variant) {
227227
final String ss = "<" + javaTypeGenericVisitor.getGenericSignature(variant.typeParameters) + ">Ljava/lang/Object;";
228228
JavaClassWriter.registerSuperClass(variantName, "java/lang/Object");
229229

230-
writer.visit(Opcodes.V1_8, Opcodes.ACC_STATIC | Opcodes.ACC_PUBLIC, toClass.internalName, ss, "java/lang/Object", null);
230+
writer.visit(Opcodes.V1_8, Opcodes.ACC_PUBLIC | Opcodes.ACC_ABSTRACT, toClass.internalName, ss, "java/lang/Object", null);
231231
writer.visitMethod(Opcodes.ACC_PUBLIC | Opcodes.ACC_ABSTRACT, "getDenominator", "()I", null, null).visitEnd();
232232

233233
final JavaMemberVisitor visitor = new JavaMemberVisitor(context, writer, toClass, variant);
@@ -240,8 +240,7 @@ public byte[] visitVariant(VariantDefinition variant) {
240240
final String optionClassName = variantName + "$" + option.name;
241241
JavaClassWriter.registerSuperClass(optionClassName, variantName);
242242

243-
writer.visitInnerClass(optionTag.variantOptionClass.internalName, optionTag.variantClass.internalName, option.name, Opcodes.ACC_PUBLIC | Opcodes.ACC_FINAL);
244-
243+
writer.visitInnerClass(optionTag.variantOptionClass.internalName, optionTag.variantClass.internalName, option.name, Opcodes.ACC_PUBLIC | Opcodes.ACC_STATIC | Opcodes.ACC_FINAL);
245244
//Generic option signature
246245
final String signature;
247246
{
@@ -273,7 +272,7 @@ public byte[] visitVariant(VariantDefinition variant) {
273272
signature = builder.append(">;").toString();
274273
}
275274

276-
optionWriter.visit(Opcodes.V1_8, Opcodes.ACC_STATIC | Opcodes.ACC_PUBLIC, optionTag.variantOptionClass.internalName, signature, optionTag.variantClass.internalName, null);
275+
optionWriter.visit(Opcodes.V1_8, Opcodes.ACC_PUBLIC | Opcodes.ACC_STATIC | Opcodes.ACC_FINAL, optionTag.variantOptionClass.internalName, signature, optionTag.variantClass.internalName, null);
277276
final JavaMemberVisitor optionVisitor = new JavaMemberVisitor(context, optionWriter, optionTag.variantOptionClass, variant);
278277
final StringBuilder optionInitDescBuilder = new StringBuilder("(");
279278
final StringBuilder optionInitSignatureBuilder = new StringBuilder("(");

0 commit comments

Comments
 (0)