fix: resolve Firebase persistence and JSON parsing errors

- Fix JSON.parse() errors when reading legacy localStorage values
  - Added try-catch blocks in db.js local.get() to handle non-JSON strings
  - Gracefully falls back to raw string values for legacy data

- Fix Firebase persistence initialization error
  - Reorganized getDb() to call enablePersistence() on the db instance
  - Improved error handling to gracefully continue without persistence if needed
  - Updated surveyService.js to use centralized window.db.getDb()
  - Prevents 'persistence can no longer be enabled' errors

- Update @zenuml/core to v3.43.2

Author: MrCoder

package.json

@@ -82,7 +82,7 @@
     "@radix-ui/react-radio-group": "^1.1.3",
     "@radix-ui/react-select": "^2.0.0",
     "@radix-ui/react-tooltip": "^1.0.7",
-    "@zenuml/core": "^3.43.0",
+    "@zenuml/core": "^3.43.2",
     "clsx": "^2.0.0",
     "code-blast-codemirror": "chinchang/code-blast-codemirror#web-maker",
     "codemirror": "^5.65.16",

pnpm-lock.yaml

@@ -15,13 +15,26 @@ import { log } from './utils';
     get: (obj, cb) => {
       const retVal = {};
       if (typeof obj === 'string') {
-        retVal[obj] = JSON.parse(window.localStorage.getItem(obj));
+        try {
+          retVal[obj] = JSON.parse(window.localStorage.getItem(obj));
+        } catch (e) {
+          // Handle non-JSON values (legacy data stored as plain strings)
+          retVal[obj] = window.localStorage.getItem(obj);
+        }
         setTimeout(() => cb(retVal), FAUX_DELAY);
       } else {
         Object.keys(obj).forEach((key) => {
           const val = window.localStorage.getItem(key);
-          retVal[key] =
-            val === undefined || val === null ? obj[key] : JSON.parse(val);
+          if (val === undefined || val === null) {
+            retVal[key] = obj[key];
+          } else {
+            try {
+              retVal[key] = JSON.parse(val);
+            } catch (e) {
+              // Handle non-JSON values (legacy data stored as plain strings)
+              retVal[key] = val;
+            }
+          }
         });
         setTimeout(() => cb(retVal), FAUX_DELAY);
       }
@@ -55,32 +68,34 @@ import { log } from './utils';
       if (db) {
         return resolve(db);
       }
-      const store = firebase.firestore();
-      return store
-        .enablePersistence({ synchronizeTabs: true })
+      // Initialize Cloud Firestore through firebase
+      db = firebase.firestore();
+      
+      // Try to enable persistence, but don't fail if it's already been called
+      db.enablePersistence({ synchronizeTabs: true })
         .then(function () {
-          // Initialize Cloud Firestore through firebase
-          db = firebase.firestore();
-          // const settings = {
-          // 	timestampsInSnapshots: true
-          // };
-          // db.settings(settings);
-          log('firebase db ready', db);
+          log('firebase db ready with persistence', db);
           resolve(db);
         })
         .catch(function (err) {
-          reject(err.code);
           if (err.code === 'failed-precondition') {
             // Multiple tabs open, persistence can only be enabled
             // in one tab at a a time.
             alert(
               "Opening ZenUML web app in multiple tabs isn't supported at present and it seems like you already have it opened in another tab. Please use in one tab.",
             );
             trackEvent('fn', 'multiTabError');
+            reject(err.code);
           } else if (err.code === 'unimplemented') {
             // The current browser does not support all of the
             // features required to enable persistence
-            // ...
+            log('Persistence not supported, continuing without it');
+            resolve(db);
+          } else {
+            // If persistence was already enabled (e.g., by another call),
+            // just continue without it
+            log('Could not enable persistence, continuing without it:', err.message);
+            resolve(db);
           }
         });
     });

src/db.js

@@ -13,7 +13,7 @@ const COLLECTION_NAME = 'feature_surveys';
  */
 export async function saveSurveyResponse(responseData) {
   try {
-    const db = firebase.firestore();
+    const db = await window.db.getDb();
     const user = firebase.auth().currentUser;
 
     const surveyData = {
@@ -142,7 +142,7 @@ export async function syncFallbackSurveys() {
 
     if (fallbackData.length === 0) return;
 
-    const db = firebase.firestore();
+    const db = await window.db.getDb();
     const batch = db.batch();
 
     fallbackData.forEach((surveyData) => {