client: remove hack to handle undefined value for feedback context property

- we added the property manually for all drafts in Firebstore

Author: avine

client/src/app/give-feedback/give-feedback/give-feedback.component.ts

@@ -112,9 +112,6 @@ export class GiveFeedbackComponent implements LeaveForm, OnDestroy {
         }),
       )
       .subscribe((draft) => {
-        // WARNING:
-        // The `context` field may not be present in the `draft` object, because it was added to the feedback type later.
-        // Therefore DO NOT use `.setValue()` instead of `.patchValue()`, otherwise it will fail for old draft objects.
         this.form.patchValue(draft);
         this.form.updateValueAndValidity();
         this.leaveFormService.takeSnapshot();

client/src/app/give-feedback/give-requested-feedback/give-requested-feedback.component.ts

@@ -80,9 +80,6 @@ export class GiveRequestedFeedbackComponent implements GiveRequestedFeedbackData
   ngOnInit(): void {
     const draft = this.draft();
     if (draft) {
-      // WARNING:
-      // The `context` field may not be present in the `draft` object, because it was added to the feedback type later.
-      // Therefore DO NOT use `.setValue()` instead of `.patchValue()`, otherwise it will fail for old draft objects.
       this.form.patchValue(draft);
       this.form.updateValueAndValidity();
       this.leaveFormService.takeSnapshot();

client/src/app/give-feedback/shared/give-feedback-details/give-feedback-details.component.html

@@ -12,7 +12,7 @@
     i18n-placeholder="@@Component.GiveFeedbackDetails.ContextPlaceholder"
   ></textarea>
 
-  <mat-hint align="end">{{ context().value?.length ?? 0 }} / {{ contextMaxLength }}</mat-hint>
+  <mat-hint align="end">{{ context().value.length }} / {{ contextMaxLength }}</mat-hint>
 </mat-form-field>
 
 <mat-form-field appearance="outline" class="gbl-form-field">

client/src/app/give-feedback/shared/give-feedback-details/give-feedback-details.component.ts

@@ -36,9 +36,7 @@ export class GiveFeedbackDetailsComponent implements OnInit {
 
   protected commentMaxLength = MEDIUM_MAX_LENGTH;
 
-  // WARNING:
-  // The `context` field may not be present in the `draft` object, because it was added to the feedback type later.
-  context = input.required<FormControl<string | undefined>>();
+  context = input.required<FormControl<string>>();
 
   positive = input.required<FormControl<string>>();