GenServer Bottlenecks #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bottleneck in the way that ExAudit.CustomData stores pids in the ETS table. I was getting GenServer.call
time outerrors on my server. This PR ensures that the pid is written to ETS before the pid is stored in the GenServer. The GenServer is invoked with acastinstead of acallto make the request non-blocking. Inhandle_cast({:store ...the GenServer will first try to monitor the pid. Then it will check to see if the pid is still alive. If it is not, it will immediately remove it from the ets table. This prevents blocking the call in application code.