-
Notifications
You must be signed in to change notification settings - Fork 0
Try building llvm with Julia 1.12 #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Seemed like it would work locally and maybe gives some speedup with libgit2
| fi | ||
| cd L/LLVM/LLVM_full@20 | ||
| rm -rf bundled/libcxx_patches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat confused how musl is building currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might just be applying a patch to the headers that the resultant libcxx will ship, so wouldn't cause a build failure (given we don't try building julia with musl).
|
Hmm checkout seemed to take 42s on 1.7 and 1.12, maybe the speedup might be more significant if llvm repo wasn't cached? Still, seems like libgit2 slowness might not have been fixed. |
|
Alternative fix to libgit2 slowness is just replacing the GitSource with smth like |
|
Yeah, ~45s isn't too bad. |
| BINARYBUILDER_CCACHE_DIR: ${{ github.workspace }}/binarybuilder_ccache | ||
| LLVM_VERSION: ${{ inputs.LLVM_VERSION }} | ||
| LLVM_VERSION_MAJOR: ${{ inputs.LLVM_VERSION_MAJOR }} | ||
| JULIA_REGISTRYCI_AUTOMERGE: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always wondered if anyone would notice this trick for using BB in other Julia versions 😂
Seemed like it would work locally and maybe gives some speedup with libgit2