Skip to content

Commit 6d591d1

Browse files
committed
Removed the Choose Actor option in the Battles menu
1 parent 478e3ba commit 6d591d1

File tree

4 files changed

+21
-57
lines changed

4 files changed

+21
-57
lines changed

ttyd-tools/rel/source/draw.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1886,19 +1886,15 @@ void drawBattlesActorsList()
18861886
{
18871887
uint32_t tempCurrentPage = CurrentPage;
18881888
uint32_t TotalMenuOptions = 62; // Excluding System
1889-
uint32_t MaxOptionsPerPage = 14;
1889+
uint32_t MaxOptionsPerPage = 18;
18901890
uint32_t IndexStart = tempCurrentPage * MaxOptionsPerPage;
18911891

18921892
uint8_t Alpha = 0xFF;
18931893
int32_t PosX = -232;
1894-
int32_t PosY = 140;
1894+
int32_t PosY = 180;
18951895
float Scale = 0.6;
18961896
uint32_t Color;
18971897

1898-
// Draw the current page
1899-
drawPageNumber(PosX, PosY, tempCurrentPage);
1900-
PosY -= 40;
1901-
19021898
// Draw the main text
19031899
for (uint32_t i = IndexStart; i < (IndexStart + MaxOptionsPerPage); i++)
19041900
{
@@ -1933,7 +1929,7 @@ void drawBattlesActorsList()
19331929
}
19341930
}
19351931

1936-
if ((CurrentMenuOption == i) && (SelectedOption != 0))
1932+
if (CurrentMenuOption == i)
19371933
{
19381934
Color = 0x5B59DEFF;
19391935
}

ttyd-tools/rel/source/global.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -783,11 +783,6 @@ const char *MemoryChangeAddressLines[] =
783783
"Remove Pointer Level",
784784
};
785785

786-
const char *BattlesLines[] =
787-
{
788-
"Choose Actor",
789-
};
790-
791786
const char *BattlesActorsLines[] =
792787
{
793788
"Goomba",
@@ -1434,10 +1429,7 @@ void initMenuVars()
14341429
Menu[MEMORY_CHANGE_ADDRESS].PreviousMenu = MEMORY_MODIFY;
14351430
Menu[MEMORY_CHANGE_ADDRESS].Line = MemoryChangeAddressLines;
14361431

1437-
Menu[BATTLES].TotalMenuOptions = sizeof(BattlesLines) / sizeof(BattlesLines[0]);
1438-
Menu[BATTLES].ColumnSplitAmount = Menu[BATTLES].TotalMenuOptions;
14391432
Menu[BATTLES].PreviousMenu = ROOT;
1440-
Menu[BATTLES].Line = BattlesLines;
14411433

14421434
Menu[BATTLES_CURRENT_ACTOR].TotalMenuOptions = sizeof(BattlesCurrentActorLines) / sizeof(BattlesCurrentActorLines[0]);
14431435
Menu[BATTLES_CURRENT_ACTOR].ColumnSplitAmount = Menu[BATTLES_CURRENT_ACTOR].TotalMenuOptions;

ttyd-tools/rel/source/menu.cpp

Lines changed: 17 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -2019,61 +2019,32 @@ void menuCheckButton()
20192019
}
20202020
else
20212021
{
2022-
uint32_t MaxOptionsPerPage = 14;
20232022
switch (CurrentButton)
20242023
{
20252024
case DPADDOWN:
20262025
case DPADUP:
20272026
{
2028-
if (tempSelectedOption != 0)
2029-
{
2030-
adjustBattlesActorSelection(CurrentButton);
2031-
}
2027+
adjustBattlesActorSelection(CurrentButton);
20322028
break;
20332029
}
20342030
case A:
20352031
{
2036-
switch (tempSelectedOption)
2032+
// Make sure the current slot isn't empty
2033+
void *CurrentActorPointer = getActorPointer(tempCurrentMenuOption + 1); // Add 1 to skip System
2034+
if (CurrentActorPointer)
20372035
{
2038-
case 0:
2039-
{
2040-
SelectedOption = tempCurrentMenuOption + 1;
2041-
CurrentMenuOption = tempCurrentPage * MaxOptionsPerPage;
2042-
break;
2043-
}
2044-
default:
2045-
{
2046-
// Make sure the current slot isn't empty
2047-
void *CurrentActorPointer = getActorPointer(tempCurrentMenuOption + 1); // Add 1 to skip System
2048-
if (CurrentActorPointer)
2049-
{
2050-
// Go to the next menu
2051-
CurrentMenu = BATTLES_CURRENT_ACTOR;
2052-
MenuSelectedOption = tempCurrentMenuOption + 1; // Add 1 to skip System
2053-
resetMenu();
2054-
}
2055-
break;
2056-
}
2036+
// Go to the next menu
2037+
CurrentMenu = BATTLES_CURRENT_ACTOR;
2038+
MenuSelectedOption = tempCurrentMenuOption + 1; // Add 1 to skip System
2039+
resetMenu();
20572040
}
20582041
break;
20592042
}
20602043
case B:
20612044
{
2062-
switch (tempSelectedOption)
2063-
{
2064-
case 0:
2065-
{
2066-
// Go back to the previous menu
2067-
CurrentMenu = tempPreviousMenu;
2068-
resetMenu();
2069-
break;
2070-
}
2071-
default:
2072-
{
2073-
closeSecondaryMenu();
2074-
break;
2075-
}
2076-
}
2045+
// Go back to the previous menu
2046+
CurrentMenu = tempPreviousMenu;
2047+
resetMenu();
20772048
break;
20782049
}
20792050
default:
@@ -3258,7 +3229,12 @@ void drawMenu()
32583229
else
32593230
{
32603231
// Draw the text for the options
3261-
drawSingleColumnSelectedOption();
3232+
drawSingleColumnMain();
3233+
3234+
// Draw the page number
3235+
int32_t PosX = 150;
3236+
int32_t PosY = 180;
3237+
drawPageNumber(PosX, PosY, tempCurrentPage);
32623238

32633239
// Draw each actor
32643240
drawBattlesActorsList();

ttyd-tools/rel/source/menufunctions.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3683,7 +3683,7 @@ void adjustBattlesActorSelection(uint32_t button)
36833683
{
36843684
// Get the highest slot in use
36853685
uint32_t TotalMenuOptions = 62;
3686-
uint32_t MaxOptionsPerPage = 14;
3686+
uint32_t MaxOptionsPerPage = 18;
36873687
int32_t HighestSlot = 0;
36883688

36893689
for (uint32_t i = 1; i <= TotalMenuOptions; i++) // Start at 1 to skip System

0 commit comments

Comments
 (0)