Skip to content

Commit 8f9f378

Browse files
committed
Replaced some enums with defines
1 parent eeba7d5 commit 8f9f378

File tree

2 files changed

+21
-44
lines changed

2 files changed

+21
-44
lines changed

ttyd-tools/rel/include/global.h

Lines changed: 20 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,9 @@ enum INVENTORY_SELECTION
5858
DELETE,
5959
};
6060

61-
enum INVENTORY_SELECTION_ERRORS
62-
{
63-
INVENTORY_EMPTY = -2,
64-
INVENTORY_FULL,
65-
};
61+
// Inventory selection errors
62+
#define INVENTORY_EMPTY -2
63+
#define INVENTORY_FULL -1
6664

6765
enum CHEATS_OPTIONS
6866
{
@@ -99,7 +97,7 @@ enum CHEATS_CHANGE_SEQUENCE_SELECTION
9997

10098
enum CHEATS_STANDARD_SELECTION
10199
{
102-
TURN_ON_OR_OFF = 1,
100+
CHEATS_STANDARD_TURN_ON_OR_OFF = 1,
103101
CHANGE_BUTTON_COMBO,
104102
};
105103

@@ -109,13 +107,10 @@ enum CHEATS_FORCE_ITEM_DROP_SELECTION
109107
ITEM_DROP_CHANGE_BY_ID,
110108
};
111109

112-
enum CHEATS_RESOLVE_FADES_RETURN_VALUES
113-
{
114-
FADE_NOT_ACTIVE = -2,
115-
FADE_DONT_RESOLVE,
116-
FADE_RESOLVE_SUCCESS = 1,
117-
};
118-
110+
// Fades return values
111+
#define FADE_NOT_ACTIVE -2
112+
#define FADE_DONT_RESOLVE -1
113+
#define FADE_RESOLVE_SUCCESS 1
119114

120115
enum CHEATS_LOCK_FLAGS_SELECTION
121116
{
@@ -194,21 +189,12 @@ enum CHEATS_CLEAR_AREA_FLAGS_AREAS
194189
AREA_JON,
195190
};
196191

197-
enum ADJUSTABLE_MENU_VALUES
198-
{
199-
NO_NUMBERS_TO_DISPLAY = 0x1000,
200-
ADDING_BY_ID = 0x1008,
201-
};
202-
203-
enum ADD_BY_ICON_MENU_VALUES
204-
{
205-
ADDING_BY_ICON = 0x1108,
206-
};
207-
208-
enum CHEATS_SPAWN_ITEM_MENU_VALUE
209-
{
210-
SPAWN_ITEM_MENU_VALUE = 0x7000,
211-
};
192+
// Various menu values
193+
#define NO_NUMBERS_TO_DISPLAY 0x1000
194+
#define ADDING_BY_ID 0x1008
195+
#define ADDING_BY_ICON 0x1108
196+
#define SPAWN_ITEM_MENU_VALUE 0x7000
197+
#define STATS_PARTNER_DISPLAY_YOSHI_COLORS 100
212198

213199
enum STATS_MARIO_SELECTION_OPTIONS
214200
{
@@ -239,11 +225,6 @@ enum STATS_PARTNER_SELECTION_OPTIONS
239225
TOGGLE,
240226
};
241227

242-
enum STATS_PARTNER_WINDOW_TO_DISPLAY
243-
{
244-
STATS_PARTNER_DISPLAY_YOSHI_COLORS = 100,
245-
};
246-
247228
enum STATS_FOLLOWER_SELECTION_OPTIONS
248229
{
249230
BRING_OUT_FOLLOWER = 1,
@@ -305,11 +286,9 @@ enum MEMORY_MODIFY_ADDRESS_OPTIONS
305286
REMOVE_POINTER_LEVEL,
306287
};
307288

308-
enum MEMORY_ERRORS
309-
{
310-
ALL_SLOTS_EMPTY = -2,
311-
NO_SLOTS_LEFT,
312-
};
289+
// Memory error return values
290+
#define ALL_SLOTS_EMPTY -2
291+
#define NO_SLOTS_LEFT -1
313292

314293
enum BATTLES_CURRENT_ACTOR_STATS_SELECTION
315294
{
@@ -382,11 +361,9 @@ enum DISPLAYS_NO_BUTTON_COMBO_OPTIONS
382361
DISPLAYS_TURN_ON_OR_OFF = 1,
383362
};
384363

385-
enum ONSCREEN_TIMER_BUTTON_CODES
386-
{
387-
START_PAUSE_RESUME = 0,
388-
RESET,
389-
};
364+
// On-screen timer button codse
365+
#define START_PAUSE_RESUME 0
366+
#define RESET 1
390367

391368
enum WARPS_OPTIONS
392369
{

ttyd-tools/rel/source/menu.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ void menuCheckButton()
642642
uint32_t CurrentMenuOptionCheck = tempCurrentMenuOption + 1;
643643
switch (CurrentMenuOptionCheck)
644644
{
645-
case TURN_ON_OR_OFF:
645+
case CHEATS_STANDARD_TURN_ON_OR_OFF:
646646
{
647647
// Flip the bool for the current cheat
648648
bool CheatActive = Cheat[tempMenuSelectedOption].Active;

0 commit comments

Comments
 (0)