Fix bug with spawning items

Originally, if you were to spawn some items and then spawn a bunch more and letting them despawn, but keeping some items spawned, the counter would overflow and could end up using the same value as an item that is already spawned. This change should avoid that.

Technically, this code will still cause that to happen if the counter falls below 256, but it is highly unlikely that the code will be used that many times.

Author: Zephiles

ttyd-tools/rel/include/mod.h

@@ -107,7 +107,7 @@ class Mod
 
   // Spawn Item
   void spawnItem();
-  uint8_t spawnItemNameCounter;
+  uint16_t spawnItemNameCounter = 0xFFFF;
   bool spawnItemDisable = false;
   void spawnItemPreventCrash();
 

ttyd-tools/rel/source/codes/SpawnItemC.cpp

@@ -29,10 +29,10 @@ void Mod::spawnItem()
         if ((CoinCount >= 1) && (CoinCount <= 338))
         {
           // Coin count is a valid item ID
-          char *ItemName = new char[8]; // 6 bytes for C_Item, 1 byte for spawnItemNameCounter, 1 byte for NULL
+          char *ItemName = new char[9]; // 6 bytes for C_Item, 2 bytes for spawnItemNameCounter, 1 byte for NULL
           ttyd::string::strcpy(ItemName, "C_Item");
           ttyd::string::strcat(ItemName, reinterpret_cast<char *>(&spawnItemNameCounter));
-          spawnItemNameCounter++;
+          spawnItemNameCounter--;
 
           ttyd::mario::Player *player = ttyd::mario::marioGetPtr();
           float ItemCoordinateX = player->playerPosition[0];
@@ -42,10 +42,12 @@ void Mod::spawnItem()
           // Move item 30 units in front of Mario
           if (player->wPlayerDirection <= 0)
           {
+            // Mario is facing left
             ItemCoordinateX -= 30;
           }
           else
           {
+            // Mario is facing right
             ItemCoordinateX += 30;
           }