Skip to content

Commit 7009fa3

Browse files
cpetit-swclaude
andcommitted
fix(gh-release-please): resolve create_gh_release input not evaluated on push trigger
When triggered by push (not workflow_call), inputs are not populated and defaults do not apply. inputs.create_gh_release evaluates to '' instead of 'true', causing the tag major/minor step to be silently skipped. Move the value to an env var with a fallback, mirroring the existing pattern used for major_and_minor_tags. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 79403d4 commit 7009fa3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/gh-release-please.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
paths_released: ${{ steps.release.outputs.paths_released }}
5656
env:
5757
major_and_minor_tags: ${{ inputs.major_and_minor_tags || true }}
58+
create_gh_release: ${{ inputs.create_gh_release || 'true' }}
5859
steps:
5960
- name: Generate GitHub App Token
6061
id: generate-token
@@ -77,7 +78,7 @@ jobs:
7778
token: ${{ steps.generate-token.outputs.token }}
7879

7980
- name: tag major and minor versions
80-
if: ${{ steps.release.outputs.release_created == 'true' && env.major_and_minor_tags == 'true' && inputs.create_gh_release == 'true' }}
81+
if: ${{ steps.release.outputs.release_created == 'true' && env.major_and_minor_tags == 'true' && env.create_gh_release == 'true' }}
8182
run: |
8283
git config user.name github-actions[bot]
8384
git config user.email 41898282+github-actions[bot]@users.noreply.github.com

0 commit comments

Comments
 (0)