add valgrind tests

Author: ZeroIntensity

.github/workflows/memory_check.yml

@@ -0,0 +1,41 @@
+name: Memory Check
+
+on:
+    push:
+        branches:
+            - master
+    pull_request:
+        branches:
+            - master
+
+env:
+    PYTHONUNBUFFERED: "1"
+    FORCE_COLOR: "1"
+    PYTHONIOENCODING: "utf8"
+
+jobs:
+    run:
+        name: Valgrind on Ubuntu
+        runs-on: ubuntu-latest
+
+        steps:
+            - uses: actions/checkout@v2
+
+            - name: Set up Python 3.12
+              uses: actions/setup-python@v2
+              with:
+                  python-version: 3.12
+
+            - name: Install PyTest
+              run: |
+                  pip install pytest pytest-asyncio
+              shell: bash
+
+            - name: Build project
+              run: pip install .[full]
+
+            - name: Install Valgrind
+              run: sudo apt-get -y install valgrind
+
+            - name: Run tests with Valgrind
+              run: valgrind --supressions=valgrind-python.supp --error-exitcode=1 pytest -x

src/_view/results.c

@@ -88,8 +88,6 @@ static int find_result_for(
                 return -1;
             };
 
-            Py_DECREF(v_bytes);
-
             if (PyList_Append(
                 headers,
                 header_list

src/_view/routing.c

@@ -443,7 +443,6 @@ int handle_route_callback(
     if (!dct)
         return -1;
 
-
     coro = PyObject_Vectorcall(
         send,
         (PyObject*[]) { dct },

src/view/app.py

@@ -1022,6 +1022,12 @@ def load(self, *routes: Route) -> None:
         if routes and (self.config.app.loader != "manual"):
             warnings.warn(_ROUTES_WARN_MSG)
 
+        for index, i in enumerate(routes):
+            if not isinstance(i, Route):
+                raise TypeError(
+                    f"(index {index}) expected Route object, got {i}"
+                )
+
         if self.config.app.loader == "filesystem":
             load_fs(self, self.config.app.loader_path)
         elif self.config.app.loader == "simple":
@@ -1033,7 +1039,7 @@ def load(self, *routes: Route) -> None:
                 raise InvalidCustomLoaderError("custom loader was not set")
 
             collected = self._user_loader(self, self.config.app.loader_path)
-            if not isinstance(routes, CollectionsIterable):
+            if not isinstance(collected, CollectionsIterable):
                 raise InvalidCustomLoaderError(
                     f"expected custom loader to return a list of routes, got {collected!r}"
                 )

tests/test_app.py

@@ -779,7 +779,7 @@ def methodless_ctx(context: Context):
     async def m(context: Context):
         return context.method
 
-    app.load([m])
+    app.load(m)
 
     async with app.test() as test:
         assert (await test.get("/")).message == "a"

tests/test_loaders.py

@@ -36,7 +36,7 @@ async def d():
     async def o():
         return "options"
 
-    app.load([g, p, pu, pa, d, o])
+    app.load(g, p, pu, pa, d, o)
 
     async with app.test() as test:
         assert (await test.get("/get")).message == "get"
@@ -114,7 +114,7 @@ def test_custom_loader_errors():
 
     @app.custom_loader
     def my_loader(app: App, path: Path) -> List[Route]:
-        return 123
+        return 123  # type: ignore
 
     with pytest.raises(InvalidCustomLoaderError):
         app.load()

tests/test_websocket.py

@@ -41,7 +41,7 @@ async def back_and_forth(ws: WebSocket):
             assert message == count
             count += 1
 
-    app.load([back_and_forth])
+    app.load(back_and_forth)
 
     async with app.test() as test:
         async with test.websocket("/") as ws: