feat: propagate LDK error details in ChannelCreationFailed

Include the actual LDK APIError message in ChannelCreationFailed
instead of discarding it with a generic "Failed to create channel."
message. This surfaces rejection reasons (e.g., minimum channel size,
insufficient funds) to the UI.

Remove Copy derive from Error enum (replaced with Clone) to support
String field on ChannelCreationFailed variant.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: kaloudis

src/chain/bitcoind.rs

@@ -385,7 +385,7 @@ impl BitcoindChainSource {
 			)
 			.await;
 
-		self.wallet_polling_status.lock().unwrap().propagate_result_to_subscribers(res);
+		self.wallet_polling_status.lock().unwrap().propagate_result_to_subscribers(res.clone());
 
 		res
 	}

src/chain/electrum.rs

@@ -110,7 +110,7 @@ impl ElectrumChainSource {
 
 		let res = self.sync_onchain_wallet_inner(onchain_wallet).await;
 
-		self.onchain_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res);
+		self.onchain_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res.clone());
 
 		res
 	}
@@ -202,7 +202,7 @@ impl ElectrumChainSource {
 		let res =
 			self.sync_lightning_wallet_inner(channel_manager, chain_monitor, output_sweeper).await;
 
-		self.lightning_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res);
+		self.lightning_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res.clone());
 
 		res
 	}

src/chain/esplora.rs

@@ -95,7 +95,7 @@ impl EsploraChainSource {
 
 		let res = self.sync_onchain_wallet_inner(onchain_wallet).await;
 
-		self.onchain_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res);
+		self.onchain_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res.clone());
 
 		res
 	}
@@ -221,7 +221,7 @@ impl EsploraChainSource {
 		let res =
 			self.sync_lightning_wallet_inner(channel_manager, chain_monitor, output_sweeper).await;
 
-		self.lightning_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res);
+		self.lightning_wallet_sync_status.lock().unwrap().propagate_result_to_subscribers(res.clone());
 
 		res
 	}

src/connection.rs

@@ -108,7 +108,7 @@ where
 			},
 		};
 
-		self.propagate_result_to_subscribers(&node_id, res);
+		self.propagate_result_to_subscribers(&node_id, res.clone());
 
 		res
 	}
@@ -135,7 +135,7 @@ where
 		let mut pending_connections_lock = self.pending_connections.lock().unwrap();
 		if let Some(connection_ready_senders) = pending_connections_lock.remove(node_id) {
 			for sender in connection_ready_senders {
-				let _ = sender.send(res).map_err(|e| {
+				let _ = sender.send(res.clone()).map_err(|e| {
 					debug_assert!(
 						false,
 						"Failed to send connection result to subscribers: {:?}",

src/error.rs

@@ -14,7 +14,7 @@ use bdk_wallet::error::CreateTxError as BdkCreateTxError;
 #[allow(deprecated)]
 use bdk_wallet::signer::SignerError as BdkSignerError;
 
-#[derive(Copy, Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 /// An error that possibly needs to be handled by the user.
 pub enum Error {
 	/// Returned when trying to start [`crate::Node`] while it is already running.
@@ -40,7 +40,10 @@ pub enum Error {
 	/// Sending a payment probe has failed.
 	ProbeSendingFailed,
 	/// A channel could not be opened.
-	ChannelCreationFailed,
+	ChannelCreationFailed {
+		/// Details about why channel creation failed.
+		message: String,
+	},
 	/// A channel could not be closed.
 	ChannelClosingFailed,
 	/// A channel could not be spliced.
@@ -147,7 +150,7 @@ impl fmt::Display for Error {
 			Self::PaymentSendingFailed => write!(f, "Failed to send the given payment."),
 			Self::InvalidCustomTlvs => write!(f, "Failed to construct payment with custom TLVs."),
 			Self::ProbeSendingFailed => write!(f, "Failed to send the given payment probe."),
-			Self::ChannelCreationFailed => write!(f, "Failed to create channel."),
+			Self::ChannelCreationFailed { ref message } => write!(f, "Failed to create channel: {}", message),
 			Self::ChannelClosingFailed => write!(f, "Failed to close channel."),
 			Self::ChannelSplicingFailed => write!(f, "Failed to splice channel."),
 			Self::ChannelConfigUpdateFailed => write!(f, "Failed to update channel config."),

src/lib.rs

@@ -1159,7 +1159,7 @@ impl Node {
 			},
 			Err(e) => {
 				log_error!(self.logger, "Failed to initiate channel creation: {:?}", e);
-				Err(Error::ChannelCreationFailed)
+				Err(Error::ChannelCreationFailed { message: format!("{:?}", e) })
 			},
 		}
 	}
@@ -1267,7 +1267,7 @@ impl Node {
 	) -> Result<UserChannelId, Error> {
 		if let Err(err) = may_announce_channel(&self.config) {
 			log_error!(self.logger, "Failed to open announced channel as the node hasn't been sufficiently configured to act as a forwarding node: {}", err);
-			return Err(Error::ChannelCreationFailed);
+			return Err(Error::ChannelCreationFailed { message: format!("Node not configured for channel forwarding: {}", err) });
 		}
 
 		self.open_channel_inner(