get rubocopped

Author: hanneskt

README.md

@@ -48,6 +48,12 @@ See the `Makefile` for all commands.
 Run `bundle exec rake`\
 or if that doesn't work try `bundle exec rspec`?
 
+#### Linter (rubocop)
+- Run `bundle exec rubocop` to lint
+- To autocorrect most offences
+  - safely : `bundle exec rubocop -a`
+  - unsafely : `bundle exec rubocop -A`
+
 ## Deploy to production
 
 1. Make sure your user has access to tap@tap.zeus.gent.

app/controllers/users_controller.rb

@@ -108,10 +108,12 @@ def quick_order
     product = Product.find_by(id: params[:product_id])
 
     unless product
-      flash[:error] = "Product not found!"
+      flash.now[:error] = "Product not found!"
       respond_to do |format|
         format.html { redirect_back_or_to(root_path) }
-        format.json { render json: { message: "Quick order failed for #{@user.name}. Product not found." }, status: :bad_request }
+        format.json do
+          render json: { message: "Quick order failed for #{@user.name}. Product not found." }, status: :bad_request
+        end
       end
       return
     end
@@ -135,9 +137,11 @@ def quick_order
       flash[:error] = order.valid? ? "Something went wrong! Please try again." : order.errors.full_messages.join(". ")
       respond_to do |format|
         format.html { redirect_back_or_to(root_path) }
-        format.json { render json: {
-          message: order.errors.full_messages.join(". ")
-        }, status: :unprocessable_entity }
+        format.json do
+          render json: {
+            message: order.errors.full_messages.join(". ")
+          }, status: :unprocessable_content
+        end
       end
     end
   end

app/models/user.rb

@@ -109,11 +109,11 @@ def balance
 
   def last_ordered_products(amount = 5)
     orders.includes(:products)
-      .order(created_at: :desc)
-      .limit(amount)
-      .flat_map(&:products)
-      .uniq
-      .first(amount)
+          .order(created_at: :desc)
+          .limit(amount)
+          .flat_map(&:products)
+          .uniq
+          .first(amount)
   end
 
   # Static Users

spec/controllers/users_controller_spec.rb

@@ -225,7 +225,7 @@
     context "with an invalid product_id" do
       it "does not create an order" do
         expect do
-          post :quick_order, params: { id: user.id, product_id: 99999 }
+          post :quick_order, params: { id: user.id, product_id: 99_999 }
         end.not_to change(Order, :count)
       end
     end