lint: Fix rubocop offences.

Author: jnms-me

app/controllers/barcodes_controller.rb

@@ -18,13 +18,20 @@ class BarcodesController < ApplicationController
   # Get a list of all barcodes
   # GET /barcodes
   def index
-    @barcodes = Barcode.all.order(:code)
+    @barcodes = Barcode.order(:code)
     respond_to do |format|
       format.json { render json: @barcodes }
       format.html {} # rubocop:disable Lint/EmptyBlock
     end
   end
 
+  # Get a barcode by id
+  # GET /barcodes/{id}
+  def show
+    @barcode = Barcode.find_by(code: params[:id])
+    render json: @barcode.try(:product)
+  end
+
   # Create a new barcode page
   # GET /barcodes/new
   def new; end
@@ -35,7 +42,7 @@ def create
     # If the barcode exists, redirect to the product page of that product
     if Barcode.exists?(code: @barcode.code)
       flash[:info] = "Barcode already exists! This product is linked to the given barcode."
-      redirect_to edit_product_path(Barcode.where(code: @barcode.code).take.product)
+      redirect_to edit_product_path(Barcode.find_by(code: @barcode.code).product)
       return
     end
 
@@ -66,13 +73,6 @@ def create
     end
   end
 
-  # Get a barcode by id
-  # GET /barcodes/{id}
-  def show
-    @barcode = Barcode.find_by(code: params[:id])
-    render json: @barcode.try(:product)
-  end
-
   # Delete a barcode
   # POST(method: DELETE) /barcodes/{id}
   def destroy

app/controllers/concerns/statistics.rb

@@ -26,7 +26,9 @@ def products_group_by_id
     products
       .select("products.*", "sum(order_items.count) as count")
       .group(:product_id)
+      # rubocop:disable Rails/OrderArguments
       .order("count")
+      # rubocop:enable Rails/OrderArguments
       .reverse_order
   end
 

app/controllers/products_controller.rb

@@ -26,7 +26,7 @@ class ProductsController < ApplicationController
   # GET /products
   def index
     # If the user is not an admin, only show products that are not deleted
-    @products = (current_user.admin? ? Product.all : Product.for_sale).order("name asc")
+    @products = (current_user.admin? ? Product.all : Product.for_sale).order(:name)
     @categories = Product.categories
 
     respond_to do |format|

app/helpers/application_helper.rb

@@ -4,7 +4,7 @@ module ApplicationHelper
   include ActionView::Helpers::NumberHelper
 
   # Predicate for filtering the flash Hash for notifications
-  def flash_is_notification(flash_type)
+  def flash_is_notification?(flash_type)
     !flash_class(flash_type).nil?
   end
 

app/models/ability.rb

@@ -64,7 +64,7 @@ def initialize_user(user)
     # * The user is trying to delete an order for himself
     # * The order is still deletable (there is a specific time interval for deleting orders)
     can :destroy, Order do |order|
-      order.try(:user) == user && order.deletable
+      order.try(:user) == user && order.deletable?
     end
   end
 end

app/models/barcode.rb

@@ -13,6 +13,7 @@
 
 class Barcode < ApplicationRecord
   include FriendlyId
+
   friendly_id :code, use: :finders
 
   belongs_to :product

app/models/order.rb

@@ -20,7 +20,9 @@ class Order < ApplicationRecord
   has_many :products, through: :order_items
 
   before_validation :calculate_price
+  # rubocop:disable Style/CollectionQuerying
   before_save { |o| o.order_items = o.order_items.reject { |oi| oi.count.zero? } }
+  # rubocop:enable Style/CollectionQuerying
   after_create :create_api_job, unless: -> { user.guest? }
 
   after_create :update_user_frecency
@@ -42,7 +44,7 @@ def to_sentence
     end.to_sentence
   end
 
-  def deletable
+  def deletable?
     Time.zone.now <= deletable_until
   end
 

app/models/user.rb

@@ -27,6 +27,7 @@ class User < ApplicationRecord
   include FriendlyId
   include Avatarable
   include Statistics
+
   friendly_id :name, use: :finders
 
   devise :omniauthable, omniauth_providers: [:zeuswpi]

app/views/layouts/_flash.html.erb

@@ -1,5 +1,5 @@
 <% flash.each do |type, msg| %>
-  <% if flash_is_notification(type) %>
+  <% if flash_is_notification?(type) %>
     <div v-scope="{ open: true }" class="notification <%= isLight ? 'is-light' : '' %> <%= flash_class(type) %>" v-show="open">
         <!-- Close button -->
         <button class="delete" @click="open = false"></button>

app/views/orders/_order.html.erb

@@ -21,7 +21,7 @@
 
   <!-- Actions -->
   <td class="order-item-actions">
-    <% if order.deletable %>
+    <% if order.deletable? %>
       <%= button_to "Cancel order (until #{(order.deletable_until).strftime("%H:%M")})",
           user_order_path(@user, order),
           method: :delete,