lint: Fix rubocop offences.

Author: jnms-me

spec/controllers/barcodes_controller_spec.rb

@@ -17,9 +17,9 @@
 #                       DELETE   /barcodes/:id(.:format)                  barcodes#destroy
 #
 
-describe BarcodesController, type: :controller do
-  let(:product) { create :product }
-  let(:admin) { create :admin }
+describe BarcodesController do
+  let(:product) { create(:product) }
+  let(:admin) { create(:admin) }
 
   before do
     sign_in admin
@@ -53,7 +53,7 @@
 
   describe "GET index" do
     it "loads all the barcodes" do
-      barcode = create :barcode
+      barcode = create(:barcode)
       get :index
       expect(assigns(:barcodes)).to eq([barcode])
     end
@@ -64,7 +64,7 @@
   ##########
 
   describe "GET show" do
-    let(:barcode) { create :barcode }
+    let(:barcode) { create(:barcode) }
 
     it "loads the correct barcode" do
       get :show, params: { id: barcode }

spec/controllers/orders_controller_spec.rb

@@ -12,8 +12,8 @@
 #  transaction_id :integer
 #
 
-describe OrdersController, type: :controller do
-  let(:user) { create :user }
+describe OrdersController do
+  let(:user) { create(:user) }
 
   before do
     stub_request(:get, /.*/).to_return(status: 200, body: JSON.dump({ balance: 12_345 }))
@@ -26,14 +26,15 @@
 
   describe "INDEX orders" do
     let!(:final_orders) do
-      create_list :order, 2, user: user, created_at: Time.zone.now - Rails.application.config.call_api_after - 5.minutes
+      create_list(:order, 2, user: user,
+                             created_at: Time.zone.now - Rails.application.config.call_api_after - 5.minutes)
     end
-    let!(:pending_orders) { create_list :order, 2, user: user, created_at: Time.zone.now }
+    let!(:pending_orders) { create_list(:order, 2, user: user, created_at: Time.zone.now) }
 
     it "gets all orders for user without filter" do
       # Create some orders for another user
-      other_user = create :user
-      create_list :order, 2, user: other_user
+      other_user = create(:user)
+      create_list(:order, 2, user: other_user)
 
       get :index, params: { user_id: user }, format: :json
 

spec/controllers/products_controller_spec.rb

@@ -28,8 +28,8 @@
 #                       PUT      /products/:id(.:format)                  products#update
 #
 
-describe ProductsController, type: :controller do
-  let(:admin) { create :admin }
+describe ProductsController do
+  let(:admin) { create(:admin) }
 
   before do
     sign_in admin
@@ -73,7 +73,7 @@
 
   describe "GET index" do
     it "loads all the products" do
-      product = create :product
+      product = create(:product)
       get :index
       expect(assigns(:products)).to eq([product])
     end
@@ -84,7 +84,7 @@
   ##########
 
   describe "GET edit" do
-    let(:product) { create :product }
+    let(:product) { create(:product) }
 
     before do
       get :edit, params: { id: product }
@@ -108,7 +108,7 @@
   ############
 
   describe "PUT update" do
-    let(:product) { create :product }
+    let(:product) { create(:product) }
 
     it "loads right product" do
       put :update, params: { id: product, product: attributes_for(:product) }

spec/controllers/users_controller_spec.rb

@@ -30,8 +30,8 @@
 #                       PUT      /users/:id(.:format)                     users#update
 #
 
-describe UsersController, type: :controller do
-  let(:user) { create :user }
+describe UsersController do
+  let(:user) { create(:user) }
 
   before do
     sign_in user
@@ -78,7 +78,7 @@
       end
 
       it "updates dagschotel" do
-        product = create :product
+        product = create(:product)
         put :update, params: { id: user, user: { dagschotel_id: product.id } }
         expect(user.reload.dagschotel).to eq(product)
       end
@@ -127,7 +127,7 @@
 
   describe "GET quickpay" do
     describe "successful" do
-      let(:dagschotel) { create :product, stock: 20 }
+      let(:dagschotel) { create(:product, stock: 20) }
 
       before do
         balance = 12_345

spec/factories/order_items.rb

@@ -13,7 +13,7 @@
 FactoryBot.define do
   factory :order_item do
     order
-    association :product, factory: :product
+    product factory: %i[product]
     count { rand(1..5) }
   end
 end

spec/models/ability_spec.rb

@@ -10,7 +10,7 @@
 
     # Admin
     describe "as admin" do
-      let(:user) { create :admin }
+      let(:user) { create(:admin) }
 
       it { is_expected.to be_able_to(:manage, Barcode.new) }
       it { is_expected.to be_able_to(:manage, Product.new) }
@@ -20,7 +20,7 @@
 
     # Normal User
     describe "as normal user" do
-      let(:user) { create :user }
+      let(:user) { create(:user) }
 
       # it{ should be_able_to(:create, Order.new(user: user)) }
       it {
@@ -46,7 +46,7 @@
     end
 
     describe "as koelkast" do
-      let(:user) { create :koelkast }
+      let(:user) { create(:koelkast) }
 
       it { is_expected.not_to be_able_to(:manage, Product.new) }
       # it{ should be_able_to(:manage, Order.new, user: create(:user)) }

spec/models/barcode_spec.rb

@@ -12,7 +12,7 @@
 #
 
 describe Barcode do
-  let(:barcode) { create :barcode }
+  let(:barcode) { create(:barcode) }
 
   it "has a valid factory" do
     expect(barcode).to be_valid
@@ -30,7 +30,7 @@
       end
 
       it "is unique" do
-        local_barcode = build :barcode, code: barcode.code
+        local_barcode = build(:barcode, code: barcode.code)
         expect(local_barcode).not_to be_valid
       end
     end

spec/models/order_item_spec.rb

@@ -16,7 +16,7 @@
   end
 
   it "has a valid factory" do
-    order_item = create :order_item
+    order_item = create(:order_item)
     expect(order_item).to be_valid
   end
 
@@ -25,7 +25,7 @@
   ############
 
   describe "fields" do
-    let(:order_item) { create :order_item }
+    let(:order_item) { create(:order_item) }
 
     describe "product" do
       it "is present" do
@@ -60,10 +60,10 @@
   ###############
 
   describe "stock change" do
-    let(:product) { create :product }
-    let(:order) { create :order }
+    let(:product) { create(:product) }
+    let(:order) { create(:order) }
     let(:count) { rand 10 }
-    let(:order_item) { build :order_item, product: product, order: order, count: count }
+    let(:order_item) { build(:order_item, product: product, order: order, count: count) }
 
     it "decrements on create" do
       expect { order_item.save }.to change(product, :stock).by(-count)

spec/models/order_spec.rb

@@ -13,8 +13,8 @@
 #
 
 describe Order do
-  let(:user) { create :user }
-  let(:order) { create :order, user: user }
+  let(:user) { create(:user) }
+  let(:order) { create(:order, user: user) }
 
   before do
     stub_request(:get, /.*/).to_return(status: 200, body: JSON.dump({ balance: 20 }))
@@ -42,8 +42,8 @@
 
     describe "price_cents" do
       it "is calculated from order_items" do
-        order = build :order, products_count: 0
-        sum = (create_list :product, rand(1..10)).map do |p|
+        order = build(:order, products_count: 0)
+        sum = create_list(:product, rand(1..10)).map do |p|
           build(:order_item, order: order, product: p, count: rand(1..5)) do |oi|
             order.order_items << oi
           end
@@ -68,7 +68,7 @@
 
   describe "empty order_items" do
     it "is removed" do
-      product = create :product
+      product = create(:product)
       order.order_items << create(:order_item, order: order, product: product, count: 0)
       order.save
       expect(order.order_items.where(product: product)).to be_empty

spec/models/product_spec.rb

@@ -20,7 +20,7 @@
 #
 
 describe Product do
-  let(:product) { create :product }
+  let(:product) { create(:product) }
 
   it "has a valid factory" do
     expect(product).to be_valid
@@ -133,7 +133,7 @@
 
   describe "for sale" do
     it "returns non-deleted products" do
-      local_product = create :product
+      local_product = create(:product)
       local_product.update(deleted: true)
       expect(described_class.for_sale).to eq([product])
     end