[llvm-debuginfo-analyzer][llvmorg-20.1.5] Fix ODR violation in llvm::logicalview::LVObject #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LVObject::dump()` does not need to be virtual as it relays to `LVObject::print()` that is.
…LVObject Fix ODR violation in `LVObject` when `DebugInfoLogicalView` library is used in a downstream project. Depending solely on `NDEBUG` for exposing some data members may cause trouble in downstream projects. Enable such cases only if `LLVM_ENABLE_ABI_BREAKING_CHECKS`.
peledins-zimperium
approved these changes
Jun 10, 2025
peledins-zimperium
left a comment
peledins-zimperium
left a comment
There was a problem hiding this comment.
If you recompile llvm libraries, you could also add arm64 compilation - both asan and not or maybe just the plain one.
jalopezg-git
merged commit e8ee4f1
into
Zimperium:zmpr-b-llvmorg-20.1.5-patches
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some data members are only part of a class definition in a Debug build, e.g.
LVObject::ID. Ifdebuginfologicalviewis used as a library,NDEBUGcannot be used for this purpose, as this PP macro may have a different definition in a downstream project, which in turn triggers an ODR violation.LVObject::ID, temporarily went for#if !defined(NDEBUG) && LLVM_ENABLE_ABI_BREAKING_CHECKS(instead of plain#ifndef NDEBUG). This should fix the original issue.LVObject::dump()function isvirtual, and hence appears in the vtable for classLVObject. Thus, it participates also in class layout and is subject to the same issue. Fixed it by makingLVObject::dump()non-virtual.Rationale:
virtualis not needed (and it callsprint(), which is virtual anyway).This is a backport of upstream PR llvm#140265.
Fixes llvm#139098.