refactor: update PathData to use ConfigMetadata instance

- Add metadata property to return ConfigMetadata instance
- Update tests to use ConfigMetadata properties directly
- Improve test coverage in test_to_dict_from_dict
- Maintain backward compatibility

Author: ritwik-g

helm_values_manager/models/path_data.py

@@ -7,6 +7,7 @@
 
 from typing import Any, Callable, Dict, Iterator, Optional
 
+from helm_values_manager.models.config_metadata import ConfigMetadata
 from helm_values_manager.models.value import Value
 from helm_values_manager.utils.logger import logger
 
@@ -23,7 +24,11 @@ def __init__(self, path: str, metadata: Dict[str, Any]):
             metadata: Dictionary containing metadata fields
         """
         self.path = path
-        self.metadata = metadata
+        self._metadata = ConfigMetadata(
+            description=metadata.get("description"),
+            required=metadata.get("required", False),
+            sensitive=metadata.get("sensitive", False),
+        )
         self._values: Dict[str, Value] = {}
 
     def validate(self) -> None:
@@ -47,7 +52,7 @@ def validate(self) -> None:
                 raise ValueError(f"Value for environment {env} has inconsistent path: {value.path} != {self.path}")
 
             # Check required values
-            if self.metadata.get("required", False):
+            if self._metadata.required:
                 val = value.get()
                 if val is None or val == "":
                     logger.error("Missing required value for path %s in environment %s", self.path, env)
@@ -106,12 +111,22 @@ def to_dict(self) -> Dict[str, Any]:
         """
         return {
             "path": self.path,
-            "description": self.metadata.get("description"),
-            "required": self.metadata.get("required", False),
-            "sensitive": self.metadata.get("sensitive", False),
+            "description": self._metadata.description,
+            "required": self._metadata.required,
+            "sensitive": self._metadata.sensitive,
             "values": {env: value.get() for env, value in self._values.items()},
         }
 
+    @property
+    def metadata(self) -> ConfigMetadata:
+        """
+        Get metadata for this path.
+
+        Returns:
+            ConfigMetadata: Metadata instance for this path
+        """
+        return self._metadata
+
     @classmethod
     def from_dict(
         cls, data: Dict[str, Any], create_value_fn: Callable[[str, str, Dict[str, Any]], Value]

tests/unit/models/test_helm_values_config.py

@@ -26,9 +26,9 @@ def test_add_config_path():
     path_data = config._path_map[path]
     assert isinstance(path_data, PathData)
     assert path_data.path == path
-    assert path_data.metadata["description"] == description
-    assert path_data.metadata["required"] is True
-    assert path_data.metadata["sensitive"] is False
+    assert path_data.metadata.description == description
+    assert path_data.metadata.required is True
+    assert path_data.metadata.sensitive is False
 
 
 def test_add_duplicate_path():
@@ -88,33 +88,66 @@ def test_set_value_without_path():
 
 def test_to_dict_from_dict():
     """Test serialization and deserialization."""
-    config = HelmValuesConfig()
-    path = "app.config.key1"
-    description = "Test config"
-    value = "test-value"
-    environment = "dev"
-
-    config.add_config_path(path, description=description, required=True, sensitive=False)
-    config.set_value(path, environment, value)
-
+    config_data = {
+        "version": "1.0",
+        "release": "test-release",
+        "deployments": {
+            "prod": {
+                "backend": "aws",
+                "auth": {"type": "env", "env_prefix": "AWS_"},
+                "backend_config": {"region": "us-west-2"},
+            }
+        },
+        "config": [
+            {
+                "path": "app.config.key1",
+                "description": "Test config",
+                "required": True,
+                "sensitive": True,
+                "values": {"default": "test-value"},
+            }
+        ],
+    }
+
+    # Test from_dict
+    config = HelmValuesConfig.from_dict(config_data)
+    assert config.release == "test-release"
+    assert config.version == "1.0"
+    assert len(config.deployments) == 1
+    assert len(config._path_map) == 1
+
+    # Verify deployment data
+    deployment = config.deployments["prod"]
+    assert deployment.backend == "aws"
+    assert deployment.auth == {"type": "env", "env_prefix": "AWS_"}
+    assert deployment.backend_config == {"region": "us-west-2"}
+
+    # Verify config data
+    path_data = config._path_map["app.config.key1"]
+    assert path_data.path == "app.config.key1"
+    assert path_data.metadata.description == "Test config"
+    assert path_data.metadata.required is True
+    assert path_data.metadata.sensitive is True
+
+    # Test to_dict
     config_dict = config.to_dict()
     assert config_dict["version"] == "1.0"
-    assert config_dict["deployments"] == {}
+    assert config_dict["release"] == "test-release"
+    assert config_dict["deployments"] == {
+        "prod": {
+            "backend": "aws",
+            "auth": {"type": "env", "env_prefix": "AWS_"},
+            "backend_config": {"region": "us-west-2"},
+        }
+    }
     assert len(config_dict["config"]) == 1
 
     config_item = config_dict["config"][0]
-    assert config_item["path"] == path
-    assert config_item["description"] == description
+    assert config_item["path"] == "app.config.key1"
+    assert config_item["description"] == "Test config"
     assert config_item["required"] is True
-    assert config_item["sensitive"] is False
-    assert config_item["values"] == {environment: value}
-
-    # Test deserialization
-    new_config = HelmValuesConfig.from_dict(config_dict)
-    assert new_config.get_value(path, environment) == value
-    assert new_config._path_map[path].metadata["description"] == description
-    assert new_config._path_map[path].metadata["required"] is True
-    assert new_config._path_map[path].metadata["sensitive"] is False
+    assert config_item["sensitive"] is True
+    assert config_item["values"] == {"default": "test-value"}
 
 
 def test_validate():

tests/unit/models/test_path_data.py

@@ -32,9 +32,9 @@ def mock_value():
 def test_path_data_init(path_data):
     """Test PathData initialization."""
     assert path_data.path == "test.path"
-    assert path_data.metadata["description"] == "Test description"
-    assert path_data.metadata["required"] is True
-    assert path_data.metadata["sensitive"] is False
+    assert path_data.metadata.description == "Test description"
+    assert path_data.metadata.required is True
+    assert path_data.metadata.sensitive is False
 
 
 def test_set_value(path_data, mock_value):
@@ -103,7 +103,7 @@ def test_validate_success(path_data, mock_value):
 
 def test_validate_not_required(path_data, mock_value):
     """Test validation when path is not required."""
-    path_data.metadata["required"] = False
+    path_data.metadata.required = False
     mock_value.get.return_value = None
     path_data.set_value("test_env", mock_value)
     path_data.validate()  # Should not raise any error
@@ -140,11 +140,9 @@ def create_value_fn(path, env, value_data):
 
     path_data = PathData.from_dict(data, create_value_fn)
     assert path_data.path == "test.path"
-    assert path_data.metadata == {
-        "description": "Test description",
-        "required": True,
-        "sensitive": False,
-    }
+    assert path_data.metadata.description == "Test description"
+    assert path_data.metadata.required is True
+    assert path_data.metadata.sensitive is False
     assert len(path_data._values) == 1
     assert "test_env" in path_data._values
 

tests/unit/models/test_schema_validation.py

@@ -19,7 +19,7 @@ def test_valid_minimal_config():
 
 
 def test_valid_full_config():
-    """Test loading a complete configuration with all optional fields."""
+    """Test loading a valid configuration with all fields."""
     config_data = {
         "version": "1.0",
         "release": "test-release",
@@ -56,9 +56,9 @@ def test_valid_full_config():
     # Verify config data
     path_data = config._path_map["app.config.key1"]
     assert path_data.path == "app.config.key1"
-    assert path_data.metadata["description"] == "Test config"
-    assert path_data.metadata["required"] is True
-    assert path_data.metadata["sensitive"] is True
+    assert path_data.metadata.description == "Test config"
+    assert path_data.metadata.required is True
+    assert path_data.metadata.sensitive is True
     assert config.get_value("app.config.key1", "default") == "test-value"
 
 
@@ -72,9 +72,9 @@ def test_default_values():
     }
     config = HelmValuesConfig.from_dict(config_data)
     path_data = config._path_map["app.config.key1"]
-    assert path_data.metadata["description"] is None
-    assert path_data.metadata["required"] is False
-    assert path_data.metadata["sensitive"] is False
+    assert path_data.metadata.description is None
+    assert path_data.metadata.required is False
+    assert path_data.metadata.sensitive is False
 
 
 def test_type_coercion():
@@ -94,8 +94,8 @@ def test_type_coercion():
     }
     config = HelmValuesConfig.from_dict(config_data)
     path_data = config._path_map["app.config.key1"]
-    assert path_data.metadata["required"] is True
-    assert path_data.metadata["sensitive"] is False
+    assert path_data.metadata.required is True
+    assert path_data.metadata.sensitive is False
 
 
 def test_missing_required_fields():