Skip to content

Commit ebb98c9

Browse files
[FIX] isort is causing circular dependency (#139)
* Refactoring changed file names * Roll version * Update src/unstract/sdk/utils/tool_utils.py Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: Gayathri <[email protected]> * Update tests/test_fs_permanent.py Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: Gayathri <[email protected]> * Update tests/test_fs_permanent.py Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: Gayathri <[email protected]> * Update src/unstract/sdk/utils/tool_utils.py Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: Gayathri <[email protected]> * Address review comments * Add support for passing length to mime_type * Add recursive and fix mypy issue * CHange test case with new behavior to return FileNotFound in read() * Remove typing kwargs. * Resolve mypy issues * Resolve mypy issues * Remove unwanted conditionals/vars * Remove pandoc and tessaract. * Details of provider added to error message * fixed enum conditional matching value * Include EnvHelper in __init__ * Rename error handler * Upgrade version * Expose StorageType outside * Resolve circular dependency issue * Resolve circular dependency issue --------- Signed-off-by: Gayathri <[email protected]> Co-authored-by: Chandrasekharan M <[email protected]>
1 parent 6a48aed commit ebb98c9

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/unstract/sdk/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
__version__ = "0.54.0rc9"
1+
__version__ = "0.54.0rc10"
22

33

44
def get_sdk_version():

src/unstract/sdk/file_storage/__init__.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# isort:skip_file
12
__all__ = [
23
"FileStorage",
34
"FileStorageProvider",
@@ -8,10 +9,14 @@
89
"StorageType",
910
]
1011

12+
# Do not change the order of the imports below to avoid circular dependency issues
13+
1114
from unstract.sdk.file_storage.constants import StorageType
12-
from unstract.sdk.file_storage.env_helper import EnvHelper
1315
from unstract.sdk.file_storage.helper import FileStorageHelper
1416
from unstract.sdk.file_storage.impl import FileStorage
1517
from unstract.sdk.file_storage.permanent import PermanentFileStorage
1618
from unstract.sdk.file_storage.provider import FileStorageProvider
17-
from unstract.sdk.file_storage.shared_temporary import SharedTemporaryFileStorage
19+
from unstract.sdk.file_storage.shared_temporary import (
20+
SharedTemporaryFileStorage,
21+
)
22+
from unstract.sdk.file_storage.env_helper import EnvHelper

0 commit comments

Comments
 (0)