Move build cycle fix to after_prepare hook and add verbose CI output

The previous build cycle fix in after_platform_add ran too early —
before plugins like Firebase/Crashlytics added their script phases.
Move the reordering to a new after_prepare hook that runs after all
plugins have been processed, ensuring all script phases are caught.

Also add --verbose to the iOS CI build to capture full error output.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: connortechnology

.github/workflows/ci.yml

@@ -58,8 +58,9 @@ jobs:
           node-version: '22'
       - run: npm ci
       - run: npx cordova platform add ios
-      - run: >
-          npx cordova build ios --debug
+      - name: Build iOS debug
+        run: >
+          npx cordova build ios --debug --verbose
           --buildFlag="CODE_SIGNING_ALLOWED=NO"
           --buildFlag="IPHONEOS_DEPLOYMENT_TARGET=15.0"
 

hooks/after_platform_add/010_create_notification_extension.js

@@ -124,32 +124,6 @@ module.exports = function(context) {
         });
       }
 
-      // Fix build cycle: move script phases (Crashlytics, etc.) to the end
-      // of the main target's build phases so they run after "Embed App
-      // Extensions" (the copy-files phase for the appex). Without this,
-      // Xcode sees: copy appex → Crashlytics → dSYM → copy appex = cycle.
-      console.log('Reordering build phases to break dependency cycle');
-      let nativeTargets = proj.hash.project.objects['PBXNativeTarget'];
-      Object.keys(nativeTargets).forEach(key => {
-        let nt = nativeTargets[key];
-        if (!nt || !nt.buildPhases || nt.name !== `"${appName}"`) return;
-        let phases = nt.buildPhases;
-        let scriptPhaseIndices = [];
-        let scriptPhases = [];
-        phases.forEach((p, idx) => {
-          // Check if this phase ref is a shell script phase
-          if (shellScriptPhases && shellScriptPhases[p.value]) {
-            scriptPhaseIndices.push(idx);
-            scriptPhases.push(p);
-          }
-        });
-        // Remove script phases from their current position and append at end
-        for (let i = scriptPhaseIndices.length - 1; i >= 0; i--) {
-          phases.splice(scriptPhaseIndices[i], 1);
-        }
-        scriptPhases.forEach(p => phases.push(p));
-      });
-
       console.log('Write the changes to the iOS project file');
       fs.writeFileSync(projPath, proj.writeSync());
       console.log(`Added ${extName} notification extension to project`);

hooks/after_prepare/030_fix_xcode_build_cycle.js

@@ -0,0 +1,86 @@
+#!/usr/bin/env node
+
+// Fix Xcode build cycle caused by script phases (Crashlytics, etc.)
+// ordering before the "Embed App Extensions" copy-files phase.
+//
+// Runs after_prepare so all plugins have already added their build phases.
+// Moves all PBXShellScriptBuildPhase entries to the end of each native
+// target's buildPhases array, breaking the cycle:
+//   copy appex → script phase → dSYM → Info.plist → copy appex
+
+var fs = require('fs');
+var path = require('path');
+
+module.exports = function (ctx) {
+  if (ctx.opts.platforms.indexOf('ios') === -1) return;
+
+  var xcode;
+  try {
+    xcode = ctx.requireCordovaModule('xcode');
+  } catch (e) {
+    xcode = require('xcode');
+  }
+
+  var iosPath = path.join(ctx.opts.projectRoot, 'platforms', 'ios');
+  var projDir = fs.readdirSync(iosPath).find(function (f) {
+    return f.endsWith('.xcodeproj');
+  });
+  if (!projDir) {
+    console.log('030_fix_xcode_build_cycle: No .xcodeproj found, skipping');
+    return;
+  }
+
+  var projPath = path.join(iosPath, projDir, 'project.pbxproj');
+  var proj = xcode.project(projPath);
+  proj.parseSync();
+
+  var shellScriptPhases = proj.hash.project.objects['PBXShellScriptBuildPhase'] || {};
+  var nativeTargets = proj.hash.project.objects['PBXNativeTarget'] || {};
+  var changed = false;
+
+  Object.keys(nativeTargets).forEach(function (key) {
+    var nt = nativeTargets[key];
+    if (!nt || !nt.buildPhases || !Array.isArray(nt.buildPhases)) return;
+
+    var phases = nt.buildPhases;
+    var scriptIndices = [];
+    var scripts = [];
+
+    phases.forEach(function (p, idx) {
+      if (p && p.value && shellScriptPhases[p.value]) {
+        scriptIndices.push(idx);
+        scripts.push(p);
+      }
+    });
+
+    if (scripts.length === 0) return;
+
+    // Check if scripts are already at the end
+    var lastNonScript = -1;
+    phases.forEach(function (p, idx) {
+      if (!p || !p.value || !shellScriptPhases[p.value]) {
+        lastNonScript = idx;
+      }
+    });
+    if (scriptIndices.length > 0 && scriptIndices[0] > lastNonScript) return;
+
+    // Remove from current positions (reverse order to preserve indices)
+    for (var i = scriptIndices.length - 1; i >= 0; i--) {
+      phases.splice(scriptIndices[i], 1);
+    }
+    // Append at end
+    scripts.forEach(function (p) { phases.push(p); });
+    changed = true;
+
+    var name = nt.name || nt.productName || key;
+    console.log('030_fix_xcode_build_cycle: Moved ' + scripts.length +
+      ' script phase(s) to end of ' + name);
+  });
+
+  if (changed) {
+    fs.writeFileSync(projPath, proj.writeSync());
+    console.log('030_fix_xcode_build_cycle: Project file updated');
+  } else {
+    console.log('030_fix_xcode_build_cycle: No reordering needed');
+  }
+};