Remove unused DXBC::IDebugInfo::HasSourceMapping()

Zorro666 · Zorro666 · commit 061ef29a91c9 · 2025-04-02T08:37:05.000+01:00
Never called from anywhere, not implemented for DXIL
diff --git a/renderdoc/driver/shaders/dxbc/dxbc_common.h b/renderdoc/driver/shaders/dxbc/dxbc_common.h
@@ -516,7 +516,6 @@ class IDebugInfo
   virtual void GetCallstack(size_t instruction, uintptr_t offset,
                             rdcarray<rdcstr> &callstack) const = 0;
 
-  virtual bool HasSourceMapping() const = 0;
   virtual void GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,
                          rdcarray<SourceVariableMapping> &locals) const = 0;
 
diff --git a/renderdoc/driver/shaders/dxbc/dxbc_sdbg.cpp b/renderdoc/driver/shaders/dxbc/dxbc_sdbg.cpp
@@ -123,11 +123,6 @@ void SDBGChunk::GetCallstack(size_t instruction, uintptr_t offset, rdcarray<rdcs
   }
 }
 
-bool SDBGChunk::HasSourceMapping() const
-{
-  return false;
-}
-
 void SDBGChunk::GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,
                           rdcarray<SourceVariableMapping> &locals) const
 {
diff --git a/renderdoc/driver/shaders/dxbc/dxbc_sdbg.h b/renderdoc/driver/shaders/dxbc/dxbc_sdbg.h
@@ -249,7 +249,6 @@ class SDBGChunk : public IDebugInfo
   void GetLineInfo(size_t instruction, uintptr_t offset, LineColumnInfo &lineInfo) const;
   void GetCallstack(size_t instruction, uintptr_t offset, rdcarray<rdcstr> &callstack) const;
 
-  bool HasSourceMapping() const;
   void GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,
                  rdcarray<SourceVariableMapping> &locals) const;
 
diff --git a/renderdoc/driver/shaders/dxbc/dxbc_spdb.cpp b/renderdoc/driver/shaders/dxbc/dxbc_spdb.cpp
@@ -2329,11 +2329,6 @@ void SPDBChunk::GetCallstack(size_t, uintptr_t offset, rdcarray<rdcstr> &callsta
     callstack = it->second.callstack;
 }
 
-bool SPDBChunk::HasSourceMapping() const
-{
-  return true;
-}
-
 void SPDBChunk::GetLocals(const DXBC::DXBCContainer *dxbc, size_t, uintptr_t offset,
                           rdcarray<SourceVariableMapping> &locals) const
 {
diff --git a/renderdoc/driver/shaders/dxbc/dxbc_spdb.h b/renderdoc/driver/shaders/dxbc/dxbc_spdb.h
@@ -305,7 +305,6 @@ class SPDBChunk : public IDebugInfo
   void GetLineInfo(size_t instruction, uintptr_t offset, LineColumnInfo &lineInfo) const;
   void GetCallstack(size_t instruction, uintptr_t offset, rdcarray<rdcstr> &callstack) const;
 
-  bool HasSourceMapping() const;
   void GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,
                  rdcarray<SourceVariableMapping> &locals) const;
 
diff --git a/renderdoc/driver/shaders/dxil/dxil_bytecode.h b/renderdoc/driver/shaders/dxil/dxil_bytecode.h
@@ -1675,7 +1675,6 @@ class Program : public DXBC::IDebugInfo
   void GetLineInfo(size_t instruction, uintptr_t offset, LineColumnInfo &lineInfo) const override;
   void GetCallstack(size_t instruction, uintptr_t offset, rdcarray<rdcstr> &callstack) const override;
 
-  bool HasSourceMapping() const override;
   void GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,
                  rdcarray<SourceVariableMapping> &locals) const override;
   // IDebugInfo interface
diff --git a/renderdoc/driver/shaders/dxil/dxil_reflect.cpp b/renderdoc/driver/shaders/dxil/dxil_reflect.cpp
@@ -2111,12 +2111,6 @@ void Program::GetCallstack(size_t instruction, uintptr_t offset, rdcarray<rdcstr
   callstack.clear();
 }
 
-bool Program::HasSourceMapping() const
-{
-  // not yet implemented and only relevant for debugging
-  return false;
-}
-
 void Program::GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,
                         rdcarray<SourceVariableMapping> &locals) const
 {

Original file line number	Diff line number	Diff line change
`@@ -123,11 +123,6 @@ void SDBGChunk::GetCallstack(size_t instruction, uintptr_t offset, rdcarray<rdcs`
`123`	`123`	`}`
`124`	`124`	`}`
`125`	`125`
`126`		`-bool SDBGChunk::HasSourceMapping() const`
`127`		`-{`
`128`		`- return false;`
`129`		`-}`
`130`		`-`
`131`	`126`	`void SDBGChunk::GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,`
`132`	`127`	`rdcarray<SourceVariableMapping> &locals) const`
`133`	`128`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2329,11 +2329,6 @@ void SPDBChunk::GetCallstack(size_t, uintptr_t offset, rdcarray<rdcstr> &callsta`
`2329`	`2329`	`callstack = it->second.callstack;`
`2330`	`2330`	`}`
`2331`	`2331`
`2332`		`-bool SPDBChunk::HasSourceMapping() const`
`2333`		`-{`
`2334`		`- return true;`
`2335`		`-}`
`2336`		`-`
`2337`	`2332`	`void SPDBChunk::GetLocals(const DXBC::DXBCContainer *dxbc, size_t, uintptr_t offset,`
`2338`	`2333`	`rdcarray<SourceVariableMapping> &locals) const`
`2339`	`2334`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2111,12 +2111,6 @@ void Program::GetCallstack(size_t instruction, uintptr_t offset, rdcarray<rdcstr`
`2111`	`2111`	`callstack.clear();`
`2112`	`2112`	`}`
`2113`	`2113`
`2114`		`-bool Program::HasSourceMapping() const`
`2115`		`-{`
`2116`		`- // not yet implemented and only relevant for debugging`
`2117`		`- return false;`
`2118`		`-}`
`2119`		`-`
`2120`	`2114`	`void Program::GetLocals(const DXBC::DXBCContainer *dxbc, size_t instruction, uintptr_t offset,`
`2121`	`2115`	`rdcarray<SourceVariableMapping> &locals) const`
`2122`	`2116`	`{`