fix: ignore const values for now

Signed-off-by: Zxilly <zxilly@outlook.com>

Author: Zxilly

internal/dwarf/dwarf.go

@@ -96,14 +96,19 @@ func EntryShouldIgnore(entry *dwarf.Entry) bool {
 		return !ok || val
 	}
 
-	abstractOrigin := entry.Val(dwarf.AttrAbstractOrigin)
-	if abstractOrigin != nil {
-		return true
+	var ignores = []dwarf.Attr{
+		dwarf.AttrAbstractOrigin,
+		dwarf.AttrSpecification,
+		dwarf.AttrCallAllCalls,
 	}
 
-	specification := entry.Val(dwarf.AttrSpecification)
+	for _, ignore := range ignores {
+		if entry.Val(ignore) != nil {
+			return true
+		}
+	}
 
-	return specification != nil
+	return false
 }
 
 func EntryFileReader(cu *dwarf.Entry, d *dwarf.Data) func(entry *dwarf.Entry) string {
@@ -121,12 +126,12 @@ func EntryFileReader(cu *dwarf.Entry, d *dwarf.Data) func(entry *dwarf.Entry) st
 		if entry.Val(dwarf.AttrTrampoline) == nil {
 			fileIndexAny := entry.Val(dwarf.AttrDeclFile)
 			if fileIndexAny == nil {
-				slog.Warn(fmt.Sprintf("Failed to load DWARF function file: %s", EntryPrettyPrint(entry)))
+				slog.Debug(fmt.Sprintf("Failed to load DWARF function file as no field: %s", EntryPrettyPrint(entry)))
 				return defaultName
 			}
 			fileIndex, ok := fileIndexAny.(int64)
 			if !ok || fileIndex < 0 || int(fileIndex) >= len(files) {
-				slog.Warn(fmt.Sprintf("Failed to load DWARF function file: %s", EntryPrettyPrint(entry)))
+				slog.Warn(fmt.Sprintf("Failed to load DWARF function file as type unexpected %T: %s", fileIndexAny, EntryPrettyPrint(entry)))
 				return defaultName
 			}
 

internal/knowninfo/dwarf.go

@@ -20,7 +20,35 @@ import (
 func (k *KnownInfo) AddDwarfVariable(entry *dwarf.Entry, d *dwarf.Data, pkg *entity.Package, ptrSize int) {
 	instsAny := entry.Val(dwarf.AttrLocation)
 	if instsAny == nil {
-		slog.Warn(fmt.Sprintf("no location attribute for %s", dwarfutil.EntryPrettyPrint(entry)))
+		printErr := false
+		defer func() {
+			if printErr {
+				slog.Warn(fmt.Sprintf("no location attribute for %s", dwarfutil.EntryPrettyPrint(entry)))
+			}
+		}()
+
+		typOffset, ok := entry.Val(dwarf.AttrType).(dwarf.Offset)
+		if !ok {
+			slog.Warn(fmt.Sprintf("no type attribute for %s", dwarfutil.EntryPrettyPrint(entry)))
+			printErr = true
+			return
+		}
+
+		typEntry, err := d.Type(typOffset)
+		if err != nil {
+			slog.Warn(fmt.Sprintf("failed to get type for %s: %v", dwarfutil.EntryPrettyPrint(entry), err))
+			printErr = true
+			return
+		}
+
+		_, ok = typEntry.(*dwarf.QualType)
+		if ok {
+			// fixme: we ignore const values for now, support this if possible
+			return
+		}
+		printErr = true
+		slog.Warn(fmt.Sprintf("unexpected type %T for %s: ", typEntry, dwarfutil.EntryPrettyPrint(entry)))
+
 		return
 	}
 	insts, ok := instsAny.([]byte)
@@ -116,7 +144,7 @@ func (k *KnownInfo) AddDwarfSubProgram(
 	if len(ranges) == 0 {
 		// fixme: maybe compiler optimize it?
 		// example: sqlite3 simpleDestroy
-		slog.Warn(fmt.Sprintf("Failed to load DWARF function size, no range: %s", subEntryName))
+		slog.Debug(fmt.Sprintf("Failed to load DWARF function size, no range: %s", subEntryName))
 		return
 	}
 

scripts/tests.py

@@ -12,7 +12,7 @@
 from tool.merge import merge_covdata
 from tool.remote import load_remote_binaries, load_remote_for_tui_test, TestType, get_flag_str
 from tool.utils import log, get_project_root, ensure_dir, format_time, load_skip, get_covdata_integration_dir, \
-    find_unused_port, assert_html_valid, init_dirs
+    find_unused_port, assert_html_valid, init_dirs, write_github_summary
 
 
 def run_unit_tests(full: bool, wasm: bool, no_embed: bool):
@@ -204,11 +204,7 @@ def report_typ(rtyp: TestType):
         except Exception as e:
             log(f"{head} failed")
 
-            if os.getenv("CI") is not None:
-                with open(os.getenv("GITHUB_STEP_SUMMARY"), "a", encoding="utf-8") as f:
-                    f.write(f"```log\n{str(e)}\n```\n")
-            else:
-                print(e)
+            write_github_summary(f"```log\n{str(e)}\n```")
 
             scope_failed_count += 1
 

scripts/tool/utils.py

@@ -16,6 +16,15 @@
 matplotlib.use('agg')
 
 
+def write_github_summary(s: str, fallback: bool = True):
+    if os.getenv("CI") is not None:
+        with open(os.getenv("GITHUB_STEP_SUMMARY"), "a", encoding="utf-8") as f:
+            f.write(f"{s}\n")
+    else:
+        if fallback:
+            print(s)
+
+
 def get_new_temp_binary() -> str:
     suffix = ".exe" if os.name == "nt" else ""