fix: prevent historical provider queries for block tags (#642)

Historical providers should only be used for specific block numbers or hashes,
not for block tags like Latest, Safe, or Finalized. This fix ensures that
block tag queries are always handled by the current provider to get the
most up-to-date information.

Changes:
- Add should_use_historical_provider utility function to check block ID type
- Update both rpc.rs and verifiable_api.rs to use the new utility
- Ensure block tags (Latest, Safe, Finalized, etc.) bypass historical provider

Author: ncitron

Cargo.lock

@@ -260,9 +260,9 @@ impl<N: NetworkSpec, B: BlockProvider<N>, H: HistoricalBlockProvider<N>> BlockPr
             return Ok(Some(block));
         }
 
-        // 2. Try historical provider if available and not requesting latest
+        // 2. Try historical provider if available and only for block numbers or hashes (not tags)
         if let Some(historical) = &self.historical_provider {
-            if block_id != BlockNumberOrTag::Latest.into() {
+            if super::utils::should_use_historical_provider(&block_id) {
                 if let Some(block) = historical
                     .get_historical_block(block_id, full_tx, self)
                     .await?
@@ -273,7 +273,6 @@ impl<N: NetworkSpec, B: BlockProvider<N>, H: HistoricalBlockProvider<N>> BlockPr
             }
         }
 
-        // 3. No historical block found
         Ok(None)
     }
 

core/src/execution/providers/rpc.rs

@@ -1,8 +1,19 @@
-use alloy::rpc::types::{Filter, Log};
+use alloy::rpc::types::{BlockId, BlockNumberOrTag, Filter, Log};
 use eyre::Result;
 
 use crate::execution::errors::ExecutionError;
 
+/// Determines if a block ID should be fetched from the historical provider.
+/// Historical providers should only be used for specific block numbers or hashes,
+/// never for block tags like Latest, Safe, Finalized, etc.
+pub fn should_use_historical_provider(block_id: &BlockId) -> bool {
+    match block_id {
+        BlockId::Number(BlockNumberOrTag::Number(_)) => true,
+        BlockId::Hash(_) => true,
+        _ => false, // Don't use for Latest, Safe, Finalized, Pending, Earliest
+    }
+}
+
 pub fn ensure_logs_match_filter(logs: &[Log], filter: &Filter) -> Result<()> {
     fn log_matches_filter(log: &Log, filter: &Filter) -> bool {
         if let Some(block_hash) = filter.get_block_hash() {

core/src/execution/providers/utils.rs

@@ -2,7 +2,7 @@ use std::collections::{hash_map::Entry, HashMap, HashSet};
 
 use alloy::{
     consensus::BlockHeader,
-    eips::{BlockId, BlockNumberOrTag},
+    eips::BlockId,
     network::{primitives::HeaderResponse, BlockResponse, ReceiptResponse, TransactionResponse},
     primitives::{Address, B256, U256},
     rlp,
@@ -150,9 +150,9 @@ impl<N: NetworkSpec, B: BlockProvider<N>, H: HistoricalBlockProvider<N>> BlockPr
             return Ok(Some(block));
         }
 
-        // 2. Try historical provider if available and not requesting latest
+        // 2. Try historical provider if available and only for block numbers or hashes (not tags)
         if let Some(historical) = &self.historical_provider {
-            if block_id != BlockNumberOrTag::Latest.into() {
+            if super::utils::should_use_historical_provider(&block_id) {
                 if let Some(block) = historical
                     .get_historical_block(block_id, full_tx, self)
                     .await?