-
Notifications
You must be signed in to change notification settings - Fork 55
Expand file tree
/
Copy pathA2AJsonRpcProcessorTests.cs
More file actions
503 lines (409 loc) · 20 KB
/
A2AJsonRpcProcessorTests.cs
File metadata and controls
503 lines (409 loc) · 20 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
using Microsoft.AspNetCore.Http;
using System.Text.Json;
using System.Text;
namespace A2A.AspNetCore.Tests;
public class A2AJsonRpcProcessorTests
{
[Theory]
[InlineData("\"test-id\"", true)] // String ID - valid
[InlineData(42, true)] // Number ID - valid: Uncomment when numeric IDs are supported
[InlineData(42.1, false)] // Fractional number ID - invalid (should throw error)
[InlineData("null", true)] // Null ID - valid
[InlineData("true", false)] // Boolean ID - invalid (should throw error)
public async Task ValidateIdField_HandlesVariousIdTypes(object? idValue, bool isValid)
{
// Arrange
var taskManager = new TaskManager();
var jsonRequest = $$"""
{
"jsonrpc": "2.0",
"method": "{{A2AMethods.MessageSend}}",
"id": {{idValue}},
"params": {
"message": {
"messageId": "test-message-id",
"role": "user",
"parts": [{ "kind":"text","text":"hi" }]
}
}
}
""";
var httpRequest = CreateHttpRequestFromJson(jsonRequest);
// Act
var result = await A2AJsonRpcProcessor.ProcessRequestAsync(taskManager, httpRequest, CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
if (isValid)
{
Assert.NotNull(BodyContent.Result);
}
else
{
Assert.NotNull(BodyContent.Error);
Assert.Equal(-32600, BodyContent.Error.Code); // Invalid request
Assert.NotNull(BodyContent.Error.Message);
}
}
[Fact]
public async Task EmptyPartsArrayIsNotAllowed()
{
// Arrange
var taskManager = new TaskManager();
var jsonRequest = $$"""
{
"jsonrpc": "2.0",
"method": "{{A2AMethods.MessageSend}}",
"id": "some",
"params": {
"message": {
"messageId": "test-message-id",
"role": "user",
"parts": []
}
}
}
""";
var httpRequest = CreateHttpRequestFromJson(jsonRequest);
var result = await A2AJsonRpcProcessor.ProcessRequestAsync(taskManager, httpRequest, CancellationToken.None);
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent.Error);
Assert.Equal(-32602, BodyContent.Error.Code); // Invalid params
Assert.NotNull(BodyContent.Error.Message);
}
[Theory]
[InlineData("\"method\": \"message/send\",", null)] // Valid method - should succeed
[InlineData("\"method\": \"invalid/method\",", -32601)] // Invalid method - should return method not found error
[InlineData("\"method\": \"\",", -32600)] // Empty method - should return invalid request error
[InlineData("", -32600)] // Missing method field - should return invalid request error
public async Task ValidateMethodField_HandlesVariousMethodTypes(string methodPropertySnippet, int? expectedErrorCode)
{
// Arrange
var taskManager = new TaskManager();
// Build JSON with conditional method property inclusion
var hasMethodProperty = !string.IsNullOrEmpty(methodPropertySnippet);
var jsonRequest = $$"""
{
"jsonrpc": "2.0",
{{methodPropertySnippet}}
"id": "test-id",
"params": {
"message": {
"messageId": "test-message-id",
"role": "user",
"parts": [{ "kind":"text","text":"hi" }]
}
}
}
""";
var httpRequest = CreateHttpRequestFromJson(jsonRequest);
// Act
var result = await A2AJsonRpcProcessor.ProcessRequestAsync(taskManager, httpRequest, CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
if (expectedErrorCode is null)
{
Assert.NotNull(BodyContent.Result);
}
else
{
// For invalid methods, we expect an error
Assert.NotNull(BodyContent.Error);
Assert.Equal(expectedErrorCode, BodyContent.Error.Code);
Assert.NotNull(BodyContent.Error.Message);
}
}
[Theory]
[InlineData("{\"message\":{\"messageId\":\"test\", \"role\": \"user\", \"parts\": [{\"kind\":\"text\",\"text\":\"hi\"}]}}", null)] // Valid object params - should succeed
[InlineData("[]", -32602)] // Array params - should return invalid params error
[InlineData("\"string-params\"", -32602)] // String params - should return invalid params error
[InlineData("42", -32602)] // Number params - should return invalid params error
[InlineData("true", -32602)] // Boolean params - should return invalid params error
[InlineData("null", -32602)] // Null params - should return invalid params error
public async Task ValidateParamsField_HandlesVariousParamsTypes(string paramsValue, int? expectedErrorCode)
{
// Arrange
var taskManager = new TaskManager();
var jsonRequest = $$"""
{
"jsonrpc": "2.0",
"method": "{{A2AMethods.MessageSend}}",
"id": "test-id",
"params": {{paramsValue}}
}
""";
var httpRequest = CreateHttpRequestFromJson(jsonRequest);
// Act
var result = await A2AJsonRpcProcessor.ProcessRequestAsync(taskManager, httpRequest, CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
if (expectedErrorCode is null)
{
Assert.NotNull(BodyContent.Result);
Assert.Null(BodyContent.Error);
}
else
{
// Invalid params cases - should return error
Assert.Null(BodyContent.Result);
Assert.NotNull(BodyContent.Error);
Assert.Equal(expectedErrorCode, BodyContent.Error.Code);
Assert.NotEmpty(BodyContent.Error.Message);
}
}
[Fact]
public async Task ProcessRequest_SingleResponse_MessageSend_Works()
{
TaskManager taskManager = new();
MessageSendParams sendParams = new()
{
Message = new Message { MessageId = "test-message-id", Parts = [new TextPart { Text = "hi" }] }
};
JsonRpcRequest req = new()
{
Id = "1",
Method = A2AMethods.MessageSend,
Params = ToJsonElement(sendParams)
};
var httpRequest = CreateHttpRequest(req);
// Act
var result = await A2AJsonRpcProcessor.ProcessRequestAsync(taskManager, httpRequest, CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent.Result);
var agentTask = JsonSerializer.Deserialize<AgentTask>(BodyContent.Result, A2AJsonUtilities.DefaultOptions);
Assert.NotNull(agentTask);
Assert.Equal(TaskState.Submitted, agentTask.Status.State);
Assert.NotEmpty(agentTask.History);
Assert.Equal(MessageRole.User, agentTask.History[0].Role);
Assert.Equal("hi", ((TextPart)agentTask.History[0].Parts[0]).Text);
Assert.Equal("test-message-id", agentTask.History[0].MessageId);
}
[Fact]
public async Task ProcessRequest_SingleResponse_InvalidParams_ReturnsError()
{
// Arrange
var taskManager = new TaskManager();
var req = new JsonRpcRequest
{
Id = "2",
Method = A2AMethods.MessageSend,
Params = null
};
var httpRequest = CreateHttpRequest(req);
// Act
var result = await A2AJsonRpcProcessor.ProcessRequestAsync(taskManager, httpRequest, CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode); // JSON-RPC errors return 200 with error in body
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent);
Assert.Null(BodyContent.Result);
Assert.NotNull(BodyContent.Error);
Assert.Equal(-32602, BodyContent.Error!.Code); // Invalid params
Assert.Equal("Invalid parameters", BodyContent.Error.Message);
}
[Fact]
public async Task SingleResponse_TaskGet_Works()
{
// Arrange
var taskManager = new TaskManager();
var task = await taskManager.CreateTaskAsync();
var queryParams = new TaskQueryParams { Id = task.Id };
// Act
var result = await A2AJsonRpcProcessor.SingleResponseAsync(taskManager, "4", A2AMethods.TaskGet, ToJsonElement(queryParams), CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent);
var agentTask = JsonSerializer.Deserialize<AgentTask>(BodyContent.Result, A2AJsonUtilities.DefaultOptions);
Assert.NotNull(agentTask);
Assert.Equal(TaskState.Submitted, agentTask.Status.State);
Assert.Empty(agentTask.History);
}
[Fact]
public async Task NegativeHistoryLengthThrows()
{
TaskManager taskManager = new();
TaskQueryParams queryParams = new() { Id = "doesNotMatter", HistoryLength = -1 };
A2AException result = await Assert.ThrowsAsync<A2AException>(
() => A2AJsonRpcProcessor.SingleResponseAsync(taskManager, "4", A2AMethods.TaskGet, ToJsonElement(queryParams), CancellationToken.None));
Assert.Equal(A2AErrorCode.InvalidParams, result.ErrorCode);
Assert.Equal("History length cannot be negative", result.Message);
}
[Fact]
public async Task SingleResponse_TaskCancel_Works()
{
// Arrange
var taskManager = new TaskManager();
var newTask = await taskManager.CreateTaskAsync();
var cancelParams = new TaskIdParams { Id = newTask.Id };
// Act
var result = await A2AJsonRpcProcessor.SingleResponseAsync(taskManager, "5", A2AMethods.TaskCancel, ToJsonElement(cancelParams), CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent);
var agentTask = JsonSerializer.Deserialize<AgentTask>(BodyContent.Result, A2AJsonUtilities.DefaultOptions);
Assert.NotNull(agentTask);
Assert.Equal(TaskState.Canceled, agentTask.Status.State);
Assert.Empty(agentTask.History);
}
[Fact]
public async Task SingleResponse_TaskPushNotificationConfigSet_Works()
{
// Arrange
var taskManager = new TaskManager();
var config = new TaskPushNotificationConfig
{
TaskId = "test-task",
PushNotificationConfig = new PushNotificationConfig()
{
Url = "https://example.com/notify",
}
};
// Act
var result = await A2AJsonRpcProcessor.SingleResponseAsync(taskManager, "6", A2AMethods.TaskPushNotificationConfigSet, ToJsonElement(config), CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent);
var notificationConfig = JsonSerializer.Deserialize<TaskPushNotificationConfig>(BodyContent.Result, A2AJsonUtilities.DefaultOptions);
Assert.NotNull(notificationConfig);
Assert.Equal("test-task", notificationConfig.TaskId);
Assert.Equal("https://example.com/notify", notificationConfig.PushNotificationConfig.Url);
}
[Fact]
public async Task SingleResponse_TaskPushNotificationConfigGet_Works()
{
// Arrange
var taskManager = new TaskManager();
var task = await taskManager.CreateTaskAsync();
var config = new TaskPushNotificationConfig
{
TaskId = task.Id,
PushNotificationConfig = new PushNotificationConfig()
{
Url = "https://example.com/notify",
}
};
await taskManager.SetPushNotificationAsync(config);
var getParams = new GetTaskPushNotificationConfigParams { Id = task.Id };
// Act
var result = await A2AJsonRpcProcessor.SingleResponseAsync(taskManager, "7", A2AMethods.TaskPushNotificationConfigGet, ToJsonElement(getParams), CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent);
var notificationConfig = JsonSerializer.Deserialize<TaskPushNotificationConfig>(BodyContent.Result, A2AJsonUtilities.DefaultOptions);
Assert.NotNull(notificationConfig);
Assert.Equal(task.Id, notificationConfig.TaskId);
Assert.Equal("https://example.com/notify", notificationConfig.PushNotificationConfig.Url);
}
[Fact]
public async Task SingleResponse_TaskPushNotificationConfigGet_WithConfigId_Works()
{
// Arrange
var taskManager = new TaskManager();
var task = await taskManager.CreateTaskAsync();
var config = new TaskPushNotificationConfig
{
TaskId = task.Id,
PushNotificationConfig = new PushNotificationConfig()
{
Url = "https://example.com/notify2",
Id = "specific-config-id"
}
};
await taskManager.SetPushNotificationAsync(config);
var getParams = new GetTaskPushNotificationConfigParams
{
Id = task.Id,
PushNotificationConfigId = "specific-config-id"
};
// Act
var result = await A2AJsonRpcProcessor.SingleResponseAsync(taskManager, "8", A2AMethods.TaskPushNotificationConfigGet, ToJsonElement(getParams), CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent);
var notificationConfig = JsonSerializer.Deserialize<TaskPushNotificationConfig>(BodyContent.Result, A2AJsonUtilities.DefaultOptions);
Assert.NotNull(notificationConfig);
Assert.Equal(task.Id, notificationConfig.TaskId);
Assert.Equal("https://example.com/notify2", notificationConfig.PushNotificationConfig.Url);
Assert.Equal("specific-config-id", notificationConfig.PushNotificationConfig.Id);
}
[Fact]
public async Task StreamResponse_MessageStream_InvalidParams_ReturnsError()
{
// Arrange
var taskManager = new TaskManager();
// Act
var result = A2AJsonRpcProcessor.StreamResponse(taskManager, "10", A2AMethods.MessageStream, null, CancellationToken.None);
// Assert
var responseResult = Assert.IsType<JsonRpcResponseResult>(result);
var (StatusCode, ContentType, BodyContent) = await GetJsonRpcResponseHttpDetails<JsonRpcResponse>(responseResult);
Assert.Equal(StatusCodes.Status200OK, StatusCode);
Assert.Equal("application/json", ContentType);
Assert.NotNull(BodyContent);
Assert.Null(BodyContent.Result);
Assert.NotNull(BodyContent.Error);
Assert.Equal(-32602, BodyContent.Error!.Code); // Invalid params
Assert.Equal("Invalid parameters", BodyContent.Error.Message);
}
private static JsonElement ToJsonElement<T>(T obj)
{
var json = JsonSerializer.Serialize(obj, A2AJsonUtilities.DefaultOptions);
using var doc = JsonDocument.Parse(json);
return doc.RootElement.Clone();
}
private static HttpRequest CreateHttpRequest(object request)
{
var context = new DefaultHttpContext();
var json = JsonSerializer.Serialize(request, A2AJsonUtilities.DefaultOptions);
return CreateHttpRequestFromJson(json);
}
private static HttpRequest CreateHttpRequestFromJson(string json)
{
var context = new DefaultHttpContext();
var bytes = Encoding.UTF8.GetBytes(json);
context.Request.Body = new MemoryStream(bytes);
context.Request.ContentType = "application/json";
return context.Request;
}
private static async Task<(int StatusCode, string? ContentType, TBody BodyContent)> GetJsonRpcResponseHttpDetails<TBody>(JsonRpcResponseResult responseResult)
{
HttpContext context = new DefaultHttpContext();
using var memoryStream = new MemoryStream();
context.Response.Body = memoryStream;
await responseResult.ExecuteAsync(context);
context.Response.Body.Position = 0;
var bodyContent = await JsonSerializer.DeserializeAsync<TBody>(context.Response.Body, A2AJsonUtilities.DefaultOptions);
return (context.Response.StatusCode, context.Response.ContentType, bodyContent!);
}
}