Skip to content

Commit 3a090d2

Browse files
authored
Fix up dependencies / project files (#5)
- Add a nuget.config to address build warnings and to ensure known feeds are being used - Remove dependencies not necessary for net8+ builds - Restructure package list to clarify which dependencies are used for what purpose
1 parent dce4a09 commit 3a090d2

File tree

4 files changed

+51
-35
lines changed

4 files changed

+51
-35
lines changed

Directory.Packages.props

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,30 @@
44
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
55
</PropertyGroup>
66
<ItemGroup>
7-
<!-- Microsoft Extensions -->
8-
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.5" />
9-
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.5" />
10-
<!-- Microsoft Semantic Kernel -->
11-
<PackageVersion Include="Microsoft.SemanticKernel.Agents.Core" Version="1.53.1" />
12-
<PackageVersion Include="Microsoft.SemanticKernel.Agents.OpenAI" Version="1.53.1-preview" />
13-
<!-- OpenTelemetry -->
14-
<PackageVersion Include="OpenTelemetry" Version="1.12.0" />
157

8+
<!-- Product dependencies netstandard -->
9+
<PackageVersion Include="System.Text.Json" Version="8.0.5" />
10+
11+
<!-- Product dependencies shared -->
12+
<PackageVersion Include="System.Net.ServerSentEvents" Version="9.0.6" />
13+
14+
<!-- Testing / samples dependencies -->
15+
<PackageVersion Include="JsonSchema.Net" Version="7.3.4" />
16+
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.6" />
17+
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.6" />
18+
<PackageVersion Include="Microsoft.SemanticKernel.Agents.Core" Version="1.59.0" />
19+
<PackageVersion Include="Microsoft.SemanticKernel.Agents.OpenAI" Version="1.59.0-preview" />
20+
<PackageVersion Include="OpenTelemetry" Version="1.12.0" />
1621
<PackageVersion Include="OpenTelemetry.Exporter.Console" Version="1.12.0" />
1722
<PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.12.0" />
1823
<PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="1.12.0" />
1924
<PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.12.0" />
2025
<PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.12.0" />
2126
<PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.12.0" />
22-
<!-- System Packages -->
23-
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
24-
<PackageVersion Include="System.Net.ServerSentEvents" Version="9.0.5" />
25-
<PackageVersion Include="System.Text.Json" Version="8.0.5" />
26-
<!-- JSON Schema -->
27-
<PackageVersion Include="JsonSchema.Net" Version="7.3.4" />
28-
<!-- Resilience & Utilities -->
2927
<PackageVersion Include="Polly" Version="8.4.2" />
30-
<!-- Test Packages -->
28+
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
29+
30+
<!-- Build / infrastructure dependencies -->
3131
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
3232
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
3333
<PackageVersion Include="xunit" Version="2.9.3" />

nuget.config

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<configuration>
3+
4+
<packageSources>
5+
<clear />
6+
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
7+
</packageSources>
8+
9+
<packageSourceMapping>
10+
<packageSource key="nuget">
11+
<package pattern="*" />
12+
</packageSource>
13+
</packageSourceMapping>
14+
15+
</configuration>

src/A2A.AspNetCore/A2A.AspNetCore.csproj

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,12 @@
1313
<IsPackable>true</IsPackable>
1414
</PropertyGroup>
1515

16-
<ItemGroup>
17-
<ProjectReference Include="..\A2A.Core\A2A.Core.csproj" />
18-
</ItemGroup>
16+
<ItemGroup>
17+
<FrameworkReference Include="Microsoft.AspNetCore.App" />
18+
</ItemGroup>
1919

2020
<ItemGroup>
21-
<FrameworkReference Include="Microsoft.AspNetCore.App" />
22-
</ItemGroup>
23-
24-
<ItemGroup>
25-
<PackageReference Include="System.Text.Json" />
21+
<ProjectReference Include="..\A2A.Core\A2A.Core.csproj" />
2622
</ItemGroup>
2723

2824
<ItemGroup>

src/A2A.Core/A2A.Core.csproj

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,23 @@
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
77

8-
<!-- NuGet Package Properties -->
9-
<PackageId>A2A.Core</PackageId>
10-
<Description>Core .NET SDK for the Agent2Agent(A2A) protocol.</Description>
11-
<PackageReadmeFile>README.md</PackageReadmeFile>
12-
<IsPackable>true</IsPackable>
13-
</PropertyGroup>
8+
<!-- NuGet Package Properties -->
9+
<PackageId>A2A.Core</PackageId>
10+
<Description>Core .NET SDK for the Agent2Agent(A2A) protocol.</Description>
11+
<PackageReadmeFile>README.md</PackageReadmeFile>
12+
<IsPackable>true</IsPackable>
13+
</PropertyGroup>
14+
15+
<!-- Dependencies only needed by netstandard2.0 -->
16+
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
17+
<PackageReference Include="System.Text.Json" />
18+
</ItemGroup>
1419

15-
<ItemGroup>
16-
<PackageReference Include="Microsoft.Extensions.Logging" />
17-
<PackageReference Include="System.Net.ServerSentEvents" />
18-
<PackageReference Include="System.Text.Json" />
19-
</ItemGroup>
20+
<!-- Dependencies needed by all -->
21+
<ItemGroup>
22+
<PackageReference Include="Microsoft.Extensions.Logging" />
23+
<PackageReference Include="System.Net.ServerSentEvents" />
24+
</ItemGroup>
2025

2126
<ItemGroup>
2227
<None Include="..\..\README.md" Pack="true" PackagePath="\" />

0 commit comments

Comments
 (0)