fix: Constants to the confg properties

This came up in a Gemini review on the backport to 0.3.x

Author: kabir

extras/task-store-database-jpa/src/main/java/io/a2a/extras/taskstore/database/jpa/JpaDatabaseTaskStore.java

@@ -37,6 +37,7 @@
 public class JpaDatabaseTaskStore implements TaskStore, TaskStateProvider {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(JpaDatabaseTaskStore.class);
+    private static final String A2A_REPLICATION_GRACE_PERIOD_SECONDS = "a2a.replication.grace-period-seconds";
 
     @PersistenceContext(unitName = "a2a-java")
     EntityManager em;
@@ -60,7 +61,7 @@ public class JpaDatabaseTaskStore implements TaskStore, TaskStateProvider {
 
     @PostConstruct
     void initConfig() {
-        gracePeriodSeconds = Long.parseLong(configProvider.getValue("a2a.replication.grace-period-seconds"));
+        gracePeriodSeconds = Long.parseLong(configProvider.getValue(A2A_REPLICATION_GRACE_PERIOD_SECONDS));
     }
 
     @Transactional

integrations/microprofile-config/src/test/java/io/a2a/integrations/microprofile/MicroProfileConfigProviderTest.java

@@ -1,6 +1,7 @@
 package io.a2a.integrations.microprofile;
 
 import io.a2a.server.config.A2AConfigProvider;
+import io.a2a.server.util.async.AsyncExecutorProducer;
 import io.quarkus.test.junit.QuarkusTest;
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Test;
@@ -16,6 +17,10 @@
 @QuarkusTest
 public class MicroProfileConfigProviderTest {
 
+    private static final String A2A_EXECUTOR_CORE_POOL_SIZE = "a2a.executor.core-pool-size";
+    private static final String A2A_EXECUTOR_MAX_POOL_SIZE = "a2a.executor.max-pool-size";
+    private static final String A2A_EXECUTOR_KEEP_ALIVE_SECONDS = "a2a.executor.keep-alive-seconds";
+
     @Inject
     A2AConfigProvider configProvider;
 
@@ -31,37 +36,37 @@ public void testIsMicroProfileConfigProvider() {
     public void testGetValueFromMicroProfileConfig() {
         // Test that values from application.properties override defaults
         // The test application.properties sets a2a.executor.core-pool-size=15
-        String value = configProvider.getValue("a2a.executor.core-pool-size");
+        String value = configProvider.getValue(A2A_EXECUTOR_CORE_POOL_SIZE);
         assertEquals("15", value, "Should get value from MicroProfile Config (application.properties)");
     }
 
     @Test
     public void testGetValueFallbackToDefaults() {
         // Test that values not in application.properties fall back to META-INF/a2a-defaults.properties
         // a2a.executor.max-pool-size is not in test application.properties, so should use default
-        String value = configProvider.getValue("a2a.executor.max-pool-size");
+        String value = configProvider.getValue(A2A_EXECUTOR_MAX_POOL_SIZE);
         assertEquals("50", value, "Should fall back to default value from META-INF/a2a-defaults.properties");
     }
 
     @Test
     public void testGetValueAnotherDefault() {
         // Test another default property to ensure fallback works
-        String value = configProvider.getValue("a2a.executor.keep-alive-seconds");
+        String value = configProvider.getValue(A2A_EXECUTOR_KEEP_ALIVE_SECONDS);
         assertEquals("60", value, "Should fall back to default value");
     }
 
     @Test
     public void testGetOptionalValueFromMicroProfileConfig() {
         // Test optional value that exists in application.properties
-        Optional<String> value = configProvider.getOptionalValue("a2a.executor.core-pool-size");
+        Optional<String> value = configProvider.getOptionalValue(A2A_EXECUTOR_CORE_POOL_SIZE);
         assertTrue(value.isPresent(), "Optional value should be present");
         assertEquals("15", value.get(), "Should get overridden value from MicroProfile Config");
     }
 
     @Test
     public void testGetOptionalValueFallbackToDefaults() {
         // Test optional value that falls back to defaults
-        Optional<String> value = configProvider.getOptionalValue("a2a.executor.max-pool-size");
+        Optional<String> value = configProvider.getOptionalValue(A2A_EXECUTOR_MAX_POOL_SIZE);
         assertTrue(value.isPresent(), "Optional value should be present from defaults");
         assertEquals("50", value.get(), "Should get default value");
     }

server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java

@@ -73,6 +73,9 @@ public class DefaultRequestHandler implements RequestHandler {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(DefaultRequestHandler.class);
 
+    private static final String A2A_BLOCKING_AGENT_TIMEOUT_SECONDS = "a2a.blocking.agent.timeout.seconds";
+    private static final String A2A_BLOCKING_CONSUMPTION_TIMEOUT_SECONDS = "a2a.blocking.consumption.timeout.seconds";
+
     @Inject
     A2AConfigProvider configProvider;
 
@@ -130,9 +133,9 @@ public DefaultRequestHandler(AgentExecutor agentExecutor, TaskStore taskStore,
     @PostConstruct
     void initConfig() {
         agentCompletionTimeoutSeconds = Integer.parseInt(
-                configProvider.getValue("a2a.blocking.agent.timeout.seconds"));
+                configProvider.getValue(A2A_BLOCKING_AGENT_TIMEOUT_SECONDS));
         consumptionCompletionTimeoutSeconds = Integer.parseInt(
-                configProvider.getValue("a2a.blocking.consumption.timeout.seconds"));
+                configProvider.getValue(A2A_BLOCKING_CONSUMPTION_TIMEOUT_SECONDS));
     }
 
     /**

server-common/src/main/java/io/a2a/server/util/async/AsyncExecutorProducer.java

@@ -22,6 +22,9 @@
 public class AsyncExecutorProducer {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(AsyncExecutorProducer.class);
+    private static final String A2A_EXECUTOR_CORE_POOL_SIZE = "a2a.executor.core-pool-size";
+    private static final String A2A_EXECUTOR_MAX_POOL_SIZE = "a2a.executor.max-pool-size";
+    private static final String A2A_EXECUTOR_KEEP_ALIVE_SECONDS = "a2a.executor.keep-alive-seconds";
 
     @Inject
     A2AConfigProvider configProvider;
@@ -57,9 +60,9 @@ public class AsyncExecutorProducer {
 
     @PostConstruct
     public void init() {
-        corePoolSize = Integer.parseInt(configProvider.getValue("a2a.executor.core-pool-size"));
-        maxPoolSize = Integer.parseInt(configProvider.getValue("a2a.executor.max-pool-size"));
-        keepAliveSeconds = Long.parseLong(configProvider.getValue("a2a.executor.keep-alive-seconds"));
+        corePoolSize = Integer.parseInt(configProvider.getValue(A2A_EXECUTOR_CORE_POOL_SIZE));
+        maxPoolSize = Integer.parseInt(configProvider.getValue(A2A_EXECUTOR_MAX_POOL_SIZE));
+        keepAliveSeconds = Long.parseLong(configProvider.getValue(A2A_EXECUTOR_KEEP_ALIVE_SECONDS));
 
         LOGGER.info("Initializing async executor: corePoolSize={}, maxPoolSize={}, keepAliveSeconds={}",
                 corePoolSize, maxPoolSize, keepAliveSeconds);