Skip to content

Commit 23d9f69

Browse files
committed
Apply reviews
1 parent fd0f6fc commit 23d9f69

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

server-common/src/main/java/io/a2a/server/tasks/TaskManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public Event process(Event event) throws A2AServerException {
104104
}
105105

106106
public Task updateWithMessage(Message message, Task task) {
107-
List<Message> history = task.getHistory() == null ? new ArrayList<>() : new ArrayList<>(task.getHistory());
107+
List<Message> history = new ArrayList<>(task.getHistory());
108108

109109
TaskStatus status = task.getStatus();
110110
if (status.message() != null) {

server-common/src/test/java/io/a2a/server/tasks/TaskManagerTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -724,9 +724,7 @@ public void testUpdateWithMessage() throws A2AServerException {
724724
.messageId("update-msg-id")
725725
.build();
726726

727-
TaskManager taskManagerWithUpdateMessage = new TaskManager(saved.getId(), saved.getContextId(), taskStore, updateMessage);
728-
Task retrieved = taskManagerWithUpdateMessage.getTask();
729-
Task updated = taskManagerWithUpdateMessage.updateWithMessage(updateMessage, retrieved);
727+
Task updated = taskManagerWithInitialMessage.updateWithMessage(updateMessage, saved);
730728

731729
// There should now be a history containing the initialMessage, task message and update message
732730
assertNotNull(updated.getHistory());

0 commit comments

Comments
 (0)