Skip to content

Commit 33a4bb0

Browse files
kabirkabir
committed
Change thread pool
1 parent 32eed94 commit 33a4bb0

File tree

7 files changed

+393
-3
lines changed

7 files changed

+393
-3
lines changed

‎.github/workflows/run-tck-grpc-only.yml‎

Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
name: Run TCK gRPC Only
2+
3+
on:
4+
# Handle all branches for now
5+
push:
6+
branches:
7+
- main
8+
pull_request:
9+
branches:
10+
- main
11+
workflow_dispatch:
12+
13+
env:
14+
# Tag of the TCK
15+
TCK_VERSION: 0.3.0.beta2
16+
# Tells uv to not need a venv, and instead use system
17+
UV_SYSTEM_PYTHON: 1
18+
# SUT_JSONRPC_URL to use for the TCK and the server agent
19+
SUT_JSONRPC_URL: http://localhost:9999
20+
# Slow system on CI
21+
TCK_STREAMING_TIMEOUT: 5.0
22+
23+
# Only run the latest job
24+
concurrency:
25+
group: '${{ github.workflow }} @ ${{ github.head_ref || github.ref }}'
26+
cancel-in-progress: true
27+
28+
jobs:
29+
tck-test:
30+
runs-on: ubuntu-latest
31+
strategy:
32+
matrix:
33+
java-version: [17, 21, 25]
34+
steps:
35+
- name: Checkout a2a-java
36+
uses: actions/checkout@v4
37+
- name: Checkout a2a-tck
38+
uses: actions/checkout@v4
39+
with:
40+
repository: a2aproject/a2a-tck
41+
path: tck/a2a-tck
42+
ref: ${{ env.TCK_VERSION }}
43+
- name: Set up JDK ${{ matrix.java-version }}
44+
uses: actions/setup-java@v5
45+
with:
46+
java-version: ${{ matrix.java-version }}
47+
distribution: 'temurin'
48+
cache: maven
49+
- name: check java_home
50+
run: echo $JAVA_HOME
51+
- name: Set up Python
52+
uses: actions/setup-python@v5
53+
with:
54+
python-version-file: "tck/a2a-tck/pyproject.toml"
55+
- name: Install uv and Python dependencies
56+
run: |
57+
pip install uv
58+
uv pip install -e .
59+
working-directory: tck/a2a-tck
60+
- name: Build with Maven, skipping tests
61+
run: mvn -B install -DskipTests
62+
- name: Start SUT
63+
run: SUT_GRPC_URL=${{ env.SUT_JSONRPC_URL }} SUT_REST_URL=${{ env.SUT_JSONRPC_URL }} mvn -B quarkus:dev & #SUT_JSONRPC_URL already set
64+
working-directory: tck
65+
- name: Wait for SUT to start
66+
run: |
67+
URL="${{ env.SUT_JSONRPC_URL }}/.well-known/agent-card.json"
68+
EXPECTED_STATUS=200
69+
TIMEOUT=120
70+
RETRY_INTERVAL=2
71+
START_TIME=$(date +%s)
72+
73+
while true; do
74+
# Calculate elapsed time
75+
CURRENT_TIME=$(date +%s)
76+
ELAPSED_TIME=$((CURRENT_TIME - START_TIME))
77+
78+
# Check for timeout
79+
if [ "$ELAPSED_TIME" -ge "$TIMEOUT" ]; then
80+
echo "❌ Timeout: Server did not respond with status $EXPECTED_STATUS within $TIMEOUT seconds."
81+
exit 1
82+
fi
83+
84+
# Get HTTP status code. || true is to reporting a failure to connect as an error
85+
HTTP_STATUS=$(curl --output /dev/null --silent --write-out "%{http_code}" "$URL") || true
86+
echo "STATUS: ${HTTP_STATUS}"
87+
88+
# Check if we got the correct status code
89+
if [ "$HTTP_STATUS" -eq "$EXPECTED_STATUS" ]; then
90+
echo "✅ Server is up! Received status $HTTP_STATUS after $ELAPSED_TIME seconds."
91+
break;
92+
fi
93+
94+
# Wait before retrying
95+
echo "⏳ Server not ready (status: $HTTP_STATUS). Retrying in $RETRY_INTERVAL seconds..."
96+
sleep "$RETRY_INTERVAL"
97+
done
98+
99+
- name: Run TCK
100+
timeout-minutes: 10
101+
run: |
102+
./run_tck.py --sut-url ${{ env.SUT_JSONRPC_URL }} --category all --transports grpc --compliance-report report.json
103+
working-directory: tck/a2a-tck
104+
- name: Upload TCK Log
105+
if: always()
106+
uses: actions/upload-artifact@v4
107+
with:
108+
name: tck-test-log-java-${{ matrix.java-version }}
109+
path: tck/target/tck-test.log
110+
retention-days: 7

‎.github/workflows/run-tck-jsonrpc-only.yml‎

Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
name: Run TCK JSONRPC Only
2+
3+
on:
4+
# Handle all branches for now
5+
push:
6+
branches:
7+
- main
8+
pull_request:
9+
branches:
10+
- main
11+
workflow_dispatch:
12+
13+
env:
14+
# Tag of the TCK
15+
TCK_VERSION: 0.3.0.beta2
16+
# Tells uv to not need a venv, and instead use system
17+
UV_SYSTEM_PYTHON: 1
18+
# SUT_JSONRPC_URL to use for the TCK and the server agent
19+
SUT_JSONRPC_URL: http://localhost:9999
20+
# Slow system on CI
21+
TCK_STREAMING_TIMEOUT: 5.0
22+
23+
# Only run the latest job
24+
concurrency:
25+
group: '${{ github.workflow }} @ ${{ github.head_ref || github.ref }}'
26+
cancel-in-progress: true
27+
28+
jobs:
29+
tck-test:
30+
runs-on: ubuntu-latest
31+
strategy:
32+
matrix:
33+
java-version: [17, 21, 25]
34+
steps:
35+
- name: Checkout a2a-java
36+
uses: actions/checkout@v4
37+
- name: Checkout a2a-tck
38+
uses: actions/checkout@v4
39+
with:
40+
repository: a2aproject/a2a-tck
41+
path: tck/a2a-tck
42+
ref: ${{ env.TCK_VERSION }}
43+
- name: Set up JDK ${{ matrix.java-version }}
44+
uses: actions/setup-java@v5
45+
with:
46+
java-version: ${{ matrix.java-version }}
47+
distribution: 'temurin'
48+
cache: maven
49+
- name: check java_home
50+
run: echo $JAVA_HOME
51+
- name: Set up Python
52+
uses: actions/setup-python@v5
53+
with:
54+
python-version-file: "tck/a2a-tck/pyproject.toml"
55+
- name: Install uv and Python dependencies
56+
run: |
57+
pip install uv
58+
uv pip install -e .
59+
working-directory: tck/a2a-tck
60+
- name: Build with Maven, skipping tests
61+
run: mvn -B install -DskipTests
62+
- name: Start SUT
63+
run: SUT_GRPC_URL=${{ env.SUT_JSONRPC_URL }} SUT_REST_URL=${{ env.SUT_JSONRPC_URL }} mvn -B quarkus:dev & #SUT_JSONRPC_URL already set
64+
working-directory: tck
65+
- name: Wait for SUT to start
66+
run: |
67+
URL="${{ env.SUT_JSONRPC_URL }}/.well-known/agent-card.json"
68+
EXPECTED_STATUS=200
69+
TIMEOUT=120
70+
RETRY_INTERVAL=2
71+
START_TIME=$(date +%s)
72+
73+
while true; do
74+
# Calculate elapsed time
75+
CURRENT_TIME=$(date +%s)
76+
ELAPSED_TIME=$((CURRENT_TIME - START_TIME))
77+
78+
# Check for timeout
79+
if [ "$ELAPSED_TIME" -ge "$TIMEOUT" ]; then
80+
echo "❌ Timeout: Server did not respond with status $EXPECTED_STATUS within $TIMEOUT seconds."
81+
exit 1
82+
fi
83+
84+
# Get HTTP status code. || true is to reporting a failure to connect as an error
85+
HTTP_STATUS=$(curl --output /dev/null --silent --write-out "%{http_code}" "$URL") || true
86+
echo "STATUS: ${HTTP_STATUS}"
87+
88+
# Check if we got the correct status code
89+
if [ "$HTTP_STATUS" -eq "$EXPECTED_STATUS" ]; then
90+
echo "✅ Server is up! Received status $HTTP_STATUS after $ELAPSED_TIME seconds."
91+
break;
92+
fi
93+
94+
# Wait before retrying
95+
echo "⏳ Server not ready (status: $HTTP_STATUS). Retrying in $RETRY_INTERVAL seconds..."
96+
sleep "$RETRY_INTERVAL"
97+
done
98+
99+
- name: Run TCK
100+
timeout-minutes: 10
101+
run: |
102+
./run_tck.py --sut-url ${{ env.SUT_JSONRPC_URL }} --category all --transports jsonrpc --compliance-report report.json
103+
working-directory: tck/a2a-tck
104+
- name: Upload TCK Log
105+
if: always()
106+
uses: actions/upload-artifact@v4
107+
with:
108+
name: tck-test-log-java-${{ matrix.java-version }}
109+
path: tck/target/tck-test.log
110+
retention-days: 7

‎.github/workflows/run-tck-rest-only.yml‎

Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
name: Run TCK REST Only
2+
3+
on:
4+
# Handle all branches for now
5+
push:
6+
branches:
7+
- main
8+
pull_request:
9+
branches:
10+
- main
11+
workflow_dispatch:
12+
13+
env:
14+
# Tag of the TCK
15+
TCK_VERSION: 0.3.0.beta2
16+
# Tells uv to not need a venv, and instead use system
17+
UV_SYSTEM_PYTHON: 1
18+
# SUT_JSONRPC_URL to use for the TCK and the server agent
19+
SUT_JSONRPC_URL: http://localhost:9999
20+
# Slow system on CI
21+
TCK_STREAMING_TIMEOUT: 5.0
22+
23+
# Only run the latest job
24+
concurrency:
25+
group: '${{ github.workflow }} @ ${{ github.head_ref || github.ref }}'
26+
cancel-in-progress: true
27+
28+
jobs:
29+
tck-test:
30+
runs-on: ubuntu-latest
31+
strategy:
32+
matrix:
33+
java-version: [17, 21, 25]
34+
steps:
35+
- name: Checkout a2a-java
36+
uses: actions/checkout@v4
37+
- name: Checkout a2a-tck
38+
uses: actions/checkout@v4
39+
with:
40+
repository: a2aproject/a2a-tck
41+
path: tck/a2a-tck
42+
ref: ${{ env.TCK_VERSION }}
43+
- name: Set up JDK ${{ matrix.java-version }}
44+
uses: actions/setup-java@v5
45+
with:
46+
java-version: ${{ matrix.java-version }}
47+
distribution: 'temurin'
48+
cache: maven
49+
- name: check java_home
50+
run: echo $JAVA_HOME
51+
- name: Set up Python
52+
uses: actions/setup-python@v5
53+
with:
54+
python-version-file: "tck/a2a-tck/pyproject.toml"
55+
- name: Install uv and Python dependencies
56+
run: |
57+
pip install uv
58+
uv pip install -e .
59+
working-directory: tck/a2a-tck
60+
- name: Build with Maven, skipping tests
61+
run: mvn -B install -DskipTests
62+
- name: Start SUT
63+
run: SUT_GRPC_URL=${{ env.SUT_JSONRPC_URL }} SUT_REST_URL=${{ env.SUT_JSONRPC_URL }} mvn -B quarkus:dev & #SUT_JSONRPC_URL already set
64+
working-directory: tck
65+
- name: Wait for SUT to start
66+
run: |
67+
URL="${{ env.SUT_JSONRPC_URL }}/.well-known/agent-card.json"
68+
EXPECTED_STATUS=200
69+
TIMEOUT=120
70+
RETRY_INTERVAL=2
71+
START_TIME=$(date +%s)
72+
73+
while true; do
74+
# Calculate elapsed time
75+
CURRENT_TIME=$(date +%s)
76+
ELAPSED_TIME=$((CURRENT_TIME - START_TIME))
77+
78+
# Check for timeout
79+
if [ "$ELAPSED_TIME" -ge "$TIMEOUT" ]; then
80+
echo "❌ Timeout: Server did not respond with status $EXPECTED_STATUS within $TIMEOUT seconds."
81+
exit 1
82+
fi
83+
84+
# Get HTTP status code. || true is to reporting a failure to connect as an error
85+
HTTP_STATUS=$(curl --output /dev/null --silent --write-out "%{http_code}" "$URL") || true
86+
echo "STATUS: ${HTTP_STATUS}"
87+
88+
# Check if we got the correct status code
89+
if [ "$HTTP_STATUS" -eq "$EXPECTED_STATUS" ]; then
90+
echo "✅ Server is up! Received status $HTTP_STATUS after $ELAPSED_TIME seconds."
91+
break;
92+
fi
93+
94+
# Wait before retrying
95+
echo "⏳ Server not ready (status: $HTTP_STATUS). Retrying in $RETRY_INTERVAL seconds..."
96+
sleep "$RETRY_INTERVAL"
97+
done
98+
99+
- name: Run TCK
100+
timeout-minutes: 10
101+
run: |
102+
./run_tck.py --sut-url ${{ env.SUT_JSONRPC_URL }} --category all --transports rest --compliance-report report.json
103+
working-directory: tck/a2a-tck
104+
- name: Upload TCK Log
105+
if: always()
106+
uses: actions/upload-artifact@v4
107+
with:
108+
name: tck-test-log-java-${{ matrix.java-version }}
109+
path: tck/target/tck-test.log
110+
retention-days: 7

‎.github/workflows/run-tck.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ jobs:
9797
done
9898
9999
- name: Run TCK
100+
timeout-minutes: 10
100101
run: |
101102
./run_tck.py --sut-url ${{ env.SUT_JSONRPC_URL }} --category all --transports jsonrpc,grpc,rest --compliance-report report.json
102103
working-directory: tck/a2a-tck

‎server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ private boolean shouldAddPushInfo(MessageSendParams params) {
479479

480480
private EnhancedRunnable registerAndExecuteAgentAsync(String taskId, RequestContext requestContext, EventQueue queue) {
481481
LOGGER.debug("Registering agent execution for task {}, runningAgents.size() before: {}", taskId, runningAgents.size());
482-
482+
logThreadStats("AGENT START");
483483
EnhancedRunnable runnable = new EnhancedRunnable() {
484484
@Override
485485
public void run() {
@@ -511,6 +511,7 @@ public void run() {
511511
LOGGER.debug("Task {} not in final state or not yet created, keeping queue open", taskId);
512512
}
513513
}
514+
logThreadStats("AGENT COMPLETE END");
514515
runnable.invokeDoneCallbacks();
515516
});
516517
runningAgents.put(taskId, cf);
@@ -541,6 +542,7 @@ private void trackBackgroundTask(CompletableFuture<Void> task) {
541542
private CompletableFuture<Void> cleanupProducer(String taskId, EventQueue queue, boolean isStreaming) {
542543
LOGGER.debug("Starting cleanup for task {} (streaming={}, queue={}, runningAgents.size={})",
543544
taskId, isStreaming, queue, runningAgents.size());
545+
logThreadStats("CLEANUP START");
544546
CompletableFuture<Void> agentFuture = runningAgents.get(taskId);
545547
if (agentFuture == null) {
546548
LOGGER.debug("No running agent found for task {}, cleanup complete", taskId);
@@ -574,6 +576,7 @@ private CompletableFuture<Void> cleanupProducer(String taskId, EventQueue queue,
574576

575577
// Always remove from running agents
576578
boolean removed = runningAgents.remove(taskId, agentFuture);
579+
logThreadStats("CLEANUP END");
577580
LOGGER.debug("Removed agent for task {} from runningAgents: {}, runningAgents.size() after: {}",
578581
taskId, removed, runningAgents.size());
579582
});

0 commit comments

Comments
 (0)