Skip to content

Commit 3666e4d

Browse files
committed
Review fixes
1 parent 333111a commit 3666e4d

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

examples/cloud-deployment/scripts/deploy.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ if [ "$CONTAINER_TOOL" = "docker" ]; then
135135
echo "Linux/CI detected, using kubectl port-forward..."
136136

137137
# Kill any existing port-forward processes
138-
pkill -f "kubectl.*port-forward.*registry" 2>/dev/null || true
138+
pkill -f "kubectl.*port-forward.*registry" || true
139139

140140
# Start port forward in background
141141
kubectl port-forward --namespace kube-system service/registry 5000:80 > /dev/null 2>&1 &
@@ -200,11 +200,13 @@ else
200200
echo "Push attempt $attempt/$MAX_RETRIES..."
201201
if $CONTAINER_TOOL push ${REGISTRY}/a2a-cloud-deployment:latest 2>&1 | tee /tmp/push.log; then
202202
echo -e "${GREEN}✓ Image pushed to registry${NC}"
203+
rm -f /tmp/push.log
203204
break
204205
else
205206
if [ $attempt -eq $MAX_RETRIES ]; then
206207
echo -e "${RED}ERROR: Failed to push image after $MAX_RETRIES attempts${NC}"
207208
cat /tmp/push.log
209+
rm -f /tmp/push.log
208210
exit 1
209211
fi
210212
echo -e "${YELLOW}Push failed, retrying in 2 seconds...${NC}"
@@ -341,7 +343,8 @@ if [[ "$OSTYPE" == "linux-gnu"* ]] && [ "$CONTAINER_TOOL" = "podman" ]; then
341343
break
342344
fi
343345
if [ $i -eq 30 ]; then
344-
echo -e "${YELLOW}⚠ Topic not found in broker after 30 attempts, continuing anyway${NC}"
346+
echo -e "${RED}ERROR: Topic not found in broker after 30 attempts${NC}"
347+
exit 1
345348
fi
346349
sleep 2
347350
done

0 commit comments

Comments
 (0)