Skip to content

Commit 4e795fc

Browse files
committed
Review fixes
1 parent f82bcd3 commit 4e795fc

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

examples/cloud-deployment/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This example demonstrates deploying an A2A agent to Kubernetes with:
66
- **Kafka event replication** for cross-pod event streaming
77
- **JSON-RPC transport** for client-server communication
88

9-
Note that the aim of this example is just to demonstrate how to set up a2a-java in a cloud environment. Hence, it doesn't do anything with an LLM. It just inter
9+
Note that the aim of this example is just to demonstrate how to set up a2a-java in a cloud environment. Hence, it doesn't do anything with an LLM, but shows that it can be configured to work in a cloud, or other distributed, environment.
1010

1111
## Architecture
1212

@@ -122,7 +122,7 @@ Expected output:
122122
The agent service uses **NodePort** with Kind **extraPortMappings** to expose the service:
123123

124124
- Kind maps **host port 8080****node port 30080** (configured in `kind-config.yaml`)
125-
- Kubernetes Service maps **NodePort 30080****pod port 8080** (configured in `k8s/0-agent-deployment.yaml`)
125+
- Kubernetes Service maps **NodePort 30080****pod port 8080** (configured in `k8s/05-agent-deployment.yaml`)
126126
- Result: Access the agent at **http://localhost:8080** from your host machine
127127

128128
This approach provides the same round-robin load balancing as a real LoadBalancer but works consistently across all platforms (macOS, Linux, Windows, and CI environments like GitHub Actions).
@@ -512,7 +512,7 @@ cloud-deployment/
512512
│ ├── 00-namespace.yaml # Kubernetes namespace
513513
│ ├── 01-postgres.yaml # PostgreSQL deployment
514514
│ ├── 02-kafka.yaml # Strimzi Kafka cluster
515-
│ ├── 03-kafka-topic.yaml # Strimzi Kafka cluster
515+
│ ├── 03-kafka-topic.yaml # Kafka topic
516516
│ ├── 04-agent-configmap.yaml # Configuration
517517
│ └── 05-agent-deployment.yaml # Agent deployment + service
518518
├── scripts/

examples/cloud-deployment/k8s/05-agent-deployment.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ spec:
1818
containers:
1919
- name: a2a-agent
2020
image: localhost:5001/a2a-cloud-deployment:latest
21-
imagePullPolicy: IfNotPresent
21+
# Always pull to ensure latest image is used when rebuilding with :latest tag
22+
# For production, use digest-based image references (e.g., @sha256:...)
23+
imagePullPolicy: Always
2224
ports:
2325
- containerPort: 8080
2426
name: http

0 commit comments

Comments
 (0)