Gemini code review

Author: kabir

reference-impl/src/test/java/io/a2a/server/apps/quarkus/A2ATestRoutes.java

@@ -85,14 +85,13 @@ public void deleteTask(@Param String taskId, RoutingContext rc) {
             testUtilsBean.deleteTask(taskId);
             rc.response()
                     .setStatusCode(200)
-                    .putHeader(CONTENT_TYPE, APPLICATION_JSON)
                     .end();
         } catch (Throwable t) {
             errorResponse(t, rc);
         }
     }
 
-    @Route(path = "test/queue/ensure/:taskId", methods = {Route.HttpMethod.POST})
+    @Route(path = "/test/queue/ensure/:taskId", methods = {Route.HttpMethod.POST})
     public void ensureTaskQueue(@Param String taskId, RoutingContext rc) {
         try {
             testUtilsBean.ensureQueue(taskId);
@@ -104,7 +103,7 @@ public void ensureTaskQueue(@Param String taskId, RoutingContext rc) {
         }
     }
 
-    @Route(path = "test/queue/enqueueTaskStatusUpdateEvent/:taskId", methods = {Route.HttpMethod.POST})
+    @Route(path = "/test/queue/enqueueTaskStatusUpdateEvent/:taskId", methods = {Route.HttpMethod.POST})
     public void enqueueTaskStatusUpdateEvent(@Param String taskId, @Body String body, RoutingContext rc) {
 
         try {
@@ -118,7 +117,7 @@ public void enqueueTaskStatusUpdateEvent(@Param String taskId, @Body String body
         }
     }
 
-    @Route(path = "test/queue/enqueueTaskArtifactUpdateEvent/:taskId", methods = {Route.HttpMethod.POST})
+    @Route(path = "/test/queue/enqueueTaskArtifactUpdateEvent/:taskId", methods = {Route.HttpMethod.POST})
     public void enqueueTaskArtifactUpdateEvent(@Param String taskId, @Body String body, RoutingContext rc) {
 
         try {
@@ -132,16 +131,17 @@ public void enqueueTaskArtifactUpdateEvent(@Param String taskId, @Body String bo
         }
     }
 
-    @Route(path = "test/streamingSubscribedCount", methods = {Route.HttpMethod.GET}, produces = {TEXT_PLAIN})
+    @Route(path = "/test/streamingSubscribedCount", methods = {Route.HttpMethod.GET}, produces = {TEXT_PLAIN})
     public void getStreamingSubscribedCount(RoutingContext rc) {
         rc.response()
                 .setStatusCode(200)
                 .end(String.valueOf(streamingSubscribedCount.get()));
     }
 
     private void errorResponse(Throwable t, RoutingContext rc) {
+        t.printStackTrace();
         rc.response()
-                .setStatusCode(200)
+                .setStatusCode(500)
                 .putHeader(CONTENT_TYPE, TEXT_PLAIN)
                 .end();
     }

tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java

@@ -122,7 +122,7 @@ public void testTaskStoreMethodsSanityTest() throws Exception {
         Task saved = getTaskFromTaskStore(task.getId());
         assertEquals(task.getId(), saved.getId());
         assertEquals(task.getContextId(), saved.getContextId());
-        assertEquals(task.getStatus(), saved.getStatus());
+        assertEquals(task.getStatus().state(), saved.getStatus().state());
 
         deleteTaskInTaskStore(task.getId());
         Task saved2 = getTaskFromTaskStore(task.getId());
@@ -160,7 +160,6 @@ private void testGetTask(String mediaType) throws Exception {
             assertEquals("session-xyz", response.getResult().getContextId());
             assertEquals(TaskState.SUBMITTED, response.getResult().getStatus().state());
             assertNull(response.getError());
-        } catch (Exception e) {
         } finally {
             deleteTaskInTaskStore(MINIMAL_TASK.getId());
         }
@@ -971,12 +970,13 @@ protected void enqueueEventOnServer(Event event) throws Exception {
                 .build();
         HttpRequest request = HttpRequest.newBuilder()
                 .uri(URI.create("http://localhost:" + serverPort + "/" + path))
+                .header("Content-Type", APPLICATION_JSON)
                 .POST(HttpRequest.BodyPublishers.ofString(Utils.OBJECT_MAPPER.writeValueAsString(event)))
                 .build();
 
         HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString(StandardCharsets.UTF_8));
         if (response.statusCode() != 200) {
-            throw new RuntimeException(response.statusCode() + ": Deleting task failed!" + response.body());
+            throw new RuntimeException(response.statusCode() + ": Queueing event failed!" + response.body());
         }
     }
 
@@ -986,15 +986,22 @@ private CompletableFuture<Void> awaitStreamingSubscription() {
 
         return CompletableFuture.runAsync(() -> {
             try {
-                while (true) {
+                boolean done = false;
+                long end = System.currentTimeMillis() + 15000;
+                while (System.currentTimeMillis() < end) {
                     int count = getStreamingSubscribedCount();
                     if (count > initialCount.get()) {
+                        done = true;
                         break;
                     }
                     Thread.sleep(500);
                 }
+                if (!done) {
+                    throw new RuntimeException("Timed out waiting for subscription");
+                }
             } catch (InterruptedException e) {
                 Thread.currentThread().interrupt();
+                throw new RuntimeException("Interrupted");
             }
         });
     }
@@ -1010,8 +1017,7 @@ private int getStreamingSubscribedCount() {
         try {
             HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString(StandardCharsets.UTF_8));
             String body = response.body().trim();
-            System.out.println(body);
-            return Integer.valueOf(body);
+            return Integer.parseInt(body);
         } catch (IOException | InterruptedException e) {
             throw new RuntimeException(e);
         }