fix: Fixing build on Java 25. (#329)

Tests are failing on Java 25 because of a classloading issue if uwing
vertx json codec instead of Jackson object mapper.

Signed-off-by: Emmanuel Hugonnet <[email protected]>

Author: ehsavoie

.github/workflows/build-and-test.yml

@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java-version: ['17', '21']
+        java-version: ['17', '21', '25']
     steps:
     - uses: actions/checkout@v4
     - name: Set up JDK ${{ matrix.java-version }}

extras/push-notification-config-store-database-jpa/pom.xml

@@ -104,31 +104,4 @@
             <scope>test</scope>
         </dependency>
     </dependencies>
-
-    <profiles>
-        <profile>
-            <id>java24-exclude-vertx-incompatible-tests</id>
-            <activation>
-                <jdk>[24,)</jdk>
-            </activation>
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine>
-                            <excludes>
-                                <!-- TODO: Remove this profile when Quarkus is updated to a version using Vert.x 4.6.0+.
-                                     This test is excluded on Java 24+ due to a Vert.x ServiceLoader incompatibility with SSE streaming.
-                                     Current Quarkus versions (e.g., 3.25.x, 2.28.1) use Vert.x 4.5.x, which is not compatible with Java 24. -->
-                                <exclude>**/JpaDatabasePushNotificationConfigStoreIntegrationTest.java</exclude>
-                            </excludes>
-                        </configuration>
-                    </plugin>
-                </plugins>
-            </build>
-        </profile>
-    </profiles>
-
-
 </project>

extras/push-notification-config-store-database-jpa/src/test/java/io/a2a/extras/pushnotificationconfigstore/database/jpa/JpaDatabasePushNotificationConfigStoreIntegrationTest.java

@@ -23,7 +23,6 @@
 import io.a2a.spec.AgentCard;
 import io.a2a.spec.DeleteTaskPushNotificationConfigParams;
 import io.a2a.spec.GetTaskPushNotificationConfigParams;
-import io.a2a.spec.ListTaskPushNotificationConfigParams;
 import io.a2a.spec.Message;
 import io.a2a.spec.PushNotificationConfig;
 import io.a2a.spec.Task;

pom.xml

@@ -60,7 +60,7 @@
         <os-maven-plugin.version>1.7.1</os-maven-plugin.version>
         <protobuf.version>4.31.1</protobuf.version>
         <protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
-        <quarkus.platform.version>3.28.1</quarkus.platform.version>
+        <quarkus.platform.version>3.28.2</quarkus.platform.version>
         <rest-assured.version>5.5.1</rest-assured.version>
         <slf4j.version>2.0.17</slf4j.version>
         <logback.version>1.5.18</logback.version>

reference/jsonrpc/src/main/java/io/a2a/server/apps/quarkus/A2AServerRoutes.java

@@ -64,7 +64,6 @@
 import io.vertx.core.MultiMap;
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.http.HttpServerResponse;
-import io.vertx.core.json.Json;
 import io.vertx.ext.web.RoutingContext;
 
 @Singleton
@@ -111,19 +110,19 @@ public void invokeJSONRPCHandler(@Body String body, RoutingContext rc) {
                 rc.response()
                         .setStatusCode(200)
                         .putHeader(CONTENT_TYPE, APPLICATION_JSON)
-                        .end(Json.encodeToBuffer(error));
+                        .end(Utils.toJsonString(error));
             } else if (streaming) {
                 final Multi<? extends JSONRPCResponse<?>> finalStreamingResponse = streamingResponse;
                 executor.execute(() -> {
-                        MultiSseSupport.subscribeObject(
-                                finalStreamingResponse.map(i -> (Object)i), rc);
+                    MultiSseSupport.subscribeObject(
+                            finalStreamingResponse.map(i -> (Object) i), rc);
                 });
 
             } else {
                 rc.response()
                         .setStatusCode(200)
                         .putHeader(CONTENT_TYPE, APPLICATION_JSON)
-                        .end(Json.encodeToBuffer(nonStreamingResponse));
+                        .end(Utils.toJsonString(nonStreamingResponse));
             }
         }
     }
@@ -151,7 +150,7 @@ private JSONRPCErrorResponse handleError(JsonProcessingException exception) {
     }
 
     /**
-    /**
+     * /**
      * Handles incoming GET requests to the agent card endpoint.
      * Returns the agent card in JSON format.
      *
@@ -331,10 +330,9 @@ public Buffer apply(Object o) {
                         ReactiveRoutes.ServerSentEvent<?> ev = (ReactiveRoutes.ServerSentEvent<?>) o;
                         long id = ev.id() != -1 ? ev.id() : count.getAndIncrement();
                         String e = ev.event() == null ? "" : "event: " + ev.event() + "\n";
-                        return Buffer.buffer(e + "data: " + Json.encodeToBuffer(ev.data()) + "\nid: " + id + "\n\n");
-                    } else {
-                        return Buffer.buffer("data: " + Json.encodeToBuffer(o) + "\nid: " + count.getAndIncrement() + "\n\n");
+                        return Buffer.buffer(e + "data: " + Utils.toJsonString(ev.data()) + "\nid: " + id + "\n\n");
                     }
+                    return Buffer.buffer("data: " + Utils.toJsonString(o) + "\nid: " + count.getAndIncrement() + "\n\n");
                 }
             }), rc);
         }
@@ -350,4 +348,3 @@ private static void endOfStream(HttpServerResponse response) {
         }
     }
 }
-

spec/src/main/java/io/a2a/spec/SendStreamingMessageResponse.java

@@ -1,12 +1,10 @@
 package io.a2a.spec;
 
-import static io.a2a.util.Utils.defaultIfNull;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.annotation.JsonProperty;
-import io.a2a.util.Assert;
 
 /**
  * The response after receiving a request to initiate a task with streaming.

spec/src/main/java/io/a2a/util/Utils.java

@@ -94,5 +94,12 @@ public static Task appendArtifactToTask(Task task, TaskArtifactUpdateEvent event
 
     }
 
-    
+    public static String toJsonString(Object o) {
+        try {
+            return OBJECT_MAPPER.writeValueAsString(o);
+        } catch (JsonProcessingException ex) {
+            throw new RuntimeException(ex);
+        }
+    }
+
 }