Skip to content

Commit 6584d7a

Browse files
committed
TaskUpdater parameters in same order as AgentExecutor.execute()
1 parent eeed1ac commit 6584d7a

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

src/main/java/io/a2a/server/tasks/TaskUpdater.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public class TaskUpdater {
1919
private final String taskId;
2020
private final String contextId;
2121

22-
public TaskUpdater(EventQueue eventQueue, RequestContext context) {
22+
public TaskUpdater(RequestContext context, EventQueue eventQueue) {
2323
this.eventQueue = eventQueue;
2424
this.taskId = context.getTaskId();
2525
this.contextId = context.getContextId();

src/test/java/io/a2a/server/apps/AgentExecutorProducer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public void execute(RequestContext context, EventQueue eventQueue) throws JSONRP
3030
@Override
3131
public void cancel(RequestContext context, EventQueue eventQueue) throws JSONRPCError {
3232
if (context.getTask().getId().equals("cancel-task-123")) {
33-
TaskUpdater taskUpdater = new TaskUpdater(eventQueue, context);
33+
TaskUpdater taskUpdater = new TaskUpdater(context, eventQueue);
3434
taskUpdater.cancel();
3535
} else if (context.getTask().getId().equals("cancel-task-not-supported-123")) {
3636
throw new UnsupportedOperationError();

src/test/java/io/a2a/server/requesthandlers/JSONRPCHandlerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public void testOnCancelTaskSuccess() throws Exception {
167167
// Looking at the Python implementation, they typically use AgentExecutors that
168168
// don't support cancellation. So my theory is the Agent updates the task to the CANCEL status
169169
Task task = context.getTask();
170-
TaskUpdater taskUpdater = new TaskUpdater(eventQueue, context);
170+
TaskUpdater taskUpdater = new TaskUpdater(context, eventQueue);
171171
taskUpdater.cancel();
172172
};
173173

src/test/java/io/a2a/server/tasks/TaskUpdaterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public void init() {
4747
.setTaskId(TEST_TASK_ID)
4848
.setContextId(TEST_TASK_CONTEXT_ID)
4949
.build();
50-
taskUpdater = new TaskUpdater(eventQueue, context);
50+
taskUpdater = new TaskUpdater(context, eventQueue);
5151
}
5252

5353
@Test

tck/src/main/java/io/a2a/tck/server/AgentExecutorProducer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public void execute(RequestContext context, EventQueue eventQueue) throws JSONRP
4343
eventQueue.enqueueEvent(task);
4444
}
4545

46-
TaskUpdater updater = new TaskUpdater(eventQueue, context);
46+
TaskUpdater updater = new TaskUpdater(context, eventQueue);
4747

4848
// Immediately set to WORKING state
4949
updater.startWork();
@@ -68,7 +68,7 @@ public void cancel(RequestContext context, EventQueue eventQueue) throws JSONRPC
6868
throw new TaskNotCancelableError();
6969
}
7070

71-
TaskUpdater updater = new TaskUpdater(eventQueue, context);
71+
TaskUpdater updater = new TaskUpdater(context, eventQueue);
7272
updater.cancel();
7373
eventQueue.enqueueEvent(new TaskStatusUpdateEvent.Builder()
7474
.taskId(task.getId())

0 commit comments

Comments
 (0)