fix: implement gemini suggestions

Author: ronantakizawa

server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java

@@ -117,7 +117,7 @@ public Task onGetTask(TaskQueryParams params, ServerCallContext context) throws
 
     @Override
     public List<Task> onListTasks(TaskListParams params, ServerCallContext context) throws JSONRPCError {
-        LOGGER.debug("onListTasks");
+        LOGGER.debug("onListTasks with params: {}", params);
         return taskStore.listAll();
     }
 

spec/src/main/java/io/a2a/spec/TaskListParams.java

@@ -15,4 +15,4 @@ public record TaskListParams(Map<String, Object> metadata) {
     public TaskListParams() {
         this(null);
     }
-}
+}

transport/httprest/pom.xml

@@ -50,5 +50,5 @@
         </dependency>
 
     </dependencies>
-    
+
 </project>

transport/httprest/src/main/java/io/a2a/httprest/handler/HTTPRestHandler.java

@@ -50,21 +50,19 @@ public class HTTPRestHandler {
     private static final Pattern LIST_PUSH_NOTIFICATION_CONFIG_PATTERN = Pattern.compile("^/v1/tasks/([^/]+)/pushNotificationConfigs$");
     private static final Pattern DELETE_PUSH_NOTIFICATION_CONFIG_PATTERN = Pattern.compile("^/v1/tasks/([^/]+)/pushNotificationConfigs/([^/]+)$");
 
+    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper().registerModule(new JavaTimeModule());
+
     private AgentCard agentCard;
     private RequestHandler requestHandler;
-    private ObjectMapper objectMapper;
 
     protected HTTPRestHandler() {
-        this.objectMapper = new ObjectMapper();
-        this.objectMapper.registerModule(new JavaTimeModule());
+        // For CDI
     }
 
     @Inject
     public HTTPRestHandler(@PublicAgentCard AgentCard agentCard, RequestHandler requestHandler) {
         this.agentCard = agentCard;
         this.requestHandler = requestHandler;
-        this.objectMapper = new ObjectMapper();
-        this.objectMapper.registerModule(new JavaTimeModule());
     }
 
     public HTTPRestResponse handleRequest(String method, String path, String body, ServerCallContext context) {
@@ -183,6 +181,9 @@ private HTTPRestResponse handlePostRequest(String path, String body, ServerCallC
             }
             String taskId = listPushConfigMatcher.group(1);
             TaskPushNotificationConfig config = parseRequestBody(body, TaskPushNotificationConfig.class);
+            if (!taskId.equals(config.taskId())) {
+                throw new InvalidParamsError("Task ID in URL path does not match task ID in request body.");
+            }
             TaskPushNotificationConfig result = requestHandler.onSetTaskPushNotificationConfig(config, context);
             return createSuccessResponse(201, result);
         }
@@ -215,15 +216,15 @@ private <T> T parseRequestBody(String body, Class<T> valueType) throws JSONRPCEr
             if (body == null || body.trim().isEmpty()) {
                 throw new InvalidParamsError("Request body is required");
             }
-            return objectMapper.readValue(body, valueType);
+            return OBJECT_MAPPER.readValue(body, valueType);
         } catch (Exception e) {
             throw new InvalidParamsError("Failed to parse request body: " + e.getMessage());
         }
     }
 
     private HTTPRestResponse createSuccessResponse(int statusCode, Object data) {
         try {
-            String jsonBody = data != null ? objectMapper.writeValueAsString(data) : null;
+            String jsonBody = data != null ? OBJECT_MAPPER.writeValueAsString(data) : null;
             return new HTTPRestResponse(statusCode, "application/json", jsonBody);
         } catch (Exception e) {
             return createErrorResponse(500, new InternalError("Failed to serialize response: " + e.getMessage()));
@@ -233,7 +234,7 @@ private HTTPRestResponse createSuccessResponse(int statusCode, Object data) {
     private HTTPRestResponse createErrorResponse(int statusCode, JSONRPCError error) {
         try {
             HTTPRestErrorResponse errorResponse = new HTTPRestErrorResponse(error.getClass().getSimpleName(), error.getMessage());
-            String jsonBody = objectMapper.writeValueAsString(errorResponse);
+            String jsonBody = OBJECT_MAPPER.writeValueAsString(errorResponse);
             return new HTTPRestResponse(statusCode, "application/json", jsonBody);
         } catch (Exception e) {
             String fallbackJson = "{\"error\":\"InternalError\",\"message\":\"Failed to serialize error response\"}";
@@ -313,4 +314,4 @@ public HTTPRestErrorResponse(String error, String message) {
         public String getError() { return error; }
         public String getMessage() { return message; }
     }
-}
+}

transport/httprest/src/main/resources/META-INF/beans.xml

@@ -4,4 +4,4 @@
        xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee 
                            http://xmlns.jcp.org/xml/ns/javaee/beans_1_1.xsd"
        bean-discovery-mode="all">
-</beans>
+</beans>

transport/httprest/src/test/java/io/a2a/httprest/handler/HTTPRestHandlerTest.java

@@ -328,4 +328,4 @@ public void testHttpStatusCodeMapping() {
         response = handler.handleRequest("PATCH", "/v1/card", null, callContext);
         Assertions.assertEquals(405, response.getStatusCode());
     }
-}
+}