Skip to content

Commit 7247303

Browse files
committed
Fixing rest client tests
Signed-off-by: Emmanuel Hugonnet <[email protected]>
1 parent 0410edf commit 7247303

File tree

2 files changed

+36
-29
lines changed

2 files changed

+36
-29
lines changed

client/transport/jsonrpc/src/test/java/io/a2a/client/transport/jsonrpc/JsonStreamingMessages.java

Lines changed: 30 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -107,42 +107,47 @@ public class JsonStreamingMessages {
107107

108108
public static final String SEND_MESSAGE_STREAMING_TEST_REQUEST = """
109109
{
110-
"jsonrpc": "2.0",
111-
"method": "SendStreamingMessage",
112-
"params": {
113-
"message": {
114-
"role": "user",
115-
"parts": [
116-
{
117-
"kind": "text",
118-
"text": "tell me some jokes"
110+
"jsonrpc":"2.0",
111+
"method":"message/stream",
112+
"params":{
113+
"message":{
114+
"messageId":"message-1234",
115+
"contextId":"context-1234",
116+
"role":"ROLE_USER",
117+
"parts":[
118+
{
119+
"text":"tell me some jokes"
120+
}
121+
],
122+
"metadata":{
123+
124+
}
125+
},
126+
"configuration":{
127+
"acceptedOutputModes":[
128+
"text"
129+
]
130+
},
131+
"metadata":{
132+
119133
}
120-
],
121-
"messageId": "message-1234",
122-
"contextId": "context-1234",
123-
"kind": "message"
124-
},
125-
"configuration": {
126-
"acceptedOutputModes": ["text"],
127-
"blocking": false
128134
}
129-
}
130135
}""";
131136

132137
static final String SEND_MESSAGE_STREAMING_TEST_RESPONSE =
133138
"event: message\n" +
134-
"data: {\"jsonrpc\":\"2.0\",\"id\":1,\"result\":{\"id\":\"2\",\"contextId\":\"context-1234\",\"status\":{\"state\":\"completed\"},\"artifacts\":[{\"artifactId\":\"artifact-1\",\"name\":\"joke\",\"parts\":[{\"kind\":\"text\",\"text\":\"Why did the chicken cross the road? To get to the other side!\"}]}],\"metadata\":{},\"kind\":\"task\"}}\n\n";
139+
"data: {\"jsonrpc\":\"2.0\",\"id\":1,\"result\":{\"task\":{\"id\":\"2\",\"contextId\":\"context-1234\",\"status\":{\"state\":\"TASK_STATE_COMPLETED\"},\"artifacts\":[{\"artifactId\":\"artifact-1\",\"name\":\"joke\",\"parts\":[{\"text\":\"Why did the chicken cross the road? To get to the other side!\"}]}],\"metadata\":{}}}}\n\n";
135140

136141
static final String TASK_RESUBSCRIPTION_REQUEST_TEST_RESPONSE =
137142
"event: message\n" +
138-
"data: {\"jsonrpc\":\"2.0\",\"id\":1,\"result\":{\"id\":\"2\",\"contextId\":\"context-1234\",\"status\":{\"state\":\"completed\"},\"artifacts\":[{\"artifactId\":\"artifact-1\",\"name\":\"joke\",\"parts\":[{\"kind\":\"text\",\"text\":\"Why did the chicken cross the road? To get to the other side!\"}]}],\"metadata\":{},\"kind\":\"task\"}}\n\n";
143+
"data: {\"jsonrpc\":\"2.0\",\"id\":1,\"result\":{\"task\":{\"id\":\"2\",\"contextId\":\"context-1234\",\"status\":{\"state\":\"TASK_STATE_COMPLETED\"},\"artifacts\":[{\"artifactId\":\"artifact-1\",\"name\":\"joke\",\"parts\":[{\"text\":\"Why did the chicken cross the road? To get to the other side!\"}]}],\"metadata\":{}}}}\n\n";
139144

140145
public static final String TASK_RESUBSCRIPTION_TEST_REQUEST = """
141146
{
142-
"jsonrpc": "2.0",
143-
"method": "SubscribeToTask",
144-
"params": {
145-
"id": "task-1234"
146-
}
147+
"jsonrpc":"2.0",
148+
"method":"SubscribeToTask",
149+
"params":{
150+
"name":"tasks/task-1234"
151+
}
147152
}""";
148153
}

client/transport/rest/src/test/java/io/a2a/client/transport/rest/RestTransportTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ public void testSendMessage() throws Exception {
149149
assertEquals(1, history.getParts().size());
150150
assertEquals(Kind.TEXT, history.getParts().get(0).getKind());
151151
assertEquals("tell me a joke", ((TextPart) history.getParts().get(0)).getText());
152-
assertNull(history.getMetadata());
152+
assertNull(task.getMetadata());
153153
assertNull(history.getReferenceTaskIds());
154154
}
155155

@@ -176,7 +176,8 @@ public void testCancelTask() throws Exception {
176176
assertEquals("de38c76d-d54c-436c-8b9f-4c2703648d64", task.getId());
177177
assertEquals(TaskState.CANCELED, task.getStatus().state());
178178
assertNull(task.getStatus().message());
179-
assertNull(task.getMetadata());
179+
assertNotNull(task.getMetadata());
180+
assertTrue(task.getMetadata().isEmpty());
180181
}
181182

182183
/**
@@ -201,7 +202,8 @@ public void testGetTask() throws Exception {
201202
assertEquals("de38c76d-d54c-436c-8b9f-4c2703648d64", task.getId());
202203
assertEquals(TaskState.COMPLETED, task.getStatus().state());
203204
assertNull(task.getStatus().message());
204-
assertNull(task.getMetadata());
205+
assertNotNull(task.getMetadata());
206+
assertTrue(task.getMetadata().isEmpty());
205207
assertEquals(false, task.getArtifacts().isEmpty());
206208
assertEquals(1, task.getArtifacts().size());
207209
Artifact artifact = task.getArtifacts().get(0);
@@ -225,7 +227,7 @@ public void testGetTask() throws Exception {
225227
part = (FilePart) history.getParts().get(2);
226228
assertEquals(Kind.FILE, part.getKind());
227229
assertEquals("text/plain", part.getFile().mimeType());
228-
assertEquals("hello", ((FileWithBytes) part.getFile()).bytes());
230+
assertEquals("aGVsbG8=", ((FileWithBytes) part.getFile()).bytes());
229231
assertNull(history.getMetadata());
230232
assertNull(history.getReferenceTaskIds());
231233
}

0 commit comments

Comments
 (0)