Skip to content

Commit 7465213

Browse files
chore: Enable javadoc in the default profile (#525)
Any javadoc errors (not warnings) will make Maven fail This fixes #524 --------- Signed-off-by: Jeff Mesnil <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent e2e32e5 commit 7465213

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,10 @@
454454
<groupId>org.apache.maven.plugins</groupId>
455455
<artifactId>maven-compiler-plugin</artifactId>
456456
</plugin>
457+
<plugin>
458+
<groupId>org.apache.maven.plugins</groupId>
459+
<artifactId>maven-javadoc-plugin</artifactId>
460+
</plugin>
457461
<plugin>
458462
<groupId>org.apache.maven.plugins</groupId>
459463
<artifactId>maven-surefire-plugin</artifactId>
@@ -516,10 +520,6 @@
516520
<groupId>org.apache.maven.plugins</groupId>
517521
<artifactId>maven-source-plugin</artifactId>
518522
</plugin>
519-
<plugin>
520-
<groupId>org.apache.maven.plugins</groupId>
521-
<artifactId>maven-javadoc-plugin</artifactId>
522-
</plugin>
523523
<plugin>
524524
<groupId>org.apache.maven.plugins</groupId>
525525
<artifactId>maven-gpg-plugin</artifactId>

spec/src/main/java/io/a2a/json/JsonUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ private static GsonBuilder createBaseGsonBuilder() {
7979
* <p>
8080
* Used throughout the SDK for consistent JSON serialization and deserialization.
8181
*
82-
* @see GsonFactory#createGson()
82+
* @see GsonBuilder
8383
*/
8484
public static final Gson OBJECT_MAPPER = createBaseGsonBuilder()
8585
.registerTypeHierarchyAdapter(Part.class, new PartTypeAdapter())

spec/src/main/java/io/a2a/util/Utils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.a2a.util;
22

3+
import java.lang.reflect.Type;
34
import java.util.ArrayList;
45
import java.util.List;
56

@@ -43,7 +44,7 @@ public class Utils {
4344
/**
4445
* Deserializes JSON string into a typed object using Gson.
4546
* <p>
46-
* This method uses the pre-configured {@link #OBJECT_MAPPER} to parse JSON.
47+
* This method uses the pre-configured {@link JsonUtil#fromJson(String, Class)} to parse JSON.
4748
*
4849
* @param <T> the target type
4950
* @param data JSON string to deserialize

0 commit comments

Comments
 (0)