Skip to content

Commit 9a8e9e5

Browse files
authored
fix: Remove TempLoggerWrapper and use logback as the logging implementation. (#158)
Hi @kabir , as we discussed previously: #94. This PR removes the `TempLoggerWrapper` and uses `logback` as the default logging implementation. `logback` automatically loads the `logback.xml` file from the classpath, and we can easily adjust the logging level by modifying this file. Fixes #94 --------- Signed-off-by: Sun Yuhan <[email protected]> Co-authored-by: Sun Yuhan <[email protected]>
1 parent f1b8801 commit 9a8e9e5

File tree

7 files changed

+46
-376
lines changed

7 files changed

+46
-376
lines changed

pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
<quarkus.platform.version>3.22.3</quarkus.platform.version>
3030
<rest-assured.version>5.5.1</rest-assured.version>
3131
<slf4j.version>2.0.17</slf4j.version>
32+
<logback.version>1.5.18</logback.version>
3233

3334
<!-- Redirect test output to file -->
3435
<maven.test.redirectTestOutputToFile>true</maven.test.redirectTestOutputToFile>
@@ -111,6 +112,12 @@
111112
<version>${mockserver.version}</version>
112113
<scope>test</scope>
113114
</dependency>
115+
<dependency>
116+
<groupId>ch.qos.logback</groupId>
117+
<artifactId>logback-classic</artifactId>
118+
<version>${logback.version}</version>
119+
<scope>test</scope>
120+
</dependency>
114121
</dependencies>
115122
</dependencyManagement>
116123

sdk-server-common/pom.xml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,24 @@
5050
<groupId>io.quarkus</groupId>
5151
<artifactId>quarkus-arc</artifactId>
5252
<scope>test</scope>
53+
<exclusions>
54+
<exclusion>
55+
<groupId>org.jboss.logging</groupId>
56+
<artifactId>jboss-logging</artifactId>
57+
</exclusion>
58+
<exclusion>
59+
<groupId>org.jboss.logmanager</groupId>
60+
<artifactId>jboss-logmanager</artifactId>
61+
</exclusion>
62+
<exclusion>
63+
<groupId>org.jboss.threads</groupId>
64+
<artifactId>jboss-threads</artifactId>
65+
</exclusion>
66+
<exclusion>
67+
<groupId>org.jboss.slf4j</groupId>
68+
<artifactId>slf4j-jboss-logmanager</artifactId>
69+
</exclusion>
70+
</exclusions>
5371
</dependency>
5472
<dependency>
5573
<groupId>org.junit.jupiter</groupId>
@@ -66,6 +84,11 @@
6684
<artifactId>mockserver-netty</artifactId>
6785
<scope>test</scope>
6886
</dependency>
87+
<dependency>
88+
<groupId>ch.qos.logback</groupId>
89+
<artifactId>logback-classic</artifactId>
90+
<scope>test</scope>
91+
</dependency>
6992
</dependencies>
7093

7194
</project>

sdk-server-common/src/main/java/io/a2a/server/events/EventQueue.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,13 @@
1010
import java.util.concurrent.TimeUnit;
1111
import java.util.concurrent.atomic.AtomicBoolean;
1212

13-
import io.a2a.server.util.TempLoggerWrapper;
1413
import io.a2a.spec.Event;
1514
import org.slf4j.Logger;
1615
import org.slf4j.LoggerFactory;
1716

1817
public abstract class EventQueue implements AutoCloseable {
1918

20-
private static final Logger log = new TempLoggerWrapper(LoggerFactory.getLogger(EventQueue.class));
19+
private static final Logger log = LoggerFactory.getLogger(EventQueue.class);
2120

2221
// TODO decide on a capacity
2322
private static final int queueSize = 1000;

sdk-server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import io.a2a.server.tasks.ResultAggregator;
3232
import io.a2a.server.tasks.TaskManager;
3333
import io.a2a.server.tasks.TaskStore;
34-
import io.a2a.server.util.TempLoggerWrapper;
3534
import io.a2a.server.util.async.Internal;
3635
import io.a2a.spec.Event;
3736
import io.a2a.spec.EventKind;
@@ -53,7 +52,7 @@
5352
@ApplicationScoped
5453
public class DefaultRequestHandler implements RequestHandler {
5554

56-
private static final Logger log = new TempLoggerWrapper(LoggerFactory.getLogger(DefaultRequestHandler.class));
55+
private static final Logger log = LoggerFactory.getLogger(DefaultRequestHandler.class);
5756

5857
private final AgentExecutor agentExecutor;
5958
private final TaskStore taskStore;

sdk-server-common/src/main/java/io/a2a/server/tasks/ResultAggregator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import java.util.concurrent.atomic.AtomicReference;
1010

1111
import io.a2a.server.events.EventConsumer;
12-
import io.a2a.server.util.TempLoggerWrapper;
1312
import io.a2a.spec.A2AServerException;
1413
import io.a2a.spec.Event;
1514
import io.a2a.spec.EventKind;
@@ -23,7 +22,7 @@
2322
import org.slf4j.LoggerFactory;
2423

2524
public class ResultAggregator {
26-
private static final Logger log = new TempLoggerWrapper(LoggerFactory.getLogger(ResultAggregator.class));
25+
private static final Logger log = LoggerFactory.getLogger(ResultAggregator.class);
2726

2827
private final TaskManager taskManager;
2928
private volatile Message message;

0 commit comments

Comments
 (0)