Commit a7bb042
fix: Use @internal Executor instead of ForkJoinPool for event consumption
Problem:
- ResultAggregator.consumeAndBreakOnInterrupt() used CompletableFuture.runAsync()
without executor parameter
- Defaulted to ForkJoinPool.commonPool (only 3 threads on CI)
- During concurrent request bursts (6+ simultaneous), ForkJoinPool saturates
- Some consumer subscriptions never scheduled, Vert.x threads block forever
- Agents accumulate in runningAgents map, never cleaned up
Root Cause:
- ForkJoinPool.commonPool designed for CPU-bound tasks
- Our queue polling loop blocks for I/O (queue.dequeueEvent(500ms))
- Blocking I/O saturates limited ForkJoinPool workers
- Subsequent tasks queued but never execute
Solution:
- Pass @internal Executor to ResultAggregator constructor
- Use executor in runAsync() call instead of default ForkJoinPool
- @internal executor configured with 15 threads for I/O-bound operations
- Can handle concurrent request bursts without saturation
Evidence:
- Run 2/3 logs: Agents accumulate during 6-request burst at 30s intervals
- Thread dumps: Vert.x workers blocked at completionFuture.join()
- ForkJoinPool stops after initial requests, subsequent tasks never poll queues
- Detailed investigation in claudedocs/TCK_TIMEOUT_INVESTIGATION.md
Related:
- Issue #248
- Commit 3e93dd2 (removed awaitQueuePollerStart workaround)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 6572cdb commit a7bb042
File tree
3 files changed
+18
-11
lines changed- server-common/src
- main/java/io/a2a/server
- requesthandlers
- tasks
- test/java/io/a2a/server/tasks
3 files changed
+18
-11
lines changedLines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
242 | | - | |
| 242 | + | |
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
| |||
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | | - | |
| 425 | + | |
426 | 426 | | |
427 | 427 | | |
428 | 428 | | |
| |||
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | | - | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
| 33 | + | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
| |||
102 | 105 | | |
103 | 106 | | |
104 | 107 | | |
| 108 | + | |
| 109 | + | |
105 | 110 | | |
106 | 111 | | |
107 | 112 | | |
| |||
195 | 200 | | |
196 | 201 | | |
197 | 202 | | |
198 | | - | |
| 203 | + | |
199 | 204 | | |
200 | 205 | | |
201 | 206 | | |
| |||
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| 43 | + | |
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
46 | | - | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
72 | | - | |
| 74 | + | |
73 | 75 | | |
74 | 76 | | |
75 | 77 | | |
| |||
80 | 82 | | |
81 | 83 | | |
82 | 84 | | |
83 | | - | |
| 85 | + | |
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
| |||
115 | 117 | | |
116 | 118 | | |
117 | 119 | | |
118 | | - | |
| 120 | + | |
119 | 121 | | |
120 | 122 | | |
121 | 123 | | |
| |||
175 | 177 | | |
176 | 178 | | |
177 | 179 | | |
178 | | - | |
| 180 | + | |
179 | 181 | | |
180 | 182 | | |
181 | 183 | | |
| |||
0 commit comments