Skip to content

Commit b80a9d9

Browse files
authored
chore: fix build and CI (#145)
# Description Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [x] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [x] Ensure the tests pass - [x] Appropriate READMEs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕 ----- The move of the examples which was merged yesterday broke the build. Also `-Dmaven.test.failure.ignore=true` in the CI job reported everything as passing, even in case of failures
1 parent 3ab3ad2 commit b80a9d9

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.github/workflows/build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ jobs:
2222
distribution: 'temurin'
2323
cache: maven
2424
- name: Build with Maven
25-
run: mvn -B package --file pom.xml -Dmaven.test.failure.ignore=true -fae
25+
run: mvn -B package --file pom.xml -fae

examples/helloworld/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<groupId>io.a2a.sdk</groupId>
99
<artifactId>a2a-java-sdk-parent</artifactId>
1010
<version>0.2.4-SNAPSHOT</version>
11+
<relativePath>../../pom.xml</relativePath>
1112
</parent>
1213

1314
<artifactId>a2a-java-sdk-examples-parent</artifactId>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@
183183
<module>sdk-jakarta</module>
184184
<module>sdk-quarkus</module>
185185
<module>tck</module>
186-
<module>examples</module>
186+
<module>examples/helloworld</module>
187187
<module>tests/server-common</module>
188188
</modules>
189189
</project>

0 commit comments

Comments
 (0)