Review fixes

Author: kabir

client/transport/jsonrpc/src/main/java/io/a2a/client/transport/jsonrpc/JSONRPCTransport.java

@@ -218,8 +218,6 @@ public ListTasksResult listTasks(ListTasksParams request, @Nullable ClientCallCo
             String httpResponseBody = sendPostRequest(payloadAndHeaders);
             ListTasksResponse response = unmarshalResponse(httpResponseBody, LIST_TASKS_RESPONSE_REFERENCE);
             return response.getResult();
-        } catch (A2AClientException e) {
-            throw e;
         } catch (IOException | InterruptedException e) {
             throw new A2AClientException("Failed to list tasks: " + e, e);
         }

client/transport/rest/src/main/java/io/a2a/client/transport/rest/RestTransport.java

@@ -231,39 +231,32 @@ public ListTasksResult listTasks(ListTasksParams request, @Nullable ClientCallCo
                     responseBuilder.getTasksCount(),
                     responseBuilder.getNextPageToken().isEmpty() ? null : responseBuilder.getNextPageToken()
             );
-        } catch (A2AClientException e) {
-            throw e;
         } catch (IOException | InterruptedException e) {
             throw new A2AClientException("Failed to list tasks: " + e, e);
         }
     }
 
     private String buildListTasksQueryString(ListTasksParams request) {
-        StringBuilder sb = new StringBuilder();
+        java.util.List<String> queryParts = new java.util.ArrayList<>();
         if (request.contextId() != null) {
-            sb.append("contextId=").append(URLEncoder.encode(request.contextId(), StandardCharsets.UTF_8));
+            queryParts.add("contextId=" + URLEncoder.encode(request.contextId(), StandardCharsets.UTF_8));
         }
         if (request.status() != null) {
-            if (sb.length() > 0) sb.append("&");
-            sb.append("status=").append(request.status().asString());
+            queryParts.add("status=" + request.status().asString());
         }
         if (request.pageSize() != null) {
-            if (sb.length() > 0) sb.append("&");
-            sb.append("pageSize=").append(request.pageSize());
+            queryParts.add("pageSize=" + request.pageSize());
         }
         if (request.pageToken() != null) {
-            if (sb.length() > 0) sb.append("&");
-            sb.append("pageToken=").append(URLEncoder.encode(request.pageToken(), StandardCharsets.UTF_8));
+            queryParts.add("pageToken=" + URLEncoder.encode(request.pageToken(), StandardCharsets.UTF_8));
         }
         if (request.historyLength() != null) {
-            if (sb.length() > 0) sb.append("&");
-            sb.append("historyLength=").append(request.historyLength());
+            queryParts.add("historyLength=" + request.historyLength());
         }
         if (request.includeArtifacts() != null && request.includeArtifacts()) {
-            if (sb.length() > 0) sb.append("&");
-            sb.append("includeArtifacts=true");
+            queryParts.add("includeArtifacts=true");
         }
-        return sb.toString();
+        return String.join("&", queryParts);
     }
 
     @Override

extras/task-store-database-jpa/src/main/java/io/a2a/extras/taskstore/database/jpa/JpaTask.java

@@ -130,8 +130,11 @@ static JpaTask createFromTask(Task task) throws JsonProcessingException {
      */
     private void updateDenormalizedFields(Task task) {
         this.contextId = task.getContextId();
-        if (task.getStatus() != null && task.getStatus().state() != null) {
-            this.state = task.getStatus().state().asString();
+        if (task.getStatus() != null) {
+            io.a2a.spec.TaskState taskState = task.getStatus().state();
+            this.state = (taskState != null) ? taskState.asString() : null;
+        } else {
+            this.state = null;
         }
     }
 

spec/src/main/java/io/a2a/spec/ListTasksResult.java

@@ -31,6 +31,9 @@ public record ListTasksResult(
         if (pageSize < 0) {
             throw new IllegalArgumentException("pageSize must be non-negative");
         }
+        if (pageSize != tasks.size()) {
+            throw new IllegalArgumentException("pageSize must be equal to the number of tasks in the list. Got " + pageSize + ", but list has " + tasks.size() + " tasks.");
+        }
         // Make defensive copy
         tasks = List.copyOf(tasks);
     }