Skip to content

Commit c8dfcc9

Browse files
committed
Gemini feedback
1 parent 96f1dca commit c8dfcc9

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

spec/src/main/java/io/a2a/json/JsonUtil.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -552,12 +552,9 @@ public void write(JsonWriter out, Part<?> value) throws java.io.IOException {
552552
out.name("file");
553553
delegateGson.toJson(filePart.file(), FileContent.class, out);
554554
} else if (value instanceof DataPart dataPart) {
555-
// DataPart: { "data": { "data": {...} } }
556-
out.name("data");
557-
out.beginObject();
555+
// DataPart: { "data": {...} }
558556
out.name("data");
559557
delegateGson.toJson(dataPart.data(), Map.class, out);
560-
out.endObject();
561558
} else {
562559
throw new JsonSyntaxException("Unknown Part subclass: " + value.getClass().getName());
563560
}
@@ -589,14 +586,10 @@ Part<?> read(JsonReader in) throws java.io.IOException {
589586
// FilePart: { "file": {...} }
590587
return new FilePart(delegateGson.fromJson(jsonObject.get("file"), FileContent.class));
591588
} else if (jsonObject.has("data")) {
592-
// DataPart: { "data": { "data": {...} } }
593-
com.google.gson.JsonObject dataWrapper = jsonObject.getAsJsonObject("data");
594-
if (dataWrapper == null || !dataWrapper.has("data")) {
595-
throw new JsonSyntaxException("DataPart wrapper must contain 'data' field");
596-
}
589+
// DataPart: { "data": {...} }
597590
@SuppressWarnings("unchecked")
598591
Map<String, Object> dataMap = delegateGson.fromJson(
599-
dataWrapper.get("data"),
592+
jsonObject.get("data"),
600593
new TypeToken<Map<String, Object>>(){}.getType()
601594
);
602595
return new DataPart(dataMap);

spec/src/test/java/io/a2a/spec/TaskSerializationTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -559,10 +559,8 @@ void testDeserializeTaskWithDataPartFromJson() throws JsonProcessingException {
559559
"parts": [
560560
{
561561
"data": {
562-
"data": {
563-
"temperature": 22.5,
564-
"humidity": 65
565-
}
562+
"temperature": 22.5,
563+
"humidity": 65
566564
}
567565
}
568566
]

0 commit comments

Comments
 (0)