Commit d2c5795
committed
fix: Add missing config ID to RestTransportTest push notification test
The testSetTaskPushNotificationConfiguration was failing because the
PushNotificationConfig was created without an ID. This caused the
request to not match the expected protobuf format which requires both
a configId field and the ID in the resource name path.
Changes:
- Added .id("default-config-id") to PushNotificationConfig.Builder in RestTransportTest.java
- Updated SET_TASK_PUSH_NOTIFICATION_CONFIG_TEST_REQUEST in JsonRestMessages.java to include:
- configId field at top level
- Full resource name with config ID in path: tasks/{taskId}/pushNotificationConfigs/{configId}
This matches the pattern used in the working JSONRPCTransportTest.
Test now passes: ✅ RestTransportTest.testSetTaskPushNotificationConfiguration1 parent e8240df commit d2c5795
File tree
2 files changed
+3
-1
lines changed- client/transport/rest/src/test/java/io/a2a/client/transport/rest
2 files changed
+3
-1
lines changedLines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
| 350 | + | |
350 | 351 | | |
351 | | - | |
| 352 | + | |
352 | 353 | | |
353 | 354 | | |
354 | 355 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
| 307 | + | |
307 | 308 | | |
308 | 309 | | |
309 | 310 | | |
| |||
0 commit comments