fix: Check for empty notification ID in InMemoryPushNotificationConfigStore#setInfo

fjuma · fjuma · commit ef6415a18917 · 2025-08-20T14:00:19.000-04:00
diff --git a/server-common/src/main/java/io/a2a/server/tasks/InMemoryPushNotificationConfigStore.java b/server-common/src/main/java/io/a2a/server/tasks/InMemoryPushNotificationConfigStore.java
@@ -30,7 +30,7 @@ public InMemoryPushNotificationConfigStore() {
     public PushNotificationConfig setInfo(String taskId, PushNotificationConfig notificationConfig) {
         List<PushNotificationConfig> notificationConfigList = pushNotificationInfos.getOrDefault(taskId, new ArrayList<>());
         PushNotificationConfig.Builder builder = new PushNotificationConfig.Builder(notificationConfig);
-        if (notificationConfig.id() == null) {
+        if (notificationConfig.id() == null || notificationConfig.id().isEmpty()) {
             builder.id(taskId);
         }
         notificationConfig = builder.build();

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public InMemoryPushNotificationConfigStore() {`
`30`	`30`	`public PushNotificationConfig setInfo(String taskId, PushNotificationConfig notificationConfig) {`
`31`	`31`	`List<PushNotificationConfig> notificationConfigList = pushNotificationInfos.getOrDefault(taskId, new ArrayList<>());`
`32`	`32`	`PushNotificationConfig.Builder builder = new PushNotificationConfig.Builder(notificationConfig);`
`33`		`- if (notificationConfig.id() == null) {`
	`33`	`+ if (notificationConfig.id() == null \|\| notificationConfig.id().isEmpty()) {`
`34`	`34`	`builder.id(taskId);`
`35`	`35`	`}`
`36`	`36`	`notificationConfig = builder.build();`