Commit 86f6cfa
ci: use esbuild to ensure client and root entry points build for browser (#210)
# Description
Add an automated test for the issue solved previously in #46 to ensure
that client and root entry points build for browsers.
Example failure would look like:
```
✘ [ERROR] Could not resolve "events"
dist/server/index.js:27:29:
27 │ import { EventEmitter } from "events";
╵ ~~~~~~~~
The package "events" wasn't found on the file system but is built into node. Are you trying to
bundle for node? You can use "--platform=node" to do that, which will remove this error.
```
(obtained by running `esbuild ./dist/server/index.js --bundle
--platform=browser --outdir=dist/tmp-checks --outbase=./dist`)
---------
Co-authored-by: Guglielmo Colombo <guglielmoc@google.com>1 parent 2768ae8 commit 86f6cfa
File tree
3 files changed
+29
-1
lines changed- .github/workflows
3 files changed
+29
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| |||
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
83 | | - | |
| 84 | + | |
| 85 | + | |
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
| |||
0 commit comments