|
| 1 | +import unittest |
| 2 | +from unittest.mock import AsyncMock, MagicMock |
| 3 | + |
| 4 | +from a2a.server.agent_execution.simple_request_context_builder import ( |
| 5 | + SimpleRequestContextBuilder, |
| 6 | +) |
| 7 | +from a2a.server.agent_execution.context import RequestContext # Corrected import path |
| 8 | +from a2a.server.tasks.task_store import TaskStore |
| 9 | +from a2a.types import ( |
| 10 | + Message, |
| 11 | + MessageSendParams, |
| 12 | + Task, |
| 13 | + # ServerCallContext, # Removed from a2a.types |
| 14 | + Role, |
| 15 | + Part, |
| 16 | + TextPart, |
| 17 | + TaskStatus, |
| 18 | + TaskState, |
| 19 | +) |
| 20 | +from a2a.server.context import ServerCallContext |
| 21 | +from a2a.auth.user import User, UnauthenticatedUser # Import User types |
| 22 | + |
| 23 | + |
| 24 | +# Helper to create a simple message |
| 25 | +def create_sample_message( |
| 26 | + content="test message", msg_id="msg1", role=Role.user, reference_task_ids=None |
| 27 | +): |
| 28 | + return Message( |
| 29 | + messageId=msg_id, |
| 30 | + role=role, |
| 31 | + parts=[Part(root=TextPart(text=content))], |
| 32 | + referenceTaskIds=reference_task_ids if reference_task_ids else [], |
| 33 | + ) |
| 34 | + |
| 35 | +# Helper to create a simple task |
| 36 | +def create_sample_task(task_id="task1", status_state=TaskState.submitted, context_id="ctx1"): |
| 37 | + return Task( |
| 38 | + id=task_id, |
| 39 | + contextId=context_id, |
| 40 | + status=TaskStatus(state=status_state), |
| 41 | + ) |
| 42 | + |
| 43 | +class TestSimpleRequestContextBuilder(unittest.IsolatedAsyncioTestCase): |
| 44 | + def setUp(self): |
| 45 | + self.mock_task_store = AsyncMock(spec=TaskStore) |
| 46 | + |
| 47 | + def test_init_with_populate_true_and_task_store(self): |
| 48 | + builder = SimpleRequestContextBuilder( |
| 49 | + should_populate_referred_tasks=True, task_store=self.mock_task_store |
| 50 | + ) |
| 51 | + self.assertTrue(builder._should_populate_referred_tasks) |
| 52 | + self.assertEqual(builder._task_store, self.mock_task_store) |
| 53 | + |
| 54 | + def test_init_with_populate_false_task_store_none(self): |
| 55 | + builder = SimpleRequestContextBuilder( |
| 56 | + should_populate_referred_tasks=False, task_store=None |
| 57 | + ) |
| 58 | + self.assertFalse(builder._should_populate_referred_tasks) |
| 59 | + self.assertIsNone(builder._task_store) |
| 60 | + |
| 61 | + def test_init_with_populate_false_task_store_provided(self): |
| 62 | + # Even if populate is false, task_store might still be provided (though not used by build for related_tasks) |
| 63 | + builder = SimpleRequestContextBuilder( |
| 64 | + should_populate_referred_tasks=False, task_store=self.mock_task_store |
| 65 | + ) |
| 66 | + self.assertFalse(builder._should_populate_referred_tasks) |
| 67 | + self.assertEqual(builder._task_store, self.mock_task_store) |
| 68 | + |
| 69 | + async def test_build_basic_context_no_populate(self): |
| 70 | + builder = SimpleRequestContextBuilder( |
| 71 | + should_populate_referred_tasks=False, task_store=self.mock_task_store |
| 72 | + ) |
| 73 | + |
| 74 | + params = MessageSendParams(message=create_sample_message()) |
| 75 | + task_id = "test_task_id_1" |
| 76 | + context_id = "test_context_id_1" |
| 77 | + current_task = create_sample_task(task_id=task_id, context_id=context_id) |
| 78 | + # Pass a valid User instance, e.g., UnauthenticatedUser or a mock spec'd as User |
| 79 | + server_call_context = ServerCallContext(user=UnauthenticatedUser(), auth_token="dummy_token") |
| 80 | + |
| 81 | + request_context = await builder.build( |
| 82 | + params=params, |
| 83 | + task_id=task_id, |
| 84 | + context_id=context_id, |
| 85 | + task=current_task, |
| 86 | + context=server_call_context, |
| 87 | + ) |
| 88 | + |
| 89 | + self.assertIsInstance(request_context, RequestContext) |
| 90 | + # Access params via its properties message and configuration |
| 91 | + self.assertEqual(request_context.message, params.message) |
| 92 | + self.assertEqual(request_context.configuration, params.configuration) |
| 93 | + self.assertEqual(request_context.task_id, task_id) |
| 94 | + self.assertEqual(request_context.context_id, context_id) |
| 95 | + self.assertEqual(request_context.current_task, current_task) # Property is current_task |
| 96 | + self.assertEqual(request_context.call_context, server_call_context) # Property is call_context |
| 97 | + self.assertEqual(request_context.related_tasks, []) # Initialized to [] |
| 98 | + self.mock_task_store.get.assert_not_called() |
| 99 | + |
| 100 | + async def test_build_populate_true_with_reference_task_ids(self): |
| 101 | + builder = SimpleRequestContextBuilder( |
| 102 | + should_populate_referred_tasks=True, task_store=self.mock_task_store |
| 103 | + ) |
| 104 | + ref_task_id1 = "ref_task1" |
| 105 | + ref_task_id2 = "ref_task2_missing" |
| 106 | + ref_task_id3 = "ref_task3" |
| 107 | + |
| 108 | + mock_ref_task1 = create_sample_task(task_id=ref_task_id1) |
| 109 | + mock_ref_task3 = create_sample_task(task_id=ref_task_id3) |
| 110 | + |
| 111 | + # Configure task_store.get mock |
| 112 | + # Note: AsyncMock side_effect needs to handle multiple calls if they have different args. |
| 113 | + # A simple way is a list of return values, or a function. |
| 114 | + async def get_side_effect(task_id): |
| 115 | + if task_id == ref_task_id1: |
| 116 | + return mock_ref_task1 |
| 117 | + if task_id == ref_task_id3: |
| 118 | + return mock_ref_task3 |
| 119 | + return None |
| 120 | + self.mock_task_store.get = AsyncMock(side_effect=get_side_effect) |
| 121 | + |
| 122 | + params = MessageSendParams( |
| 123 | + message=create_sample_message(reference_task_ids=[ref_task_id1, ref_task_id2, ref_task_id3]) |
| 124 | + ) |
| 125 | + server_call_context = ServerCallContext(user=UnauthenticatedUser()) |
| 126 | + |
| 127 | + request_context = await builder.build( |
| 128 | + params=params, task_id="t1", context_id="c1", task=None, context=server_call_context |
| 129 | + ) |
| 130 | + |
| 131 | + self.assertEqual(self.mock_task_store.get.call_count, 3) |
| 132 | + self.mock_task_store.get.assert_any_call(ref_task_id1) |
| 133 | + self.mock_task_store.get.assert_any_call(ref_task_id2) |
| 134 | + self.mock_task_store.get.assert_any_call(ref_task_id3) |
| 135 | + |
| 136 | + self.assertIsNotNone(request_context.related_tasks) |
| 137 | + self.assertEqual(len(request_context.related_tasks), 2) # Only non-None tasks |
| 138 | + self.assertIn(mock_ref_task1, request_context.related_tasks) |
| 139 | + self.assertIn(mock_ref_task3, request_context.related_tasks) |
| 140 | + |
| 141 | + async def test_build_populate_true_params_none(self): |
| 142 | + builder = SimpleRequestContextBuilder( |
| 143 | + should_populate_referred_tasks=True, task_store=self.mock_task_store |
| 144 | + ) |
| 145 | + server_call_context = ServerCallContext(user=UnauthenticatedUser()) |
| 146 | + request_context = await builder.build( |
| 147 | + params=None, task_id="t1", context_id="c1", task=None, context=server_call_context |
| 148 | + ) |
| 149 | + self.assertEqual(request_context.related_tasks, []) |
| 150 | + self.mock_task_store.get.assert_not_called() |
| 151 | + |
| 152 | + async def test_build_populate_true_reference_ids_empty_or_none(self): |
| 153 | + builder = SimpleRequestContextBuilder( |
| 154 | + should_populate_referred_tasks=True, task_store=self.mock_task_store |
| 155 | + ) |
| 156 | + server_call_context = ServerCallContext(user=UnauthenticatedUser()) |
| 157 | + |
| 158 | + # Test with empty list |
| 159 | + params_empty_refs = MessageSendParams(message=create_sample_message(reference_task_ids=[])) |
| 160 | + request_context_empty = await builder.build( |
| 161 | + params=params_empty_refs, task_id="t1", context_id="c1", task=None, context=server_call_context |
| 162 | + ) |
| 163 | + self.assertEqual(request_context_empty.related_tasks, []) # Should be [] if list is empty |
| 164 | + self.mock_task_store.get.assert_not_called() |
| 165 | + |
| 166 | + self.mock_task_store.get.reset_mock() # Reset for next call |
| 167 | + |
| 168 | + # Test with referenceTaskIds=None (Pydantic model might default it to empty list or handle it) |
| 169 | + # create_sample_message defaults to [] if None is passed, so this tests the same as above. |
| 170 | + # To explicitly test None in Message, we'd have to bypass Pydantic default or modify helper. |
| 171 | + # For now, this covers the "no IDs to process" case. |
| 172 | + msg_with_no_refs = Message(messageId="m2", role=Role.user, parts=[], referenceTaskIds=None) |
| 173 | + params_none_refs = MessageSendParams(message=msg_with_no_refs) |
| 174 | + request_context_none = await builder.build( |
| 175 | + params=params_none_refs, task_id="t2", context_id="c2", task=None, context=server_call_context |
| 176 | + ) |
| 177 | + self.assertEqual(request_context_none.related_tasks, []) |
| 178 | + self.mock_task_store.get.assert_not_called() |
| 179 | + |
| 180 | + |
| 181 | + async def test_build_populate_true_task_store_none(self): |
| 182 | + # This scenario might be prevented by constructor logic if should_populate_referred_tasks is True, |
| 183 | + # but testing defensively. The builder might allow task_store=None if it's set post-init, |
| 184 | + # or if constructor logic changes. Current SimpleRequestContextBuilder takes it at init. |
| 185 | + # If task_store is None, it should not attempt to call get. |
| 186 | + builder = SimpleRequestContextBuilder( |
| 187 | + should_populate_referred_tasks=True, task_store=None # Explicitly None |
| 188 | + ) |
| 189 | + params = MessageSendParams( |
| 190 | + message=create_sample_message(reference_task_ids=["ref1"]) |
| 191 | + ) |
| 192 | + server_call_context = ServerCallContext(user=UnauthenticatedUser()) |
| 193 | + |
| 194 | + request_context = await builder.build( |
| 195 | + params=params, task_id="t1", context_id="c1", task=None, context=server_call_context |
| 196 | + ) |
| 197 | + # Expect related_tasks to be an empty list as task_store is None |
| 198 | + self.assertEqual(request_context.related_tasks, []) |
| 199 | + # No mock_task_store to check calls on, this test is mostly for graceful handling. |
| 200 | + |
| 201 | + |
| 202 | + async def test_build_populate_false_with_reference_task_ids(self): |
| 203 | + builder = SimpleRequestContextBuilder( |
| 204 | + should_populate_referred_tasks=False, task_store=self.mock_task_store |
| 205 | + ) |
| 206 | + params = MessageSendParams( |
| 207 | + message=create_sample_message(reference_task_ids=["ref_task_should_not_be_fetched"]) |
| 208 | + ) |
| 209 | + server_call_context = ServerCallContext(user=UnauthenticatedUser()) |
| 210 | + |
| 211 | + request_context = await builder.build( |
| 212 | + params=params, task_id="t1", context_id="c1", task=None, context=server_call_context |
| 213 | + ) |
| 214 | + self.assertEqual(request_context.related_tasks, []) |
| 215 | + self.mock_task_store.get.assert_not_called() |
| 216 | + |
| 217 | + |
| 218 | +if __name__ == "__main__": |
| 219 | + unittest.main() |
0 commit comments